Skip to contentSkip to conversation

Fix curses on big endian hosts

PATCH In review Aurelien Jarno 3 participants 5 messages Dec 29, 2010 – Jan 1, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix curses on big endian hosts

On big endian hosts, the curses interface is unusable: the emulated graphic card only displays garbage, while the monitor interface displays nothing (or rather only spaces).

The curses interface is waiting for data in native endianness, so console_write_ch() should not do any conversion. The conversion should be done when reading the video buffer in hw/vga.c. I supposed this buffer is in little endian mode, though it's not impossible that the data is actually in guest endianness. I currently have no big endian guest to way (they all switch to graphic mode immediately).

---
 console.h |    2 +-
 hw/vga.c  |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
console.h +1 -1
index b2fc908..3157330 100644
@@ -329,7 +329,7 @@ static inline void console_write_ch(console_ch_t *dest, uint32_t ch)
 {
     if (!(ch & 0xff))
         ch |= ' ';
-    cpu_to_le32wu((uint32_t *) dest, ch);
+    *dest = ch;
 }
 
 typedef void (*vga_hw_update_ptr)(void *);
hw/vga.c +3 -3
index c632fd7..e2151a2 100644
@@ -2073,14 +2073,14 @@ static void vga_update_text(void *opaque, console_ch_t *chardata)
 
         if (full_update) {
             for (i = 0; i < size; src ++, dst ++, i ++)
-                console_write_ch(dst, VMEM2CHTYPE(*src));
+                console_write_ch(dst, VMEM2CHTYPE(le32_to_cpu(*src)));
 
             dpy_update(s->ds, 0, 0, width, height);
         } else {
             c_max = 0;
 
             for (i = 0; i < size; src ++, dst ++, i ++) {
-                console_write_ch(&val, VMEM2CHTYPE(*src));
+                console_write_ch(&val, VMEM2CHTYPE(le32_to_cpu(*src)));
                 if (*dst != val) {
                     *dst = val;
                     c_max = i;
@@ -2089,7 +2089,7 @@ static void vga_update_text(void *opaque, console_ch_t *chardata)
             }
             c_min = i;
             for (; i < size; src ++, dst ++, i ++) {
-                console_write_ch(&val, VMEM2CHTYPE(*src));
+                console_write_ch(&val, VMEM2CHTYPE(le32_to_cpu(*src)));
                 if (*dst != val) {
                     *dst = val;
                     c_max = i;
Signature · 1 line
1.7.2.3
#1 lore raw
Quoted 10 lines · Aurelien Jarno

On big endian hosts, the curses interface is unusable: the emulated graphic card only displays garbage, while the monitor interface displays nothing (or rather only spaces).

The curses interface is waiting for data in native endianness, so console_write_ch() should not do any conversion. The conversion should be done when reading the video buffer in hw/vga.c. I supposed this buffer is in little endian mode, though it's not impossible that the data is actually in guest endianness. I currently have no big endian guest to way (they all switch to graphic mode immediately).

First versions of OpenBIOS for Sparc64 used text console, I switched to VBE frame buffer later.

I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would be always little endian, so why the checks?

#2 lore raw
Quoted 12 lines · Blue Swirl
Quoted 10 lines · Aurelien Jarno

On big endian hosts, the curses interface is unusable: the emulated graphic card only displays garbage, while the monitor interface displays nothing (or rather only spaces).

The curses interface is waiting for data in native endianness, so console_write_ch() should not do any conversion. The conversion should be done when reading the video buffer in hw/vga.c. I supposed this buffer is in little endian mode, though it's not impossible that the data is actually in guest endianness. I currently have no big endian guest to way (they all switch to graphic mode immediately).

Quoted 2 lines

First versions of OpenBIOS for Sparc64 used text console, I switched to VBE frame buffer later.

Do you know if it is easy to switch back to text console? That would be an easy way to check what is correct.

Quoted 4 lines

I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would be always little endian, so why the checks?

I also don't explain them. I have tried to remove them, and powerpc and sparc target still seems to work.

Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net
#3 lore raw

Am 31.12.2010 um 20:10 schrieb Aurelien Jarno:

Quoted 8 lines · Blue Swirl
Quoted 4 lines

I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would be always little endian, so why the checks?

I also don't explain them. I have tried to remove them, and powerpc and sparc target still seems to work.

Does it have any effect on the penguin colors? Blue and me once fiddled to remedy Tux' foot-and-beak disease on Darwin/i386, and I remember seeing apparently random colors for ppc guests on various hosts:

http://afaerber.planche.de/#ppc_2009_12_20

Andreas

#4 lore raw
Quoted 13 lines · Andreas Färber

Am 31.12.2010 um 20:10 schrieb Aurelien Jarno:

Quoted 10 lines · Blue Swirl
Quoted 5 lines

I'm also puzzled by the uses of TARGET_WORDS_BIGENDIAN in hw/vga_template.h. I'd suppose that VGA (especially PCI devices) would
be always little endian, so why the checks?

I also don't explain them. I have tried to remove them, and powerpc and
sparc target still seems to work.

Quoted 6 lines

Does it have any effect on the penguin colors? Blue and me once fiddled to remedy Tux' foot-and-beak disease on Darwin/i386, and I remember seeing apparently random colors for ppc guests on various hosts:

http://afaerber.planche.de/#ppc_2009_12_20

No, it doesn't change anything related to the graphic mode, it only affects curses.

Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net