staging:rtl8187se trivial fix typos in comments.
cover staging:rtl8187se trivial fix typos in comments.
Below is a set of patches that fix some comments in either a typo or makes the comment more understanding(from the best that I can decipher)..
Please let me know if there is anything I missed, and I'll fix it up
and resend.
drivers/staging/rtl8187se/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8187se/ieee80211/ieee80211.h | 10 ++-- .../staging/rtl8187se/ieee80211/ieee80211_crypt.c | 4 +- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 4 +- .../rtl8187se/ieee80211/ieee80211_softmac.c | 58 ++++++++++---------- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 2 +- drivers/staging/rtl8187se/r8180.h | 6 +- drivers/staging/rtl8187se/r8180_93cx6.h | 2 +- drivers/staging/rtl8187se/r8180_core.c | 38 +++++++------- drivers/staging/rtl8187se/r8180_dm.c | 24 ++++---- drivers/staging/rtl8187se/r8180_hw.h | 8 ++-- drivers/staging/rtl8187se/r8180_rtl8225z2.c | 4 +- drivers/staging/rtl8187se/r8180_wx.c | 4 +- drivers/staging/rtl8187se/r8180_wx.h | 2 +- drivers/staging/rtl8187se/r8185b_init.c | 8 ++-- 15 files changed, 88 insertions(+), 88 deletions(-)
Justin P. Mattock
PATCH 1/15 drivers:staging:rtl8187se:r8180_93cx6.h Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_93cx6.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/rtl8187se/r8180_93cx6.h +1 -1
@@ -7,7 +7,7 @@Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver -We want to tanks the Authors of such projects and the Ndiswrapper project Authors. +We want to thanks the Authors of such projects and the Ndiswrapper project Authors. */ /*This files contains card eeprom (93c46 or 93c56) programming routines*/
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 2/15 drivers:staging:rtl8187se:r8180_core.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_core.c | 38 ++++++++++++++++---------------- 1 files changed, 19 insertions(+), 19 deletions(-)
drivers/staging/rtl8187se/r8180_core.c +19 -19
@@ -17,7 +17,7 @@ Some ideas borrowed from the 8139too.c driver included in linux kernel. - We (I?) want to thanks the Authors of those projecs and also the + We (I?) want to thanks the Authors of those projects and also the Ndiswrapper's project Authors. A big big thanks goes also to Realtek corp. for their help in my attempt to
@@ -1380,7 +1380,7 @@ long TranslateToDbm8185(u8 SignalStrengthIndex)/* * Perform signal smoothing for dynamic mechanism. -* This is different with PerformSignalSmoothing8185 in smoothing fomula. +* This is different with PerformSignalSmoothing8185 in smoothing formula. * No dramatic adjustion is apply because dynamic mechanism need some degree * of correctness. Ported from 8187B. */
@@ -1591,7 +1591,7 @@ void rtl8180_rx(struct net_device *dev) priv->RSSI =RSSI ;/* SQ translation formula is provided by SD3 DZ. 2006.06.27 */ if (quality >=127 ) - quality =1 ;/*0; */ /* 0 will cause epc to show signal zero , walk aroud now; */ + quality =1 ;/*0; */ /* 0 will cause epc to show signal zero , workaround for now; */ else if (quality <27 ) quality =100 ;else
@@ -1620,7 +1620,7 @@ void rtl8180_rx(struct net_device *dev)/* Perform signal smoothing for dynamic * mechanism on demand. This is different * with PerformSignalSmoothing8185 in smoothing -* fomula. No dramatic adjustion is apply +* formula. No dramatic adjustion is apply * because dynamic mechanism need some degree * of correctness. */ PerformUndecoratedSignalSmoothing8185 (priv, bCckRate);
@@ -1646,7 +1646,7 @@ void rtl8180_rx(struct net_device *dev)if (first) {if (!priv->rx_skb_complete) { -/* seems that HW sometimes fails to reiceve and +/* seems that HW sometimes fails to receive and doesn't provide the last descriptor */ dev_kfree_skb_any (priv->rx_skb); priv->stats.rxnolast++;
@@ -1784,9 +1784,9 @@ rate) {/* * This function doesn't require lock because we make * sure it's called with the tx_lock already acquired. -* this come from the kernel's hard_xmit callback (through -* the ieee stack, or from the try_wake_queue (again through -* the ieee stack. +* this comes from the kernel's hard_xmit callback through +* the ieee stack, or from the try_wake_queue(again through +* the ieee stack). */ priority =AC2Q (skb->priority);spin_lock_irqsave (&priv->tx_lock, flags);
@@ -1815,7 +1815,7 @@ rate) {* If the ring is full packet are dropped (for data frame the queue * is stopped before this can happen). For this reason it is better * if the descriptors are larger than the largest management frame -* we intend to TX: i'm unsure what the HW does if it will not found +* we intend to TX: i'm unsure what the HW does if it has not found * the last fragment of a frame because it has been dropped... * Since queues for Management and Data frames are different we * might use a different lock than tx_lock (for example mgmt_tx_lock)
@@ -1916,8 +1916,8 @@ void rtl8180_prepare_beacon(struct net_device *dev) }/* -* This function do the real dirty work: it enqueues a TX command -* descriptor in the ring buffer, copyes the frame in a TX buffer +* This function does the real dirty work: it enqueues a TX command +* descriptor in the ring buffer, copies the frame in a TX buffer * and kicks the NIC to ensure it does the DMA transfer. */ short rtl8180_tx(struct net_device *dev, u8* txbuf, int len, int priority,
@@ -2092,7 +2092,7 @@ short rtl8180_tx(struct net_device *dev, u8* txbuf, int len, int priority,if (remain == len && !descfrag) { ownbit_flag = false; - *tail = *tail | (1 <<29 ) ;/* fist segment of the packet */ + *tail = *tail | (1 <<29 ) ;/* first segment of the packet */ *tail = *tail | (len); }else { ownbit_flag = true;
@@ -2367,7 +2367,7 @@ void rtl8180_wmm_param_update(struct work_struct *work)u8 u1bAIFS;u32 u4bAcParam; pAcParam = (PAC_PARAM )(&AcParam); -/* Retrive paramters to udpate. */ +/* Retrieve paramters to update. */ u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * (((mode&IEEE_G ) ==IEEE_G ) ?9 :20 ) + aSifsTime; u4bAcParam = ((((u32)(pAcParam->f.TXOPLimit))<<AC_PARAM_TXOP_LIMIT_OFFSET)| (((u32)(pAcParam->f.Ecw.f.ECWmax))<<AC_PARAM_ECW_MAX_OFFSET)|
@@ -2403,7 +2403,7 @@ void rtl8180_wmm_param_update(struct work_struct *work)u8 u1bAIFS;u32 u4bAcParam; -/* Retrive paramters to udpate. */ +/* Retrieve paramters to update. */ eACI = pAcParam->f.AciAifsn.f.ACI;/* Mode G/A: slotTimeTimer = 9; Mode B: 20 */ u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * (((mode&IEEE_G ) ==IEEE_G ) ?9 :20 ) + aSifsTime;
@@ -2613,7 +2613,7 @@ short rtl8180_init(struct net_device *dev)DMESG ("Channel plan is %d\n" , priv->channel_plan);rtl8180_set_channel_map (priv->channel_plan, priv->ieee80211); -/* FIXME: these constants are placed in a bad pleace. */ +/* FIXME: these constants are placed in a bad place. */ priv->txbuffsize =2048 ;/* 1024; */ priv->txringcount =32 ;/* 32; */ priv->rxbuffersize =2048 ;/* 1024; */
@@ -2689,7 +2689,7 @@ short rtl8180_init(struct net_device *dev) priv->bTxPowerTrack = false; priv->ThermalMeter =0 ; priv->FalseAlarmRegValue =0 ; - priv->RegDigOfdmFaUpTh =0xc ;/* Upper threhold of OFDM false alarm, which is used in DIG. */ + priv->RegDigOfdmFaUpTh =0xc ;/* Upper threshold of OFDM false alarm, which is used in DIG. */ priv->DIG_NumberFallbackVote =0 ; priv->DIG_NumberUpgradeVote =0 ; priv->LastSignalStrengthInPercent =0 ;
@@ -2885,7 +2885,7 @@ short rtl8180_init(struct net_device *dev) priv->chtxpwr_ofdm[i+1 ] = (word &0xff00 ) >>8 ; } -/* 3Read crystal calibtration and thermal meter indication on 87SE. */ +/* 3Read crystal calibration and thermal meter indication on 87SE. */ eeprom_93cx6_read (&eeprom,EEPROM_RSV >>1 , &tmpu16);/* Crystal calibration for Xin and Xout resp. */
@@ -3128,7 +3128,7 @@ void rtl8180_adapter_start(struct net_device *dev)/* * The following is very strange. seems to be that 1 means test mode, -* but we need to acknolwledges the nic when a packet is ready +* but we need to acknowledge the nic when a packet is ready * although we set it to 0 */
@@ -3883,7 +3883,7 @@ void rtl8180_tx_isr(struct net_device *dev, int pri, short error)* If the packet previous of the nic pointer has been * processed this doesn't matter: it will be checked * here at the next round. Anyway if no more packet are -* TXed no memory leak occour at all. +* TXed no memory leak occur at all. */ switch (pri) {
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 3/15 drivers:staging:rtl8187se:r8180_dm.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_dm.c | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-)
drivers/staging/rtl8187se/r8180_dm.c +12 -12
@@ -6,7 +6,7 @@// // Description: -// Return TRUE if we shall perform High Power Mecahnism, FALSE otherwise. +// Return TRUE if we shall perform High Power Mechanism, FALSE otherwise. // //+by amy 080312 #define RATE_ADAPTIVE_TIMER_PERIOD 300
@@ -35,7 +35,7 @@ bool CheckHighPower(struct net_device *dev)// See also DoRxHighPower() and SetTxPowerLevel8185() for reference. // // Note: -// The reason why we udpate Tx power level here instead of DoRxHighPower() +// The reason why we update Tx power level here instead of DoRxHighPower() // is the number of IO to change Tx power is much more than channel TR switch // and they are related to OFDM and MAC registers. // So, we don't want to update it so frequently in per-Rx packet base.
@@ -78,7 +78,7 @@ DoTxHighPower( priv->bToUpdateTxPwr = true; u1bTmp=read_nic_byte (dev,CCK_TXAGC ); -// If it never enter High Power. +// If it never enters High Power. if ( CckTxPwrIdx == u1bTmp) { u1bTmp = (u1bTmp >16 ) ? (u1bTmp -16 ):0 ;// 8dbm
@@ -145,7 +145,7 @@ void rtl8180_tx_pw_wq (struct work_struct *work)// // Description: -// Return TRUE if we shall perform DIG Mecahnism, FALSE otherwise. +// Return TRUE if we shall perform DIG Mechanism, FALSE otherwise. // bool CheckDig(
@@ -650,7 +650,7 @@ StaRateAdaptive87SE(// // For Netgear case, I comment out the following signal strength estimation, -// which can results in lower rate to transmit when sample is NOT enough (e.g. PING request). +// which can result in lower rate to transmit when sample is NOT enough (e.g. PING request). // 2007.04.09, by Roger. //
@@ -687,7 +687,7 @@ StaRateAdaptive87SE( {//2 For Test Upgrading mechanism // Note: -// Sometimes the throughput is upon on the capability bwtween the AP and NIC, +// Sometimes the throughput is upon on the capability between the AP and NIC, // thus the low data rate does not improve the performance. // We randomly upgrade the data rate and check if the retry rate is improved.
@@ -990,7 +990,7 @@ StaRateAdaptive87SE( bUpdateInitialGain = true;// The difference in throughput between 48Mbps and 36Mbps is 8M. -// So, we must be carefully in this rate scale. Isaiah 2008-02-15. +// So, we must be careful in this rate scale. Isaiah 2008-02-15. // if ( ((priv->CurrentOperaRate ==72 ) || (priv->CurrentOperaRate ==48 ) || (priv->CurrentOperaRate ==36 )) && (priv->FailTxRateCount >2 ) )
@@ -1498,11 +1498,11 @@ SwAntennaDiversity(// didn't changed by HW evaluation. // 2008.02.27. // -// [TRC Dell Lab] SignalStrength is inaccuracy. Isaiah 2008-03-05 +// [TRC Dell Lab] SignalStrength is inaccurate. Isaiah 2008-03-05 // For example, Throughput of aux is better than main antenna(about 10M v.s 2M), // but AdRxSignalStrength is less than main. -// Our guess is that main antenna have lower throughput and get many change -// to receive more CCK packets(ex.Beacon) which have stronger SignalStrength. +// Our guess is that main antenna has lower throughput and gets many changes +// to receive more CCK packets(ex.Beacon) which has stronger SignalStrength. // if ( (!priv->bHWAdSwitched) && (bSwCheckSS)) {
@@ -1526,7 +1526,7 @@ SwAntennaDiversity( priv->bAdSwitchedChecking = false;// Increase Rx signal strength threshold if necessary. if ( (priv->AdRxSignalStrength > (priv->AdRxSsThreshold +10 )) &&// Signal is much stronger than current threshold - priv->AdRxSsThreshold <= priv->AdMaxRxSsThreshold)// Current threhold is not yet reach upper limit. + priv->AdRxSsThreshold <= priv->AdMaxRxSsThreshold)// Current threshold is not yet reach upper limit. { priv->AdRxSsThreshold = (priv->AdRxSsThreshold + priv->AdRxSignalStrength) /2 ; priv->AdRxSsThreshold = (priv->AdRxSsThreshold > priv->AdMaxRxSsThreshold) ?
@@ -1555,7 +1555,7 @@ SwAntennaDiversity(// // Description: -// Return TRUE if we shall perform Tx Power Tracking Mecahnism, FALSE otherwise. +// Return TRUE if we shall perform Tx Power Tracking Mechanism, FALSE otherwise. // bool CheckTxPwrTracking (struct net_device *dev)
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 4/15 drivers:staging:rtl8187se:r8180.h Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8187se/r8180.h +3 -3
@@ -11,7 +11,7 @@Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver -We want to tanks the Authors of those projects and the Ndiswrapper +We want to thanks the Authors of those projects and the Ndiswrapper project Authors. */
@@ -235,7 +235,7 @@ typedef struct _link_detect_tu32 LastNumTxUnicast;u32 LastNumRxUnicast; -bool bBusyTraffic;//when it is set to 1, UI cann't scan at will. +bool bBusyTraffic;//when it is set to 1, UI can't scan at will. }link_detect_t, *plink_detect_t;//YJ,modified,080828,end
@@ -552,7 +552,7 @@ typedef struct r8180_privbool bDigMechanism;// TRUE if DIG is enabled, FALSE ow. bool bRegHighPowerMechanism;// For High Power Mechanism. 061010, by rcnjko. u32 FalseAlarmRegValue; -u8 RegDigOfdmFaUpTh;// Upper threhold of OFDM false alarm, which is used in DIG. +u8 RegDigOfdmFaUpTh;// Upper threshold of OFDM false alarm, which is used in DIG. u8 DIG_NumberFallbackVote;u8 DIG_NumberUpgradeVote;// For HW antenna diversity, added by Roger, 2008.01.30.
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 5/15 drivers:staging:rtl8187se:r8180_hw.h Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_hw.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8187se/r8180_hw.h +4 -4
@@ -10,7 +10,7 @@Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. -We want to tanks the Authors of those projects +We want to thanks the Authors of those projects and the Ndiswrapper project Authors. */
@@ -181,7 +181,7 @@#define RF_SW_CFG_SI BIT1#define EIFS 0x2D/* Extended InterFrame Space Timer, in unit of 4 us. */ -#define BRSR 0x34/* Basic rate set */ +#define BRSR 0x34/* Basic rate set */ #define IMR 0x006C#define ISR 0x003C
@@ -286,7 +286,7 @@#define CR_MulRW ((1 << 0))#define IMR_Dot11hInt ((1 << 25))/*802.11h Measurement Interrupt */ -#define IMR_BcnDmaInt ((1 << 24))/*Beacon DMA Interrupt */ /*What differenct between BcnDmaInt and BcnInt??? */ +#define IMR_BcnDmaInt ((1 << 24))/*Beacon DMA Interrupt */ /*What difference between BcnDmaInt and BcnInt??? */ #define IMR_WakeInt ((1 << 23))/*Wake Up Interrupt */ #define IMR_TXFOVW ((1 << 22))/*Tx FIFO Overflow Interrupt */ #define IMR_TimeOut1 ((1 << 21))/*Time Out Interrupt 1 */
@@ -313,7 +313,7 @@#define IMR_TimeOut3 ((1 << 0))/*Time Out Interrupt 3 */ #define IMR_TMGDOK ((1 << 30))#define ISR_Dot11hInt ((1 << 25))/*802.11h Measurement Interrupt */ -#define ISR_BcnDmaInt ((1 << 24))/*Beacon DMA Interrupt */ /*What differenct between BcnDmaInt and BcnInt??? */ +#define ISR_BcnDmaInt ((1 << 24))/*Beacon DMA Interrupt */ /*What difference between BcnDmaInt and BcnInt??? */ #define ISR_WakeInt ((1 << 23))/*Wake Up Interrupt */ #define ISR_TXFOVW ((1 << 22))/*Tx FIFO Overflow Interrupt */ #define ISR_TimeOut1 ((1 << 21))/*Time Out Interrupt 1 */
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 6/15 drivers:staging:rtl8187se:r8180_rtl8225z2.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_rtl8225z2.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8187se/r8180_rtl8225z2.c +2 -2
@@ -479,7 +479,7 @@ s8 DbmToTxPwrIdx(struct r8180_priv *priv, WIRELESS_MODE WirelessMode,/* * TRUE if we want to use a default implementation. -* We shall set it to FALSE when we have exact translation formular +* We shall set it to FALSE when we have exact translation formula * for target IC. 070622, by rcnjko. */ if (bUseDefault) {
@@ -688,7 +688,7 @@ void rtl8225z2_rf_init(struct net_device *dev)write_rtl8225 (dev,0x2 ,0xc4d ); -/* FIXME!! rtl8187 we have to check if calibrarion +/* FIXME!! rtl8187 we have to check if calibration * is successful and eventually cal. again (repeat * the two write on reg 2) */
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 7/15 drivers:staging:rtl8187se:r8180_wx.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_wx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8187se/r8180_wx.c +2 -2
@@ -13,7 +13,7 @@Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. -We want to tanks the Authors of those projects and the Ndiswrapper +We want to thanks the Authors of those projects and the Ndiswrapper project Authors. */
@@ -1529,7 +1529,7 @@ static inline int is_same_network(struct ieee80211_network *src, (dst->capability & WLAN_CAPABILITY_BSS))); } -/* WB modefied to show signal to GUI on 18-01-2008 */ +/* WB modified to show signal to GUI on 18-01-2008 */ static struct iw_statistics *r8180_get_wireless_stats (struct net_device *dev) {struct r8180_priv *priv =ieee80211_priv (dev);
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 8/15 drivers:staging:rtl8187se:r8180_wx.h Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8180_wx.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/rtl8187se/r8180_wx.h +1 -1
@@ -7,7 +7,7 @@Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver -We want to tanks the Authors of such projects and the Ndiswrapper project Authors. +We want to thanks the Authors of such projects and the Ndiswrapper project Authors. */ /* this file (will) contains wireless extension handlers*/
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 9/15 drivers:staging:rtl8187se:r8185b_init.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/r8185b_init.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8187se/r8185b_init.c +4 -4
@@ -1103,7 +1103,7 @@ ActUpdateChannelAccessSetting(u8 u1bAIFS;u32 u4bAcParam; -/* Retrive paramters to udpate. */ +/* Retreive paramters to update. */ eACI = pAcParam->f.AciAifsn.f.ACI; u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * ChnlAccessSetting->SlotTimeTimer + aSifsTime; u4bAcParam = ((((u32)(pAcParam->f.TXOPLimit)) << AC_PARAM_TXOP_LIMIT_OFFSET) |
@@ -1338,7 +1338,7 @@ MgntDisconnect( {struct r8180_priv *priv = (struct r8180_priv *)ieee80211_priv (dev);/* -Schedule an workitem to wake up for ps mode, 070109, by rcnjko. +Schedule a workitem to wake up for ps mode, 070109, by rcnjko. */ if (IS_DOT11D_ENABLE (priv->ieee80211))
@@ -1549,7 +1549,7 @@ IPSEnter(Do not enter IPS in the following conditions: (1) RF is already OFF or Sleep (2) bSwRfProcessing (indicates the IPS is still under going) -(3) Connectted (only disconnected can trigger IPS) +(3) Connected (only disconnected can trigger IPS) (4) IBSS (send Beacon) (5) AP mode (send Beacon) */
@@ -1652,7 +1652,7 @@ void rtl8185b_adapter_start(struct net_device *dev)/* We assume RegWirelessMode has already been initialized before, -however, we has to validate the wireless mode here and provide a +however, we have to validate the wireless mode here and provide a reasonable initialized value if necessary. 2005.01.13, by rcnjko. */ SupportedWirelessMode =GetSupportedWirelessMode8185 (dev);
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 10/15 drivers:staging:rtl8187se:ieee80211:dot11d.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/ieee80211/dot11d.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/rtl8187se/ieee80211/dot11d.c +1 -1
@@ -55,7 +55,7 @@ Dot11d_Reset(struct ieee80211_device *ieee)// // Description: -// Update country IE from Beacon or Probe Resopnse +// Update country IE from Beacon or Probe Response // and configure PHY for operation in the regulatory domain. // // TODO:
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 11/15 drivers:staging:rtl8187se:ieee80211:ieee80211_crypt.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- .../staging/rtl8187se/ieee80211/ieee80211_crypt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c +2 -2
@@ -89,8 +89,8 @@ void ieee80211_crypt_delayed_deinit(struct ieee80211_device *ieee, *crypt =NULL ;/* must not run ops->deinit() while there may be pending encrypt or -* decrypt operations. Use a list of delayed deinits to avoid needing -* locking. */ +* decrypt operations. Use a list of delayed deinits to avoid locking. +*/ spin_lock_irqsave (&ieee->lock, flags);list_add (&tmp->list, &ieee->crypt_deinit_list);
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 12/15 drivers:staging:rtl8187se:ieee80211:ieee80211.h Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/ieee80211/ieee80211.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8187se/ieee80211/ieee80211.h +5 -5
@@ -1106,7 +1106,7 @@ struct ieee80211_device {/* used instead of hard_start_xmit (not softmac_hard_start_xmit) * if the IEEE_SOFTMAC_TX_QUEUE feature is used to TX data -* frames. I the option IEEE_SOFTMAC_SINGLE_QUEUE is also set +* frames. If the option IEEE_SOFTMAC_SINGLE_QUEUE is also set * then also management frames are sent via this callback. * This function can't sleep. */
@@ -1124,7 +1124,7 @@ struct ieee80211_device {/* ask to the driver to retune the radio . * This function can sleep. the driver should ensure -* the radio has been swithced before return. +* the radio has been switched before return. */ void (*set_chan)(struct net_device *dev,short ch);
@@ -1138,9 +1138,9 @@ struct ieee80211_device {* it is called in a work_queue when swithcing to ad-hoc mode * or in behalf of iwlist scan when the card is associated * and root user ask for a scan. -* the fucntion stop_scan should stop both the syncro and +* the function stop_scan should stop both the syncro and * background scanning and can sleep. -* The fucntion start_scan should initiate the background +* The function start_scan should initiate the background * scanning and can't sleep. */ void (*scan_syncro)(struct net_device *dev);
@@ -1199,7 +1199,7 @@ struct ieee80211_device {/* Generate respones to probe requests */ #define IEEE_SOFTMAC_PROBERS (1<<5) -/* The ieee802.11 stack will manages the netif queue +/* The ieee802.11 stack will manage the netif queue * wake/stop for the driver, taking care of 802.11 * fragmentation. See softmac.c for details. */ #define IEEE_SOFTMAC_TX_QUEUE (1<<7)
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 13/15 drivers:staging:rtl8187se:ieee80211:ieee80211_rx.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c +2 -2
@@ -1373,9 +1373,9 @@ inline void ieee80211_process_probe_response( }// For Asus EeePc request, -// (1) if wireless adapter receive get any 802.11d country code in AP beacon, +// (1) if wireless adapter receive gets any 802.11d country code in AP beacon, // wireless adapter should follow the country code. -// (2) If there is no any country code in beacon, +// (2) If there is not any country code in beacon, // then wireless adapter should do active scan from ch1~11 and // passive scan from ch12~14 if (ieee->bGlobalDomain)
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 14/15 drivers:staging:rtl8187se:ieee80211:ieee80211_softmac.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- .../rtl8187se/ieee80211/ieee80211_softmac.c | 58 ++++++++++---------- 1 files changed, 29 insertions(+), 29 deletions(-)
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c +29 -29
@@ -42,7 +42,7 @@ short ieee80211_is_shortslot(struct ieee80211_network net)return (net.capability &WLAN_CAPABILITY_SHORT_SLOT ); } -/* returns the total length needed for pleacing the RATE MFIE +/* returns the total length needed for placing the RATE MFIE * tag and the EXTENDED RATE MFIE tag if needed. * It encludes two bytes per tag for the tag itself and its len */
@@ -60,7 +60,7 @@ unsigned int ieee80211_MFIE_rate_len(struct ieee80211_device *ieee)return rate_len; } -/* pleace the MFIE rate, tag to the memory (double) poined. +/* place the MFIE rate, tag to the memory(double) pointed. * Then it updates the pointer so that * it points after the new MFIE tag added. */
@@ -152,7 +152,7 @@ void enqueue_mgmt(struct ieee80211_device *ieee, struct sk_buff *skb)/* * if the queue is full but we have newer frames then -* just overwrites the oldest. +* just overwrite the oldest. * * if (nh == ieee->mgmt_queue_tail) * return -1;
@@ -456,8 +456,8 @@ void ieee80211_softmac_scan_syncro(struct ieee80211_device *ieee) }while (!channel_map[ch]);/* this function can be called in two situations * 1- We have switched to ad-hoc mode and we are -* performing a complete syncro scan before conclude -* there are no interesting cell and to create a +* performing a complete syncro scan before concluding +* there are no interesting cell's and to create a * new one. In this case the link state is * IEEE80211_NOLINK until we found an interesting cell. * If so the ieee8021_new_net, called by the RX path
@@ -465,12 +465,12 @@ void ieee80211_softmac_scan_syncro(struct ieee80211_device *ieee)* scanning * 2- We are linked and the root uses run iwlist scan. * So we switch to IEEE80211_LINKED_SCANNING to remember -* that we are still logically linked (not interested in +* that we are still logically linked(not interested in * new network events, despite for updating the net list, * but we are temporarly 'unlinked' as the driver shall -* not filter RX frames and the channel is changing. +* not filter RX frames and the channel is changing). * So the only situation in witch are interested is to check -* if the state become LINKED because of the #1 situation +* if the state becomes LINKED because of the #1 situation */ if (ieee->state ==IEEE80211_LINKED )
@@ -483,7 +483,7 @@ void ieee80211_softmac_scan_syncro(struct ieee80211_device *ieee)// printk("====send probe request\n"); ieee80211_send_probe_requests (ieee); } -/* this prevent excessive time wait when we +/* this prevents excessive time wait when we * need to wait for a syncro scan to end.. */ if (ieee->sync_scan_hurryup)
@@ -519,8 +519,8 @@ void ieee80211_softmac_ips_scan_syncro(struct ieee80211_device *ieee) {/* this function can be called in two situations * 1- We have switched to ad-hoc mode and we are -* performing a complete syncro scan before conclude -* there are no interesting cell and to create a +* performing a complete syncro scan before concluding +* there are no interesting cells and to create a * new one. In this case the link state is * IEEE80211_NOLINK until we found an interesting cell. * If so the ieee8021_new_net, called by the RX path
@@ -528,10 +528,10 @@ void ieee80211_softmac_ips_scan_syncro(struct ieee80211_device *ieee)* scanning * 2- We are linked and the root uses run iwlist scan. * So we switch to IEEE80211_LINKED_SCANNING to remember -* that we are still logically linked (not interested in +* that we are still logically linked(not interested in * new network events, despite for updating the net list, * but we are temporarly 'unlinked' as the driver shall -* not filter RX frames and the channel is changing. +* not filter RX frames and the channel is changing). * So the only situation in witch are interested is to check * if the state become LINKED because of the #1 situation */
@@ -549,7 +549,7 @@ void ieee80211_softmac_ips_scan_syncro(struct ieee80211_device *ieee)// printk("====send probe request\n"); ieee80211_send_probe_requests (ieee); } -/* this prevent excessive time wait when we +/* this prevents excessive time wait when we * need to wait for a syncro scan to end.. */ // if (ieee->sync_scan_hurryup)
@@ -1314,7 +1314,7 @@ inline void ieee80211_softmac_new_net(struct ieee80211_device *ieee, struct ieeeshort apset,ssidset,ssidbroad,apmatch,ssidmatch; -/* we are interested in new new only if we are not associated +/* we are interested in new only if we are not associated * and we are not associating / authenticating */ if (ieee->state !=IEEE80211_NOLINK )
@@ -1955,16 +1955,16 @@ associate_complete:/* following are for a simplier TX queue management. * Instead of using netif_[stop/wake]_queue the driver -* will uses these two function (plus a reset one), that -* will internally uses the kernel netif_* and takes +* will use these two functions (plus a reset one), that +* will internally use the kernel netif_* and takes * care of the ieee802.11 fragmentation. * So the driver receives a fragment per time and might -* call the stop function when it want without take care -* to have enough room to TX an entire packet. -* This might be useful if each fragment need it's own +* call the stop function when it does not have enough +* room to TX an entire packet. +* This might be useful if each fragment needs it's own * descriptor, thus just keep a total free memory > than * the max fragmentation threshold is not enough.. If the -* ieee802.11 stack passed a TXB struct then you needed +* ieee802.11 stack passed a TXB struct then you need * to keep N free descriptors where * N = MAX_PACKET_SIZE / MIN_FRAG_TRESHOLD * In this way you need just one and the 802.11 stack
@@ -2183,13 +2183,13 @@ void ieee80211_start_ibss_wq(struct work_struct *work)if (ieee->state ==IEEE80211_NOLINK ) ieee->current_network.channel =10 ; -/* if not then the state is not linked. Maybe the user swithced to +/* if not then the state is not linked. Maybe the user switched to * ad-hoc mode just after being in monitor mode, or just after -* being very few time in managed mode (so the card have had no +* being short period of time in managed mode (so the card has had no * time to scan all the chans..) or we have just run up the iface * after setting ad-hoc mode. So we have to give another try.. * Here, in ibss mode, should be safe to do this without extra care -* (in bss mode we had to make sure no-one tryed to associate when +* (in bss mode we had to make sure no-one tried to associate when * we had just checked the ieee->state and we was going to start the * scan) beacause in ibss mode the ieee80211_new_net function, when * finds a good net, just set the ieee->state to IEEE80211_LINKED,
@@ -2340,15 +2340,15 @@ void ieee80211_associate_retry_wq(struct work_struct *work)if (ieee->state !=IEEE80211_ASSOCIATING_RETRY ) goto exit;/* until we do not set the state to IEEE80211_NOLINK -* there are no possibility to have someone else trying -* to start an association procdure (we get here with +* there is no possibility to have someone else trying +* to start an association procedure (we get here with * ieee->state = IEEE80211_ASSOCIATING). * When we set the state to IEEE80211_NOLINK it is possible * that the RX path run an attempt to associate, but * both ieee80211_softmac_check_all_nets and the * RX path works with ieee->lock held so there are no * problems. If we are still disassociated then start a scan. -* the lock here is necessary to ensure no one try to start +* the lock here is necessary to ensure no one tries to start * an association procedure when we have just checked the * state and we are going to start the scan. */
@@ -2484,8 +2484,8 @@ void ieee80211_start_protocol(struct ieee80211_device *ieee)/* if the user set the MAC of the ad-hoc cell and then -* switch to managed mode, shall we make sure that association -* attempts does not fail just because the user provide the essid +* switch to managed mode, shall we make sure that association +* attempts does not fail just because the user provides the essid * and the nic is still checking for the AP MAC ?? */ switch (ieee->iw_mode) {
Signature · 1 line
1.6.5.2.180.gc5b3e
PATCH 15/15 drivers:staging:rtl8187se:ieee80211:ieee80211_tx.c Fix some comments.
Below are some patches that either fix a typo in a comment and/or fixes a comment altogether to make more sense. If there is anything I missed let me know and I'll resend.
--- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c +1 -1
@@ -445,7 +445,7 @@ int ieee80211_rtl_xmit(struct sk_buff *skb, (CFG_IEEE80211_COMPUTE_FCS | CFG_IEEE80211_RESERVE_FCS)) bytes_per_frag -=IEEE80211_FCS_LEN ; -/* Each fragment may need to have room for encryptiong pre/postfix */ +/* Each fragment may need to have room for encryption pre/postfix */ if (encrypt) bytes_per_frag -= crypt->ops->extra_prefix_len + crypt->ops->extra_postfix_len;
Signature · 1 line
1.6.5.2.180.gc5b3e