arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
Subsystems (2)
PATCH 1/1 arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
Add SNVS LPGPR bindings on this system, the LPGPR is used to store boot counter.
To: [email protected]
---
NOTE: Depends on
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 --- arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +6 -0
@@ -928,6 +928,12 @@ &sai5 { status = "disabled"; }; +&snvs { + snvs-lpgpr { + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr"; + }; +}; + &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>;
Signature · 7 lines
2.35.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 8 lines · Marek Vasut
Add SNVS LPGPR bindings on this system, the LPGPR is used to store boot counter.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Shawn Guo <[email protected]>Cc NXP Linux Team <[email protected]>
Quoted 5 lines
To: [email protected]
---
NOTE: Depends on
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
In reply to Marek VasutHi Marek,
Am Sonntag, 22. Mai 2022, 19:57:23 CEST schrieb Marek Vasut:
Quoted 23 lines
Add SNVS LPGPR bindings on this system, the LPGPR is used to store boot counter.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Shawn Guo <[email protected]>Cc NXP Linux Team <[email protected]>To: [email protected]
---
NOTE: Depends onhttps://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=fo
r-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 ---arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++ 1 file changed, 6 insertions(+)(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtsindex778bdbe228d31..93f14afc1f8a9100644
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts &sai5 { · line 933
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +3
-0@@ -928,6 +928,12 @@ &sai5 { status = "disabled"; }; +&snvs { + snvs-lpgpr { + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
lpgpr";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts &sai5 { · line 939
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +3
-0+ }; +}; + &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>;
Shouldn't this go into imx8mm.dtsi?
Best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
On 5/23/22 13:08, Alexander Stein wrote:
Hi,
[...]
Quoted 4 lines
Review
Quoted 3 lines
+&snvs {
(quoted diff) +2
-0+ snvs-lpgpr { + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr";
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts &sai5 { · line 939
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +3
-0+ }; +}; + &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>;Shouldn't this go into
imx8mm.dtsi?
No, not everyone uses this register for boot counter or wants to expose it to Linux that way. This is board-specific behavior.
(the other SNVS related entries should be in the SoC common file however, those are SoC-specific).
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
Quoted 18 lines · Alexander Stein
Hi,
[...]
Quoted 12 lines
Review
Quoted 3 lines
+&snvs {
(quoted diff) +2
-0+ snvs-lpgpr { + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr";
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +3
-0+ }; +}; + &uart1 {
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>;Shouldn't this go into
imx8mm.dtsi?No, not everyone uses this register for boot counter or wants to expose it to Linux that way. This is board-specific behavior.
Sure the actual usage of the general purpose registers is very much board- specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.
Best regards,
Alexander
Quoted 3 lines
(the other SNVS related entries should be in the SoC common file however, those are SoC-specific).
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
Quoted 24 lines · Alexander Stein
Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
Quoted 23 lines · Alexander Stein
Hi,
[...]
Quoted 16 lines
Review
Quoted 3 lines
+&snvs {
(quoted diff) +2
-0+ snvs-lpgpr { + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts &sai5 { · line 939
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts +3
-0+ }; +}; + &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>;Shouldn't this go into
imx8mm.dtsi?
Quoted 6 lines
Quoted 2 lines
No, not everyone uses this register for boot counter or wants to expose it to Linux that way. This is board-specific behavior.
Sure the actual usage of the general purpose registers is very much board- specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.
Imagine someone is storing information which shouldn't be exposed to Linux in those registers, in any way.
I see (in git grep) other SoCs already did add it unconditionally into their DTSI though, hummmmm. Then maybe we should be consistent and just add it to them all.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel