Skip to contentSkip to conversation

kvm: Fix section mismatch derived from kvm_guest_cpu_online()

PATCH Applied Sedat Dilek 5 participants 8 messages Jan 2, 2011 – Feb 2, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: Fix section mismatch derived from kvm_guest_cpu_online()

Quoted 1 line

From my build.log:

WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init() The function kvm_guest_cpu_online() references
the function __cpuinit kvm_guest_cpu_init().
This is often because kvm_guest_cpu_online lacks a __cpuinit
annotation or the annotation of kvm_guest_cpu_init is wrong.

This patch fixes the warning.

Tested with linux-next (next-20101231)

---
 arch/x86/kernel/kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/kvm.c +1 -1
index 8dc4466..33c07b0 100644
@@ -493,7 +493,7 @@ static void __init kvm_smp_prepare_boot_cpu(void)
 	native_smp_prepare_boot_cpu();
 }
 
-static void kvm_guest_cpu_online(void *dummy)
+static void __cpuinit kvm_guest_cpu_online(void *dummy)
 {
 	kvm_guest_cpu_init();
 }
Signature · 1 line
1.7.4.rc0
#1 lore raw
Quoted 8 lines · Sedat Dilek

From my build.log:

WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init() The function kvm_guest_cpu_online() references
the function __cpuinit kvm_guest_cpu_init().
This is often because kvm_guest_cpu_online lacks a __cpuinit
annotation or the annotation of kvm_guest_cpu_init is wrong.

Quoted 5 lines

This patch fixes the warning.

Tested with linux-next (next-20101231)

ACK

Signature · 1 line
All rights reversed
#3 lore raw
Quoted 5 lines · H. Peter Anvin
Quoted 2 lines · Sedat Dilek
  arch/x86/kernel/kvm.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Avi, I'm presuming this is yours?

Yes. Marcelo has kvm.git this week, he'll pick it up.

Signature · 1 line
error compiling committee.c: too many arguments to function
#4 lore raw
In reply to Sedat Dilek
Quoted 8 lines · Sedat Dilek
Quoted 1 line

From my build.log:

WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init() The function kvm_guest_cpu_online() references
the function __cpuinit kvm_guest_cpu_init().
This is often because kvm_guest_cpu_online lacks a __cpuinit
annotation or the annotation of kvm_guest_cpu_init is wrong.

Quoted 5 lines

This patch fixes the warning.

Tested with linux-next (next-20101231)

Applied, thanks.

#5 lore raw
Quoted 9 lines · Marcelo Tosatti
Quoted 8 lines · Sedat Dilek
Quoted 1 line

From my build.log:

WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init() The function kvm_guest_cpu_online() references
the function __cpuinit kvm_guest_cpu_init().
This is often because kvm_guest_cpu_online lacks a __cpuinit
annotation or the annotation of kvm_guest_cpu_init is wrong.

Quoted 9 lines
Quoted 5 lines

This patch fixes the warning.

Tested with linux-next (next-20101231)

Applied, thanks.

PING!

Was this patch really applied? I have it still in my patch-series.

- Sedat -

P.S.: My current patch-series

sd@tbox:~/src/linux-2.6$ grep OK setup_linux-next_next20110202.dileks.1.log
  (+) OK   linux-next/patch-v2.6.38-rc3-next-20110202
  (+) OK   linux-next/Remove-localversion-next.patch
  (+) OK   debian/version.patch
  (+) OK   debian/kernelvariables-v2.patch
  (+) OK   debian/doc-build-parallel.patch
  (+) OK   bugfix/ia64/hardcode-arch-script-output.patch
  (+) OK   bugfix/mips/disable-advansys.patch
  (+) OK   bugfix/arm/disable-scsi_acard.patch
  (+) OK   debian/mips-disable-werror.patch
  (+) OK   bugfix/powerpc/lpar-console.patch
  (+) OK   features/all/i915-autoload-without-CONFIG_DRM_I915_KMS.patch
  (+) OK   debian/arch-sh4-fix-uimage-build.patch
  (+) OK   debian/af_802154-Disable-auto-loading-as-mitigation-against.patch
  (+) OK   debian/rds-Disable-auto-loading-as-mitigation-against-local.patch
  (+) OK   debian/decnet-Disable-auto-loading-as-mitigation-against-lo.patch
  (+) OK   bugfix/mips/mips-ide-flush-dcache.patch
  (+) OK   bugfix/all/qla4xxx-Fix-build-on-some-architectures-lacking-64-bit-I-O.patch
  (+) OK   bugfix/x86/Skip-looking-for-ioapic-overrides-when-ioapics-are-not-present.patch
  (+) OK   bugfix/arm/ixp4xx-add-missing-export.patch
  (+) OK   features/all/Kbuild-kconfig-Verbose-version-of-listnewconfig-v2.patch
  (+) OK   bugfix/arm/arm-ixp4xx-Rename-FREQ-macro-to-avoid-collisions-2.patch
  (+) OK   debian/alpha-Do-not-use-Werror-for-arch-alpha-v2.patch
  (+) OK   from-johill/001-debug-section-mismatch.patch
  (+) OK   linux-2.6-trace-unlikely/linux-2.6-trace-unlikely.patch
  (+) OK   mm-fix/cgroup-Avoid-a-memset-by-using-vzalloc.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0001-drm-nouveau-don-t-munge-in-drm_mm-internals.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0002-drm-mm-track-free-areas-implicitly.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0003-drm-mm-extract-node-insert-helper-functions.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0004-drm-mm-add-api-for-embedding-struct-drm_mm_node.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0005-drm-mm-add-helper-to-unwind-scan-state.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2/0006-drm-nouveau-don-t-munge-in-drm_mm-internals-follow-u.patch
  (+) OK   danvet-drm-for-sedat-dilek-v2-fix/0001-drm-nouveau-don-t-munge-in-drm_mm-internals-follow-u.patch
  (+) OK   danvet-embed-drm_gem_object-into-radeon_bo/1-3-drm-radeon-embed-struct-drm_gem_object-v2.patch
  (+) OK   danvet-embed-drm_gem_object-into-radeon_bo/2-3-drm-radeon-introduce-gem_to_radeon_bo-helper.patch
  (+) OK   danvet-embed-drm_gem_object-into-radeon_bo/3-3-drm-radeon-kill-radeon_bo--gobj-pointer.patch
  (+) OK   drm-radeon-kms-writeback/drm-radeon-kms-Enable-writeback-on-radeon-AGP-boards.patch
  (+) OK   backlight-type/1-5-Backlight-Add-backlight-type.patch
  (+) OK   backlight-type/2-5-i915-Add-native-backlight-control.patch
  (+) OK   backlight-type/v2-drm-radeon-kms-Expose-backlight-class-device-for-legacy-LVDS-encoder.patch
  (+) OK   backlight-type/4-5-nouveau-Change-the-backlight-parent-device-to-the-connector-not-the-PCI-dev.patch
  (+) OK   backlight-type/5-5-ACPI-Tie-ACPI-backlight-devices-to-PCI-devices-if-possible.patch
  (+) OK   drm-driverdate-coredate-removal/0001-drm-Remove-DRIVER_DATE-from-drm-drivers.patch
  (+) OK   drm-driverdate-coredate-removal/0002-drm-Remove-CORE_DATE-from-drm-core-and-drm-sysfs.patch
  (+) OK   drm-driverdate-coredate-removal/0003-drm-Fix-DRM_INFO-after-DRIVER_DATE-CORE_DATE-removal.patch
  (+) OK   drm-driverdate-coredate-removal/0004-drm-Remove-date_len-and-date-from-drm_version.patch
  (+) OK   mac80211-fix/mac80211-minstrel-honor-max-retry-counts-from-cfg80211.patch
  (+) OK   kvm-fix/kvm-Fix-section-mismatch-derived-from-kvm_guest_cpu_online.patch

- EOT -

#6 lore raw
Quoted 16 lines · Sedat Dilek
Quoted 15 lines · Marcelo Tosatti
Quoted 13 lines · Sedat Dilek
Quoted 1 line

From my build.log:

WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init() The function kvm_guest_cpu_online() references
the function __cpuinit kvm_guest_cpu_init().
This is often because kvm_guest_cpu_online lacks a __cpuinit
annotation or the annotation of kvm_guest_cpu_init is wrong.

This patch fixes the warning.

Tested with linux-next (next-20101231)

Quoted 8 lines
Quoted 3 lines

Applied, thanks.

PING!

Was this patch really applied? I have it still in my patch-series.

It was applied to kvm.git and will find its way upstream eventually.

Signature · 1 line
error compiling committee.c: too many arguments to function
#7 lore raw
Quoted 25 lines · Avi Kivity
Quoted 24 lines · Sedat Dilek
Quoted 20 lines · Marcelo Tosatti
Quoted 10 lines · Sedat Dilek

 > From my build.log:

 WARNING: arch/x86/built-in.o(.text+0x1bb74): Section mismatch in reference from the function kvm_guest_cpu_online() to the function .cpuinit.text:kvm_guest_cpu_init()
 The function kvm_guest_cpu_online() references
 the function __cpuinit kvm_guest_cpu_init().
 This is often because kvm_guest_cpu_online lacks a __cpuinit annotation or the annotation of kvm_guest_cpu_init is wrong.

Quoted 5 lines

 This patch fixes the warning.

 Tested with linux-next (next-20101231)

 Applied, thanks.

Quoted 7 lines
Quoted 4 lines

PING!

Was this patch really applied? I have it still in my patch-series.

It was applied to kvm.git and will find its way upstream eventually.

OK, I found it [1] in next GIT branch [2] and I guess this branch is not pulled into linux-next.
Thanks for the pointer.

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/avi/kvm.git;a=commit;h=ca905a6071b3daca83a91ae43106c40bd85e8a3d
[2] http://git.kernel.org/?p=linux/kernel/git/avi/kvm.git;a=shortlog;h=refs/heads/next