Skip to contentSkip to conversation

regulator: Assign return value of mc13xxx_reg_rmw to ret

PATCH Applied Axel Lin 4 participants 4 messages Jan 3, 2011 – Jan 4, 2011 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: Assign return value of mc13xxx_reg_rmw to ret

Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/mc13892-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/mc13892-regulator.c +1 -1
index 16a0532..1b8f739 100644
@@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
 		if (ret)
 			goto err_free;
 
-		mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
+		ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
 			MC13892_SWITCHERS5_SW3MODE_M |
 			MC13892_SWITCHERS5_SW4MODE_M,
 			MC13892_SWITCHERS5_SW3MODE_AUTO |
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#2 lore raw
In reply to Axel Lin
Acked-by Yong Shen <[email protected]>
Quoted 26 lines · Axel Lin

Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/regulator/mc13892-regulator.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/mc13892-regulator.c +1 -1
index 16a0532..1b8f739 100644
@@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
                if (ret)
                        goto err_free;
 
-               mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
+               ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,

                       MC13892_SWITCHERS5_SW3MODE_M | MC13892_SWITCHERS5_SW4MODE_M, MC13892_SWITCHERS5_SW3MODE_AUTO | --
1.7.0.4

Applied
#3 lore raw
In reply to Axel Lin
Quoted 6 lines · Axel Lin

Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/mc13892-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk