Skip to contentSkip to conversation

drm/i915: check eDP encoder correctly when setting modes

PATCH In review Jesse Barnes 2 participants 2 messages Jan 4, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: check eDP encoder correctly when setting modes

We were using a stale pointer in the check which caused us to use CPU attached DP params when we should have been using PCH attached params.

---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index fe56cb3..28d58ef 100644
@@ -3949,7 +3949,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 		int lane = 0, link_bw, bpp;
 		/* CPU eDP doesn't require FDI link, so just set DP M/N
 		   according to current link config */
-		if (has_edp_encoder && !intel_encoder_is_pch_edp(&encoder->base)) {
+		if (has_edp_encoder && !intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
 			target_clock = mode->clock;
 			intel_edp_link_config(has_edp_encoder,
 					      &lane, &link_bw);
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 2 lines · Jesse Barnes

We were using a stale pointer in the check which caused us to use CPU attached DP params when we should have been using PCH attached params.

This is a nice fix. I harvested a couple of tested-bys and pushed to -fixes.

Let's see if we can get it to Dave and Linus in time for .37. Thanks,
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre