txx9ndfmc: limit transfer bytes to 512 (ECC provides 6 bytes max)
Subsystems (2)
PATCH 1/1 txx9ndfmc: limit transfer bytes to 512 (ECC provides 6 bytes max)
See commit: c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e
Using __nand_correct_data() helper function, this driver can read 512 byte (with 6 byte ECC) at a time.
This is correct, but not more:
With NAND chips providing page sizes > 512 Bytes chip->ecc.bytes are calculated > 6 in txx9ndfmc_nand_scan. According the data sheet there are (only) 6 bytes ECC available.
After applying the patch a Hynix 512M*8 with 2k page size could be successfully formatted and used with an ubifs file system.
--- drivers/mtd/nand/txx9ndfmc.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/mtd/nand/txx9ndfmc.c +3 -2
@@ -277,8 +277,9 @@ static int txx9ndfmc_nand_scan(struct mtd_info *mtd) ret =nand_scan_ident (mtd,1 ,NULL );if (!ret) {if (mtd->writesize >=512 ) { - chip->ecc.size = mtd->writesize; - chip->ecc.bytes =3 * (mtd->writesize /256 ); +/* Hardware ECC 6 byte ECC per 512 Byte data */ + chip->ecc.size =512 ; + chip->ecc.bytes =6 ; } ret =nand_scan_tail (mtd); }
Signature · 1 line
1.7.2.3
Quoted 9 lines · Ralf Rösch
See commit:
c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e
Using__nand_correct_data()helper function, this driver can read 512 byte (with 6 byte ECC) at a time.This is correct, but not more:
With NAND chips providing page sizes > 512 Byteschip->ecc.bytesare calculated > 6 intxx9ndfmc_nand_scan. According the data sheet there are (only) 6 bytes ECC available.
Quoted 4 lines
After applying the patch a Hynix 512M*8 with 2k page size could be successfully formatted and used with an ubifs file system.
Signed-off-by Ralf Roesch <[email protected]>
Thank you for the fix. It is good news that this controller can work with large page NAND.
Artem Bityutskiy
AppliedQuoted 9 lines · Ralf Rösch
See commit:
c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e
Using__nand_correct_data()helper function, this driver can read 512 byte (with 6 byte ECC) at a time.This is correct, but not more:
With NAND chips providing page sizes > 512 Byteschip->ecc.bytesare calculated > 6 intxx9ndfmc_nand_scan. According the data sheet there are (only) 6 bytes ECC available.
Quoted 4 lines
After applying the patch a Hynix 512M*8 with 2k page size could be successfully formatted and used with an ubifs file system.
Signed-off-by Ralf Roesch <[email protected]>
Pushed to l2-mtd-2.6.git, thanks!
Signature · 2 lines
Best Regards, Artem Bityutskiy (Битюцкий Артём)