Skip to contentSkip to conversation

caif: don't set connection request param size before copying data

PATCH Applied Dan Rosenberg 2 participants 2 messages Jan 10, 2011 – Jan 11, 2011

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Dan Rosenberg

author
#0 lore raw

PATCH 1/1 caif: don't set connection request param size before copying data

The size field should not be set until after the data is successfully copied in.

Signed-off-by Dan Rosenberg <[email protected]>
---
 net/caif/caif_socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/caif/caif_socket.c +1 -1
index 1bf0cf5..8184c03 100644
@@ -740,12 +740,12 @@ static int setsockopt(struct socket *sock,
 		if (cf_sk->sk.sk_protocol != CAIFPROTO_UTIL)
 			return -ENOPROTOOPT;
 		lock_sock(&(cf_sk->sk));
-		cf_sk->conn_req.param.size = ol;
 		if (ol > sizeof(cf_sk->conn_req.param.data) ||
 			copy_from_user(&cf_sk->conn_req.param.data, ov, ol)) {
 			release_sock(&cf_sk->sk);
 			return -EINVAL;
 		}
+		cf_sk->conn_req.param.size = ol;
 		release_sock(&cf_sk->sk);
 		return 0;