Skip to contentSkip to conversation

alsa-lib: fix packaging error

PATCH In review Steffen Sledz 5 participants 7 messages Jan 11, 2011 – Jan 12, 2011 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/1 alsa-lib: fix packaging error

* symlink libasound.so -> libasound.so.2.0.0 in /usr/lib was missing in dev package

---
 recipes/alsa/alsa-lib_1.0.20.bb |    2 +-
 recipes/alsa/alsa-lib_1.0.23.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes/alsa/alsa-lib_1.0.20.bb +1 -1
index de522c7..fc508ec 100644
@@ -34,7 +34,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
 FILES_libasound = "${libdir}/libasound.so.*"
 FILES_alsa-server = "${bindir}/*"
 FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
 FILES_alsa-conf-base = "\
 ${datadir}/alsa/alsa.conf \
 ${datadir}/alsa/cards/aliases.conf \
recipes/alsa/alsa-lib_1.0.23.bb +1 -1
index 0f9b14c..0085047 100644
@@ -36,7 +36,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
 FILES_libasound = "${libdir}/libasound.so.*"
 FILES_alsa-server = "${bindir}/*"
 FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
 FILES_alsa-conf-base = "\
 ${datadir}/alsa/alsa.conf \
 ${datadir}/alsa/cards/aliases.conf \
Signature · 1 line
1.7.1
Acked-by on v2 1/1
#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Steffen Sledz

* symlink libasound.so -> libasound.so.2.0.0 in /usr/lib was missing in dev package

Quoted 23 lines
---
 recipes/alsa/alsa-lib_1.0.20.bb |    2 +-
 recipes/alsa/alsa-lib_1.0.23.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes/alsa/alsa-lib_1.0.20.bb +1 -1
index de522c7..fc508ec 100644
@@ -34,7 +34,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
 FILES_libasound = "${libdir}/libasound.so.*"
 FILES_alsa-server = "${bindir}/*"
 FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
 FILES_alsa-conf-base = "\
 ${datadir}/alsa/alsa.conf \
 ${datadir}/alsa/cards/aliases.conf \
recipes/alsa/alsa-lib_1.0.23.bb +0 -0
index 0f9b14c..0085047 100644

recipes/alsa/alsa-lib_1.0.23.bb FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*" · line 42

Quoted 8 lines
recipes/alsa/alsa-lib_1.0.23.bb +1 -1
@@ -36,7 +36,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
 FILES_libasound = "${libdir}/libasound.so.*"
 FILES_alsa-server = "${bindir}/*"
 FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
 FILES_alsa-conf-base = "\
 ${datadir}/alsa/alsa.conf \
 ${datadir}/alsa/cards/aliases.conf \

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNLF2RMkyGM64RGpERAv8DAJ9ipAyHrIazFiPN/+GdTRzaIWYMSgCeIUFx Q0W7A2UtNVuNrVFkUwdht9g=
=1noC
-----END PGP SIGNATURE-----

#4 lore raw

Am 11.01.2011 15:24, schrieb Paul Menzel:

Quoted 3 lines

Am Dienstag, den 11.01.2011, 14:26 -0500 schrieb Steffen Sledz:

Your clock/time is incorrect.

Arrgghh.

Should be fixed now.

Steffen

#5 lore raw
In reply to Steffen Sledz
Quoted 2 lines · Steffen Sledz

* symlink libasound.so -> libasound.so.2.0.0 in /usr/lib was missing in dev package

Why doesn't the generic FILES_${PN}-dev from bitbake.conf catch this file? Not that I think your patch is necessarily wrong but it isn't obvious to me why it is necessary.

p.

#6 lore raw

Am 11.01.2011 15:36, schrieb Phil Blundell:

Quoted 7 lines · Steffen Sledz
Quoted 2 lines

* symlink libasound.so -> libasound.so.2.0.0 in /usr/lib was missing in dev package

Why doesn't the generic FILES_${PN}-dev from bitbake.conf catch this file? Not that I think your patch is necessarily wrong but it isn't obvious to me why it is necessary.

The ALSA package structure seems to be a bit complex. There is an additional package named libasound but no libasound-dev. The development stuff is summed up in alsa-lib-dev.

BTW: I'm not an ALSA maintainer. Just tumbled over the missing symlink.

Steffen

Acked-by on v2 1/1
#7 lore raw
In reply to Steffen Sledz
Quoted 4 lines · Steffen Sledz

* symlink libasound.so -> libasound.so.2.0.0 in /usr/lib was missing in dev package

Quoted 31 lines
---
  recipes/alsa/alsa-lib_1.0.20.bb |    2 +-
  recipes/alsa/alsa-lib_1.0.23.bb |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
recipes/alsa/alsa-lib_1.0.20.bb +1 -1
index de522c7..fc508ec 100644
@@ -34,7 +34,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
  FILES_libasound = "${libdir}/libasound.so.*"
  FILES_alsa-server = "${bindir}/*"
  FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
  FILES_alsa-conf-base = "\
  ${datadir}/alsa/alsa.conf \
  ${datadir}/alsa/cards/aliases.conf \
recipes/alsa/alsa-lib_1.0.23.bb +1 -1
index 0f9b14c..0085047 100644
@@ -36,7 +36,7 @@ FILES_${PN}-dbg += "${libdir}/alsa-lib/*/.debu*"
  FILES_libasound = "${libdir}/libasound.so.*"
  FILES_alsa-server = "${bindir}/*"
  FILES_alsa-conf = "${datadir}/alsa/"
-FILES_alsa-dev += "${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
+FILES_alsa-dev += "${libdir}/libasound.so ${libdir}/pkgconfig/ /usr/include/ ${datadir}/aclocal/*"
  FILES_alsa-conf-base = "\
  ${datadir}/alsa/alsa.conf \
  ${datadir}/alsa/cards/aliases.conf \