Skip to contentSkip to conversation

btrfs: compile fix

PATCH In review James Bottomley 3 participants 3 messages Jan 15, 2011

Subsystems (2)
VFS Btrfs file system
lore
Share & tools
lore

James Bottomley

author
#0 lore raw

PATCH 1/1 btrfs: compile fix

Could we please fix this problem:

In file included from fs/btrfs/ctree.c:21:
fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type make[2]: *** [fs/btrfs/ctree.o] Error 1

It's annoying all my builds at the moment.

James

---

fs/btrfs/ctree.h +1 -0
index a142d20..f4f5fd5 100644
@@ -25,6 +25,7 @@
 #include <linux/fs.h>
 #include <linux/completion.h>
 #include <linux/backing-dev.h>
+#include <linux/kobject.h>
 #include <linux/wait.h>
 #include <linux/slab.h>
 #include <asm/kmap_types.h>
#1 lore raw
Quoted 18 lines · James Bottomley

Could we please fix this problem:

In file included from fs/btrfs/ctree.c:21:
fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type make[2]: *** [fs/btrfs/ctree.o] Error 1

It's annoying all my builds at the moment.

James

---

fs/btrfs/ctree.h +0 -0
index a142d20..f4f5fd5 100644

fs/btrfs/ctree.h line 31

Quoted 7 lines
fs/btrfs/ctree.h +1 -0
@@ -25,6 +25,7 @@
  #include<linux/fs.h>
  #include<linux/completion.h>
  #include<linux/backing-dev.h>
+#include<linux/kobject.h>
  #include<linux/wait.h>
  #include<linux/slab.h>
  #include<asm/kmap_types.h>

This has been broken for a day or three, and the fix is obvious.

Please forward to Linus. It's annoying everybody. :)

Jeff

#2 lore raw
In reply to James Bottomley

Excerpts from James Bottomley's message of 2011-01-15 10:33:55 -0500:

Quoted 6 lines

Could we please fix this problem:

In file included from fs/btrfs/ctree.c:21:
fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type make[2]: *** [fs/btrfs/ctree.o] Error 1

Yes, my pull request is going out this weekend.

-chris