gst-openmax: remove obsolete patch
PATCH 1/2 gst-openmax: remove obsolete patch
Date: Tue, 18 Jan 2011 16:31:30 +0100
Task configure fails with the following error with angstrom-2008.1 and MACHINE = "beagleboard".
| configure: using GStreamer tools in /usr/bin | configure: using GStreamer plug-ins in /usr/lib/gstreamer-0.10 | checking for GST_BASE... yes | checking for GST_CHECK... no | no | configure: No package 'gstreamer-check' found | configure: error: no gstreamer-check >= 0.10.0 (GStreamer Check unittest Library) found | ERROR: Function do_configure failed
NOTE: package gst-openmax-0.10.0.4-r0: task do_configure: Failed
ERROR: TaskFailed event exception, aborting
ERROR: Build of /oe/openembedded/recipes/openmax/gst-openmax_0.10.0.4.bb do_configure failed
ERROR: Task 11 (/oe/openembedded/recipes/openmax/gst-openmax_0.10.0.4.bb, do_configure) failed with 256
With current GStreamer gstreamer-0.10.31-r2 this patch is not necessary anymore and removing it fixes the build. When the recipe was committed with the patch in 1eef6ac1 [1] GStreamer 0.10.17 was used [2].
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1eef6ac18de15ea845b146b1624fcc1f1c4faea2
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=3422a436880509c7f82a3ae5d5693c87ece7a42d
--- recipes/openmax/gst-openmax/check.diff | 11 ----------- recipes/openmax/gst-openmax_0.10.0.4.bb | 1 - 2 files changed, 0 insertions(+), 12 deletions(-) delete mode 100644 recipes/openmax/gst-openmax/check.diff
recipes/openmax/gst-openmax/check.diff deleted +0 -11
@@ -1,11 +0,0 @@ ---- /tmp/gst-check.m4 2008-08-05 17:46:09.000000000 +0200 -+++ gst-openmax-0.10.0.4/common/m4/gst-check.m4 2008-08-05 17:46:29.000000000 +0200 -@@ -114,7 +114,7 @@ - - AC_DEFUN([AG_GST_CHECK_GST_CHECK], - [ -- AG_GST_CHECK_MODULES(GST_CHECK, gstreamer-check-[$1], [$2], -+ AG_GST_CHECK_MODULES(GST_CHECK, gstreamer-check, [$2], - [GStreamer Check unittest Library], [$3]) - ]) -
recipes/openmax/gst-openmax_0.10.0.4.bb +0 -1
@@ -3,7 +3,6 @@ LICENSE = "LGPLv2" DEPENDS = "gstreamer libomxil-bellagio" SRC_URI = "http://gstreamer.freedesktop.org/src/gst-openmax/pre/gst-openmax-${PV}.tar.bz2 \ - file://check.diff \ " inherit autotools
Signature · 1 line
1.7.2.3
PATCH 2/2 gst-openmax: do not use `-Werror` in `CFLAGS` to fix build
Date: Tue, 18 Jan 2011 16:34:51 +0100
Task compile fails with the following error using angstrom-2008.1 for MACHINE = "beagleboard".
arm-angstrom-linux-gnueabi-libtool: compile: arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I.. -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I./headers -I../gst-libs -I../gst-libs -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -Wall -Werror -g -DGST_DISABLE_DEPRECATED -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -I../util -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -frename-registers -fomit-frame-pointer -O2 -ggdb2 -MT libgstomx_la-gstomx_base_videoenc.lo -MD -MP -MF .deps/libgstomx_la-gstomx_base_videoenc.Tpo -c gstomx_base_videoenc.c -fPIC -DPIC -o .libs/libgstomx_la-gstomx_base_videoenc.o
cc1: warnings being treated as errors
gstomx_base_videoenc.c: In function 'sink_setcaps':
gstomx_base_videoenc.c:239: error: implicit declaration of function 'free'
gstomx_base_videoenc.c:239: error: incompatible implicit declaration of built-in function 'free'
gstomx_base_videoenc.c: In function 'omx_setup':
gstomx_base_videoenc.c:326: error: incompatible implicit declaration of built-in function 'free'
cc1: warnings being treated as errors
gstomx_base_filter.c: In function 'setup_ports':
gstomx_base_filter.c:65: error: implicit declaration of function 'free'
gstomx_base_filter.c:65: error: incompatible implicit declaration of built-in function 'free'
gstomx_base_filter.c: In function 'output_loop':
gstomx_base_filter.c:387: error: format '%d' expects type 'int', but argument 8 has type 'OMX_U32'
gstomx_base_filter.c: In function 'pad_chain':
gstomx_base_filter.c:476: error: format '%lu' expects type 'long unsigned int', but argument 8 has type 'guint'
make[2]: *** [libgstomx_la-gstomx_base_videoenc.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1: warnings being treated as errors
gstomx_base_videodec.c: In function 'settings_changed_cb':
gstomx_base_videodec.c:111: error: implicit declaration of function 'calloc'
gstomx_base_videodec.c:111: error: incompatible implicit declaration of built-in function 'calloc'
gstomx_base_videodec.c:135: error: implicit declaration of function 'free'
gstomx_base_videodec.c:135: error: incompatible implicit declaration of built-in function 'free'
gstomx_base_videodec.c: In function 'sink_setcaps':
gstomx_base_videodec.c:179: error: incompatible implicit declaration of built-in function 'calloc'
gstomx_base_videodec.c:208: error: incompatible implicit declaration of built-in function 'free'
gstomx_base_videodec.c: In function 'omx_setup':
gstomx_base_videodec.c:229: error: incompatible implicit declaration of built-in function 'calloc'
gstomx_base_videodec.c:291: error: incompatible implicit declaration of built-in function 'free'
make[2]: *** [libgstomx_la-gstomx_base_filter.lo] Error 1
make[2]: *** [libgstomx_la-gstomx_base_videodec.lo] Error 1
arm-angstrom-linux-gnueabi-libtool: compile: arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I.. -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I./headers -I../gst-libs -I../gst-libs -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -Wall -Werror -g -DGST_DISABLE_DEPRECATED -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -I../util -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -frename-registers -fomit-frame-pointer -O2 -ggdb2 -MT libgstomx_la-gstomx.lo -MD -MP -MF .deps/libgstomx_la-gstomx.Tpo -c gstomx.c -o libgstomx_la-gstomx.o >/dev/null 2>&1 mv -f .deps/libgstomx_la-gstomx.Tpo .deps/libgstomx_la-gstomx.Plo
make[2]: Leaving directory `/oe/build/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/gst-openmax-0.10.0.4-r0/gst-openmax-0.10.0.4/omx'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/oe/build/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/gst-openmax-0.10.0.4-r0/gst-openmax-0.10.0.4'
make: *** [all] Error 2
FATAL: oe_runmake failed
ERROR: Function do_compile failed
configure.ac contains
dnl These flags can be overridden at make time: dnl make ERROR_CFLAGS= AC_DEFUN([AG_GST_SET_ERROR_CFLAGS], [ AC_REQUIRE([AC_PROG_CC]) AC_REQUIRE([AS_COMPILER_FLAG]) […] dnl if asked for, add -Werror if supported if test "x$1" != "xno" then AS_COMPILER_FLAG(-Werror, ERROR_CFLAGS="$ERROR_CFLAGS -Werror")
and so set ERROR_FLAGS only to -Wall. This fixes the build.
--- recipes/openmax/gst-openmax_0.10.0.4.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
recipes/openmax/gst-openmax_0.10.0.4.bb +2 -0
@@ -7,6 +7,8 @@ SRC_URI = "http://gstreamer.freedesktop.org/src/gst-openmax/pre/gst-openmax-${PV inherit autotools +EXTRA_OEMAKE += "'ERROR_CFLAGS=-Wall'" + FILES_${PN} += "${libdir}/gstreamer-0.10/*.so" FILES_${PN}-dbg += "${libdir}/gstreamer-0.10/.debug" FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.*a"
Signature · 1 line
1.7.2.3
Re: [PATCH 2/2] gst-openmax: do not use `-Werror` in `CFLAGS` to fix build
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 5 lines · Paul Menzel
Date: Tue, 18 Jan 2011 16:34:51 +0100
Task
compilefails with the following error usingangstrom-2008.1forMACHINE = "beagleboard".arm-angstrom-linux-gnueabi-libtool: compile: arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I.. -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I./headers -I../gst-libs -I../gst-libs -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -Wall -Werror -g -DGST_DISABLE_DEPRECATED -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/includ
e -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -I../util -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -frename-registers -fomit-frame-pointer -O2 -ggdb2 -MT libgstomx_la-gstomx_base_videoenc.lo -MD -MP -MF .deps/libgstomx_la-gstomx_base_videoenc.Tpo -c gstomx_base_videoenc.c -fPIC -DPIC -o .libs/libgstomx_la-gstomx_base_videoenc.o
Quoted 23 lines
cc1: warnings being treated as errors
gstomx_base_videoenc.c: In function 'sink_setcaps':
gstomx_base_videoenc.c:239: error: implicit declaration of function 'free' gstomx_base_videoenc.c:239: error: incompatible implicit declaration of built-in function 'free'gstomx_base_videoenc.c: In function 'omx_setup':
gstomx_base_videoenc.c:326: error: incompatible implicit declaration of built-in function 'free'
cc1: warnings being treated as errors
gstomx_base_filter.c: In function 'setup_ports':
gstomx_base_filter.c:65: error: implicit declaration of function 'free' gstomx_base_filter.c:65: error: incompatible implicit declaration of built-in function 'free'gstomx_base_filter.c: In function 'output_loop':
gstomx_base_filter.c:387: error: format '%d' expects type 'int', but argument 8 has type 'OMX_U32'gstomx_base_filter.c: In function 'pad_chain':
gstomx_base_filter.c:476: error: format '%lu' expects type 'long unsigned int', but argument 8 has type 'guint' make[2]: *** [libgstomx_la-gstomx_base_videoenc.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1: warnings being treated as errors
gstomx_base_videodec.c: In function 'settings_changed_cb':
gstomx_base_videodec.c:111: error: implicit declaration of function 'calloc' gstomx_base_videodec.c:111: error: incompatible implicit declaration of built-in function 'calloc' gstomx_base_videodec.c:135: error: implicit declaration of function 'free' gstomx_base_videodec.c:135: error: incompatible implicit declaration of built-in function 'free'gstomx_base_videodec.c: In function 'sink_setcaps':
Quoted 8 lines
gstomx_base_videodec.c:179: error: incompatible implicit declaration of built-in function 'calloc'
gstomx_base_videodec.c:208: error: incompatible implicit declaration of built-in function 'free'
gstomx_base_videodec.c: In function 'omx_setup':
gstomx_base_videodec.c:229: error: incompatible implicit declaration of built-in function 'calloc'
gstomx_base_videodec.c:291: error: incompatible implicit declaration of built-in function 'free'
make[2]: *** [libgstomx_la-gstomx_base_filter.lo] Error 1
make[2]: *** [libgstomx_la-gstomx_base_videodec.lo] Error 1
arm-angstrom-linux-gnueabi-libtool: compile: arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb -DHAVE_CONFIG_H -I. -I.. -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -I./headers -I../gst-libs -I../gst-libs -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -Wall -Werror -g -DGST_DISABLE_DEPRECATED -pthread -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gstreamer-0.10 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/includ
e -I/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/libxml2 -I../util -isystem/oe/build/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include -fexpensive-optimizations -frename-registers -fomit-frame-pointer -O2 -ggdb2 -MT libgstomx_la-gstomx.lo -MD -MP -MF .deps/libgstomx_la-gstomx.Tpo -c gstomx.c -o libgstomx_la-gstomx.o >/dev/null 2>&1
Quoted 24 lines
mv -f .deps/libgstomx_la-gstomx.Tpo .deps/libgstomx_la-gstomx.Plo make[2]: Leaving directory `/oe/build/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/gst-openmax-0.10.0.4-r0/gst-openmax-0.10.0.4/omx' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/oe/build/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/gst-openmax-0.10.0.4-r0/gst-openmax-0.10.0.4' make: *** [all] Error 2 FATAL: oe_runmake failed ERROR: Function do_compile failed
configure.accontainsdnl These flags can be overridden at make time: dnl make ERROR_CFLAGS= AC_DEFUN([AG_GST_SET_ERROR_CFLAGS], [ AC_REQUIRE([AC_PROG_CC]) AC_REQUIRE([AS_COMPILER_FLAG]) […] dnl if asked for, add -Werror if supported if test "x$1" != "xno" then AS_COMPILER_FLAG(-Werror, ERROR_CFLAGS="$ERROR_CFLAGS -Werror")
Quoted 3 lines
and so set
ERROR_FLAGSonly to-Wall. This fixes the build.Signed-off-by Paul Menzel <[email protected]>
Quoted 20 lines
--- recipes/openmax/gst-openmax_0.10.0.4.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)recipes/openmax/gst-openmax_0.10.0.4.bb +2
-0@@ -7,6 +7,8 @@ SRC_URI = "http://gstreamer.freedesktop.org/src/gst-openmax/pre/gst-openmax-${PV inherit autotools +EXTRA_OEMAKE += "'ERROR_CFLAGS=-Wall'" + FILES_${PN} += "${libdir}/gstreamer-0.10/*.so" FILES_${PN}-dbg += "${libdir}/gstreamer-0.10/.debug" FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.*a"
Quoted 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFNNpGxMkyGM64RGpERAkexAJ0dnEExJEP//i1O7p7S+Bgtn8zAwgCglcv3 CDgB+u7RBQy53EsKWsMs+ZM=
=4uKq
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 17 lines · Paul Menzel
Date: Tue, 18 Jan 2011 16:31:30 +0100
Task
configurefails with the following error withangstrom-2008.1andMACHINE = "beagleboard".| configure: using GStreamer tools in /usr/bin | configure: using GStreamer plug-ins in /usr/lib/gstreamer-0.10 | checking for GST_BASE... yes | checking for GST_CHECK... no | no | configure: No package 'gstreamer-check' found | configure: error: no gstreamer-check >= 0.10.0 (GStreamer Check unittest Library) found | ERROR: Function do_configure failedNOTE: package gst-openmax-0.10.0.4-r0: task
do_configure: Failed
ERROR: TaskFailed event exception, aborting
ERROR: Build of /oe/openembedded/recipes/openmax/gst-openmax_0.10.0.4.bbdo_configurefailed
ERROR: Task 11 (/oe/openembedded/recipes/openmax/gst-openmax_0.10.0.4.bb,do_configure) failed with 256
Quoted 6 lines
With current GStreamer
gstreamer-0.10.31-r2this patch is not necessary anymore and removing it fixes the build. When the recipe was committed with the patch in1eef6ac1[1] GStreamer 0.10.17 was used [2].[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1eef6ac18de15ea845b146b1624fcc1f1c4faea2
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=3422a436880509c7f82a3ae5d5693c87ece7a42dSigned-off-by Paul Menzel <[email protected]>
Quoted 38 lines
--- recipes/openmax/gst-openmax/check.diff | 11 ----------- recipes/openmax/gst-openmax_0.10.0.4.bb | 1 - 2 files changed, 0 insertions(+), 12 deletions(-) delete mode 100644 recipes/openmax/gst-openmax/check.diffrecipes/openmax/gst-openmax/check.diff deleted +0
-11@@ -1,11 +0,0 @@ ---- /tmp/gst-check.m4 2008-08-05 17:46:09.000000000 +0200 -+++ gst-openmax-0.10.0.4/common/m4/gst-check.m4 2008-08-05 17:46:29.000000000 +0200 -@@ -114,7 +114,7 @@ - - AC_DEFUN([AG_GST_CHECK_GST_CHECK], - [ -- AG_GST_CHECK_MODULES(GST_CHECK, gstreamer-check-[$1], [$2], -+ AG_GST_CHECK_MODULES(GST_CHECK, gstreamer-check, [$2], - [GStreamer Check unittest Library], [$3]) - ]) -recipes/openmax/gst-openmax_0.10.0.4.bb +0
-1@@ -3,7 +3,6 @@ LICENSE = "LGPLv2" DEPENDS = "gstreamer libomxil-bellagio" SRC_URI = "http://gstreamer.freedesktop.org/src/gst-openmax/pre/gst-openmax-${PV}.tar.bz2 \ - file://check.diff \ " inherit autotools
Quoted 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFNNpGkMkyGM64RGpERAgphAKCrYfUHcqTf6Xa7KPOLEgoV7rfzjwCfbEjj A/fPxQcTyRgKMYa/O4kHVrw=
=vhT3
-----END PGP SIGNATURE-----