Skip to contentSkip to conversation

Q. FMODE_NONOTIFY warning

DISCUSSION J. R. Okajima 2 participants 2 messages Aug 18, 2010 – Jan 19, 2011 VFS

lore
Share & tools
lore

J. R. Okajima

author
#0 lore raw

By the commit

	ecf081d 2010-07-28 vfs: introduce FMODE_NONOTIFY

a new warning is produced.

In include/linux/fs.h

#define FMODE_NONOTIFY		((__force fmode_t)0x1000000)
	:::

#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \
(flag & FMODE_NONOTIFY)))

In fs/anon_inodes.c
anon_inode_getfile(..., int flags)

{
	file = alloc_file(&path, OPEN_FMODE(flags), fops);
}

Here the '&' operator handles the passed integer "flags" and "__force fmode_t", and we get "warning: restricted fmode_t degrades to integer".

Can we stop this warning?

J. R. Okajima

#1 lore raw
Quoted 12 lines · J. R. Okajima

By the commit

	ecf081d 2010-07-28 vfs: introduce FMODE_NONOTIFY

a new warning is produced.

In include/linux/fs.h

#define FMODE_NONOTIFY		((__force fmode_t)0x1000000)
	:::

#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \
(flag & FMODE_NONOTIFY)))

In fs/anon_inodes.c
anon_inode_getfile(..., int flags)

Quoted 8 lines
{
	file = alloc_file(&path, OPEN_FMODE(flags), fops);
}

Here the '&' operator handles the passed integer "flags" and "__force fmode_t", and we get "warning: restricted fmode_t degrades to integer".

Can we stop this warning?

I apologize that this e-mail (along with many others) got put in my spam folder and I'm responding months and months late. I don't believe this is a problem upstream any longer. Thanks for the report and I'm sorry I didn't respond....

-Eric