leds: leds-pwm: return proper error if pwm_request failed
PATCH 1/1 leds: leds-pwm: return proper error if pwm_request failed
Return PTR_ERR(led_dat->pwm) instead of 0 if pwm_request failed
Signed-off-by Axel Lin <[email protected]>
--- drivers/leds/leds-pwm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/leds/leds-pwm.c +1 -0
@@ -69,6 +69,7 @@ static int led_pwm_probe(struct platform_device *pdev) led_dat->pwm =pwm_request (cur_led->pwm_id, cur_led->name);if (IS_ERR (led_dat->pwm)) { + ret =PTR_ERR (led_dat->pwm);dev_err (&pdev->dev,"unable to request PWM %d\n" , cur_led->pwm_id); goto err;
Signature · 1 line
1.7.2
Quoted 3 lines · Axel Lin
Return
PTR_ERR(led_dat->pwm)instead of 0 ifpwm_requestfailedSigned-off-by Axel Lin <[email protected]>
Looks good.
Reviewed-by Dmitry Torokhov <[email protected]>
Quoted 16 lines
--- drivers/leds/leds-pwm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/leds/leds-pwm.c +1
-0@@ -69,6 +69,7 @@ static int led_pwm_probe(struct platform_device *pdev) led_dat->pwm =pwm_request (cur_led->pwm_id, cur_led->name);if (IS_ERR (led_dat->pwm)) { + ret =PTR_ERR (led_dat->pwm);dev_err (&pdev->dev,"unable to request PWM %d\n" , cur_led->pwm_id); goto err;
Signature · 1 line
Dmitry