Skip to contentSkip to conversation

firmware_classs: change val uevent's type to bool

PATCH In review Bob Liu 2 participants 2 messages Jan 26, 2011

Subsystems (2)
Driver core Firmware loader (request_firmware)
lore
Share & tools
lore

Bob Liu

author
#0 lore raw

PATCH v2 1/1 firmware_classs: change val uevent's type to bool

Some place in firmware_class.c using "int uevent" define, but others use "bool uevent".
This patch replace all int uevent define to bool.

Changes since V1:
johannes: remove no-op

Signed-off-by Bob Liu <[email protected]>
---
 drivers/base/firmware_class.c |    7 +++----
 include/linux/firmware.h      |    4 ++--
 2 files changed, 5 insertions(+), 6 deletions(-)
drivers/base/firmware_class.c +3 -4
index 40af43e..8c798ef 100644
@@ -593,8 +593,7 @@ int
 request_firmware(const struct firmware **firmware_p, const char *name,
                  struct device *device)
 {
-        int uevent = 1;
-        return _request_firmware(firmware_p, name, device, uevent, false);
+        return _request_firmware(firmware_p, name, device, true, false);
 }
 
 /**

@@ -618,7 +617,7 @@ struct firmware_work {
 	struct device *device;
 	void *context;
 	void (*cont)(const struct firmware *fw, void *context);
-	int uevent;
+	bool uevent;
 };
 
 static int request_firmware_work_func(void *arg)

@@ -661,7 +660,7 @@ static int request_firmware_work_func(void *arg)
  **/
 int
 request_firmware_nowait(
-	struct module *module, int uevent,
+	struct module *module, bool uevent,
 	const char *name, struct device *device, gfp_t gfp, void *context,
 	void (*cont)(const struct firmware *fw, void *context))
 {
include/linux/firmware.h +2 -2
index 53d1e6c..21b3e75 100644
@@ -39,7 +39,7 @@ struct builtin_fw {
 int request_firmware(const struct firmware **fw, const char *name,
 		     struct device *device);
 int request_firmware_nowait(
-	struct module *module, int uevent,
+	struct module *module, bool uevent,
 	const char *name, struct device *device, gfp_t gfp, void *context,
 	void (*cont)(const struct firmware *fw, void *context));
 

@@ -52,7 +52,7 @@ static inline int request_firmware(const struct firmware **fw,
 	return -EINVAL;
 }
 static inline int request_firmware_nowait(
-	struct module *module, int uevent,
+	struct module *module, bool uevent,
 	const char *name, struct device *device, gfp_t gfp, void *context,
 	void (*cont)(const struct firmware *fw, void *context))
 {
Signature · 1 line
1.6.3.3
Acked-by on v2 1/1
#1 lore raw
Quoted 6 lines · Bob Liu

Some place in firmware_class.c using "int uevent" define, but others use "bool uevent".
This patch replace all int uevent define to bool.

Changes since V1:
johannes: remove no-op

Actually what you removed is the only non-noop from your previous patch. And changelog like this should go below "---" separator so import scripts ignore it.

Anyways,

Acked-by Dmitry Torokhov <[email protected]>
Signature · 1 line
Dmitry