Skip to contentSkip to conversation

Make external-python-tarball useful again

PATCH Applied Joshua Lock 2 participants 5 messages Jan 27, 2011

lore
Share & tools
lore
#0 lore raw

cover Make external-python-tarball useful again

From: Joshua Lock <[email protected]>

The attached patch adds the multiprocessing module to the external Python tarball. This is quite useful as we use multiprocessing at recipe parse time now.

This raises two questions:
1) Should we do some testing around the use of multiprocessing?
2) Who can update a new external-python-tarball to the public download?

Finally, we should probably document the existence of this tarball somewhere other than this mailing list. Ideas?

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: josh/master
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=josh/master

Thanks,
Joshua Lock <[email protected]>
---

Joshua Lock (1):
external-python-tarball: include multiprocessing module

 meta/recipes-core/meta/external-python-tarball.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.3.5
#1 lore raw

PATCH 1/1 external-python-tarball: include multiprocessing module

From: Joshua Lock <[email protected]>

---
 meta/recipes-core/meta/external-python-tarball.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-core/meta/external-python-tarball.bb +1 -0
index eef93fd..746cb9e 100644
@@ -26,6 +26,7 @@ TOOLCHAIN_HOST_TASK ?= "\
     python-nativesdk-fcntl \
     python-nativesdk-shell \
     python-nativesdk-misc \
+    python-nativesdk-multiprocessing \
     python-nativesdk-subprocess \
     python-nativesdk-xmlrpc \
     python-nativesdk-netclient \
Signature · 1 line
1.7.3.5
#2 lore raw
In reply to Joshua Lock
Quoted 5 lines · Joshua Lock

From: Joshua Lock <[email protected]>

The attached patch adds the multiprocessing module to the external Python tarball. This is quite useful as we use multiprocessing at recipe parse time now.

Merged into master, thanks!

Quoted 2 lines

This raises two questions:
1) Should we do some testing around the use of multiprocessing?

In what way?

Quoted 1 line

2) Who can update a new external-python-tarball to the public download?

Beth+me should both have access.

Quoted 9 lines

Finally, we should probably document the existence of this tarball somewhere other than this mailing list. Ideas?

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: josh/master
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=josh/master

Thanks,
Joshua Lock <[email protected]>

Cheers,

Richard

#3 lore raw
Quoted 7 lines · Richard Purdie
Quoted 5 lines · Joshua Lock

From: Joshua Lock <[email protected]>

The attached patch adds the multiprocessing module to the external Python tarball. This is quite useful as we use multiprocessing at recipe parse time now.

Quoted 6 lines

Merged into master, thanks!

Quoted 2 lines

This raises two questions:
1) Should we do some testing around the use of multiprocessing?

In what way?

Sorry, what a vague comment. I meant to suggest an exception around the import and alternative code paths if the module can't be imported. Or is it safe to assume it exists if you have Python 2.6? - in which case we just need to improve out Python 2.6 tests so that people can't run this code on older versions.

Quoted 4 lines
Quoted 2 lines

2) Who can update a new external-python-tarball to the public download?

Beth+me should both have access.

Cool, I'm debugging an issue with package resolution at tarball generation time, but once that works I'll request a build and upload.

Thanks,
Joshua

Signature · 2 lines
Joshua Lock
        Intel Open Source Technology Centre
#4 lore raw
Quoted 13 lines · Joshua Lock
Quoted 12 lines · Richard Purdie
Quoted 5 lines · Joshua Lock

From: Joshua Lock <[email protected]>

The attached patch adds the multiprocessing module to the external Python tarball. This is quite useful as we use multiprocessing at recipe parse time now.

Merged into master, thanks!

Quoted 2 lines

This raises two questions:
1) Should we do some testing around the use of multiprocessing?

Quoted 7 lines
Quoted 1 line

In what way?

Sorry, what a vague comment. I meant to suggest an exception around the import and alternative code paths if the module can't be imported. Or is it safe to assume it exists if you have Python 2.6? - in which case we just need to improve out Python 2.6 tests so that people can't run this code on older versions.

Its safe to assume it exists in standard python 2.6.

We therefore just need to improve the python 2.6 checks.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

2) Who can update a new external-python-tarball to the public download?

Beth+me should both have access.

Cool, I'm debugging an issue with package resolution at tarball generation time, but once that works I'll request a build and upload.

Sounds good thanks.

Richard