Skip to contentSkip to conversation

USB: tools: Add a Makefile

PATCH Superseded Davidlohr Bueso 3 participants 7 messages Jan 27, 2011 – Feb 4, 2011

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 USB: tools: Add a Makefile

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

From: Davidlohr Bueso <[email protected]>

Build USB tools easier.

---
 tools/usb/Makefile |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100644 tools/usb/Makefile
tools/usb/Makefile new file +13 -0
new file mode 100644
index 0000000..3995509
@@ -0,0 +1,13 @@
+# Makefile for building 'usbtest'
+
+CC = $(CROSS_COMPILE)gcc
+PTHREAD_LIBS = -lpthread
+WARNINGS = -Wall -Wextra
+CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS)
+
+all: testusb ffs-test
+%: %.c
+	$(CC) $(CFLAGS) -o $@ $^
+
+clean:
+	$(RM) testusb ffs-test
Signature · 1 line
1.7.1
#1 lore raw

Hello.

Quoted 1 line · Davidlohr Bueso

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

This remark should follow the --- tear line, to be automatically stripped
when applying the patch.

Quoted 5 lines

From: Davidlohr Bueso<[email protected]>

Build USB tools easier.

WBR, Sergei

#2 lore raw
Quoted 9 lines · Sergei Shtylyov

Hello.

Quoted 1 line · Davidlohr Bueso

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

This remark should follow the --- tear line, to be automatically stripped
when applying the patch.

It wasn't meant for the log, that's why it's above the tear line.

Thanks.

Quoted 8 lines
Quoted 5 lines

From: Davidlohr Bueso<[email protected]>

Build USB tools easier.

WBR, Sergei

#3 lore raw

Hello.

Quoted 8 lines · Davidlohr Bueso
Quoted 6 lines · Davidlohr Bueso
Quoted 2 lines

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

This remark should follow the --- tear line, to be automatically stripped
when applying the patch.

It wasn't meant for the log, that's why it's above the tear line.

Everything above the tearline gets into the changelog. If it wasn't meant
to, it should be below the tearline, or have to be manually edited out of it.

Quoted 1 line

Thanks.

WBR, Sergei

#4 lore raw
Quoted 10 lines · On 28-01-2011 15:38, I wrote:
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

This remark should follow the --- tear line, to be automatically stripped when applying the patch.

It wasn't meant for the log, that's why it's above the tear line.

Everything above the tearline gets into the changelog. If it wasn't meant to, it should be below the tearline, or have to be manually edited out of it.

s/it/the patch/

Quoted 1 line
Quoted 1 line

Thanks.

It helps to actually read Documentation/SubmittingPatches sometimes. ;-)

WBR, Sergei

#5 lore raw
In reply to Sergei Shtylyov
Quoted 8 lines · Sergei Shtylyov

Hello.

Quoted 3 lines · Davidlohr Bueso
Quoted 3 lines · Davidlohr Bueso
Quoted 2 lines

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

This remark should follow the --- tear line, to be automatically stripped
when applying the patch.

It wasn't meant for the log, that's why it's above the tear line.

Everything above the tearline gets into the changelog. If it wasn't meant
to, it should be below the tearline, or have to be manually edited out of it.

I should have been clearer. What I meant was that the text I didn't want in the changelog was above the "From:" (and of course above the ---). I didn't know it is supposed to be below the tearline. Thanks for pointing this out.
If anyone is going to take the patch, do you prefer for me to resend it?

Thanks.

#6 lore raw
Quoted 14 lines · Davidlohr Bueso
Quoted 13 lines · Sergei Shtylyov

Hello.

Quoted 8 lines · Davidlohr Bueso
Quoted 6 lines · Davidlohr Bueso
Quoted 2 lines

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

This remark should follow the --- tear line, to be automatically stripped
when applying the patch.

It wasn't meant for the log, that's why it's above the tear line.

Quoted 8 lines
Quoted 3 lines

Everything above the tearline gets into the changelog. If it wasn't meant
to, it should be below the tearline, or have to be manually edited out of it.

I should have been clearer. What I meant was that the text I didn't want in the changelog was above the "From:" (and of course above the ---). I didn't know it is supposed to be below the tearline. Thanks for pointing this out.
If anyone is going to take the patch, do you prefer for me to resend it?

Yes, please redo it, and the first patch in this series, and resend it so that I can apply them.

thanks,

greg k-h