Skip to contentSkip to conversation

soc: neo1973_wm8753 audio support does not require scoop

PATCH In review H Hartley Sweeten 3 participants 4 messages Jan 28, 2011 – Jan 31, 2011

Subsystems (3)
Sound ASoC Samsung audio (ASoC) drivers
lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 soc: neo1973_wm8753 audio support does not require scoop

This driver does not use any of the functionality provided by the scoop hardware. Remove the unneeded header.

Signed-off-by H Hartley Sweeten <[email protected]>

---

sound/soc/samsung/neo1973_wm8753.c +0 -1
index c7a2451..c5b3113 100644
@@ -24,7 +24,6 @@
 #include <sound/tlv.h>
 
 #include <asm/mach-types.h>
-#include <asm/hardware/scoop.h>
 #include <mach/regs-clock.h>
 #include <mach/regs-gpio.h>
 #include <mach/hardware.h>
#1 lore raw
Quoted 4 lines · H Hartley Sweeten

This driver does not use any of the functionality provided by the scoop hardware. Remove the unneeded header.

Signed-off-by H Hartley Sweeten <[email protected]>

CCing in Liam. As I think I've mentioned before please do remember to CC maintainers.

Quoted 20 lines

---

sound/soc/samsung/neo1973_wm8753.c +0 -1
index c7a2451..c5b3113 100644
@@ -24,7 +24,6 @@
 #include <sound/tlv.h>
 
 #include <asm/mach-types.h>
-#include <asm/hardware/scoop.h>
 #include <mach/regs-clock.h>
 #include <mach/regs-gpio.h>
 #include <mach/hardware.h>

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Signature · 1 line
"You grabbed my hand and we fell into it, like a daydream - or a fever."
Acked-by
#2 lore raw
Quoted 19 lines · Mark Brown
Quoted 4 lines · H Hartley Sweeten

This driver does not use any of the functionality provided by the scoop hardware. Remove the unneeded header.

Signed-off-by H Hartley Sweeten <[email protected]>

CCing in Liam. As I think I've mentioned before please do remember to CC maintainers.

Quoted 10 lines

---

sound/soc/samsung/neo1973_wm8753.c +0 -0
index c7a2451..c5b3113 100644
@@ -24,7 +24,6 @@
 #include <sound/tlv.h>
Quoted 5 lines

sound/soc/samsung/neo1973_wm8753.c line 29

Quoted 5 lines
sound/soc/samsung/neo1973_wm8753.c +0 -1
 #include <asm/mach-types.h>
-#include <asm/hardware/scoop.h>
 #include <mach/regs-clock.h>
 #include <mach/regs-gpio.h>
 #include <mach/hardware.h>
Acked-by Liam Girdwood <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
#3 lore raw
In reply to H Hartley Sweeten
Quoted 2 lines · H Hartley Sweeten

This driver does not use any of the functionality provided by the scoop hardware. Remove the unneeded header.

Applied but please in future remember to:

- Send copies of your patches to the relevant maintainers as documented in Documentation/SubmittingPatches so maintainers actually see them.
- Make your commit messages match the style for the subsystem you're submitting to.

This stuff is especially important for minor cleanups like this, please do try to bear it in mind.