OMAP: omap_device: API to modify SYSCONFIG register

Create a new API that forms a wrapper to _set_module_autoidle() to modify the AUTOIDLE bit.

This API is intended to be used by drivers that requires direct manipulation of the AUTOIDLE bits in SYSCONFIG register. McBSP driver requires autoidle bit to be enabled/disabled while using sidetone feature.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

Cc Paul Walmsley <[email protected]>

Cc Benoit Cousson <[email protected]>

Provide APIs to be used by the driver in order to modify AUTOIDLE and SIDLE bits. These APIs in turn call hwmod APIs to modify the SYSCONFIG register.

Signed-off-by Kishon Vijay Abraham I<[email protected]>

Signed-off-by Benoit Cousson<[email protected]>

Cc Paul Walmsley<[email protected]>

---
  arch/arm/plat-omap/include/plat/omap_device.h |    6 +
  arch/arm/plat-omap/omap_device.c              |  176 +++++++++++++++++++++++++
  2 files changed, 182 insertions(+), 0 deletions(-)

arch/arm/plat-omap/include/plat/omap_device.h +6 -0

index e4c349f..47ad0ab 100644
@@ -110,6 +110,12 @@ struct powerdomain *omap_device_get_pwrdm(struct omap_device *od);
  u32 omap_device_get_context_loss_count(struct platform_device *pdev);
 
  /* Other */
+int omap_device_noidle(struct omap_device *od);
+int omap_device_smartidle(struct omap_device *od);
+int omap_device_forceidle(struct omap_device *od);
+int omap_device_default_idle(struct omap_device *od);
+int omap_device_enable_autoidle(struct omap_device *od);
+int omap_device_disable_autoidle(struct omap_device *od);
 
  int omap_device_idle_hwmods(struct omap_device *od);
  int omap_device_enable_hwmods(struct omap_device *od);

arch/arm/plat-omap/omap_device.c +105 -0

index 57adb27..da8609a 100644
@@ -726,6 +726,182 @@ void __iomem *omap_device_get_rt_va(struct omap_device *od)
  	return omap_hwmod_get_mpu_rt_va(od->hwmods[0]);
  }
 
+/**
+ * omap_device_noidle - set the device's slave idlemode to no idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */
+int omap_device_noidle(struct omap_device *od)
+{
+	int retval = 0, i;
+
+	if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+		WARN(1, "omap_device: %s.%d: %s() called from invalid state "
+			"%d\n", od->pdev.name, od->pdev.id, __func__,
+			od->_state);
+		return -EINVAL;
+	}
+
+	for (i = 0; i<  od->hwmods_cnt; i++)
+		retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+					HWMOD_IDLEMODE_NO);
+
+	return retval;
+}
+
+
+/**
+ * omap_device_smartidle - set the device's slave idlemode to smart idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to smart idle.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */
+int omap_device_smartidle(struct omap_device *od)
+{
+	int retval = 0, i;
+
+	if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+		WARN(1, "omap_device: %s.%d: %s() called from invalid state "
+			"%d\n", od->pdev.name, od->pdev.id, __func__,
+			od->_state);
+		return -EINVAL;
+	}
+
+	for (i = 0; i<  od->hwmods_cnt; i++)
+		retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+					HWMOD_IDLEMODE_SMART);
+
+	return retval;
+}
+
+
+/**
+ * omap_device_forceidle - set the device's slave idlemode to force idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to force idle.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */
+int omap_device_forceidle(struct omap_device *od)
+{
+	int retval = 0, i;
+
+	if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+		WARN(1, "omap_device: %s.%d: %s() called from invalid state "
+			"%d\n", od->pdev.name, od->pdev.id, __func__,
+			od->_state);
+		return -EINVAL;
+	}
+
+	for (i = 0; i<  od->hwmods_cnt; i++)
+		retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+					HWMOD_IDLEMODE_FORCE);
+
+	return retval;
+}
+
+/**
+ * omap_device_default_idle - set the device's slave idlemode to no idle or
+ * smart idle based on the hwmod flag
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle or smart idle
+ * depending on status of the flag HWMOD_SWSUP_SIDLE.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */
+int omap_device_default_idle(struct omap_device *od)
+{
+	int retval = 0, i;
+	u8 idlemode;
+
+	if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+		WARN(1, "omap_device: %s.%d: %s() called from invalid state "

arch/arm/plat-omap/omap_device.c +19 -0

+	}
+
+	return retval;
+}
+
+/*
+ * omap_device_enable_autoidle - enable the device's OCP slave autoidle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave autoidle in hardware.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the AUTOIDLE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_autoidle().
+ */
+int omap_device_enable_autoidle(struct omap_device *od)
+{
+	int retval = 0, i;
+

Hi Kishon,

Sorry for this late reply.

I'm fine with this omap_device API which is well aligned with the discussion we had. I just have few minor comments about the split omap_hwmod / omap_device.

To summarize, you should not hack directly hwmod internal attributes from the upper layer.

You should simply expose the same number of API at hwmod level instead of relying on a single omap_hwmod_set_slave_idlemode with miscellaneous parameters.

Quoted 164 lines

Provide APIs to be used by the driver in order to modify AUTOIDLE and SIDLE bits. These APIs in turn call hwmod APIs to modify the SYSCONFIG register.

Signed-off-by Kishon Vijay Abraham I<[email protected]>

Signed-off-by Benoit Cousson<[email protected]>

Cc Paul Walmsley<[email protected]>

---
 arch/arm/plat-omap/include/plat/omap_device.h |    6 + arch/arm/plat-omap/omap_device.c              |  176
+++++++++++++++++++++++++

 2 files changed, 182 insertions(+), 0 deletions(-)

arch/arm/plat-omap/include/plat/omap_device.h +6 -0

index e4c349f..47ad0ab 100644
@@ -110,6 +110,12 @@ struct powerdomain *omap_device_get_pwrdm(struct
 omap_device *od);
  u32 omap_device_get_context_loss_count(struct platform_device *pdev);
 
  /* Other */
+int omap_device_noidle(struct omap_device *od);
+int omap_device_smartidle(struct omap_device *od);
+int omap_device_forceidle(struct omap_device *od);
+int omap_device_default_idle(struct omap_device *od);
+int omap_device_enable_autoidle(struct omap_device *od);
+int omap_device_disable_autoidle(struct omap_device *od);
 
  int omap_device_idle_hwmods(struct omap_device *od);

 int omap_device_enable_hwmods(struct omap_device *od);

arch/arm/plat-omap/omap_device.c +6 -0

index 57adb27..da8609a 100644
@@ -726,6 +726,182 @@ void __iomem *omap_device_get_rt_va(struct
 omap_device *od)
        return omap_hwmod_get_mpu_rt_va(od->hwmods[0]);
  }
 
+/**
+ * omap_device_noidle - set the device's slave idlemode to no idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_noidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "
+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }

arch/arm/plat-omap/omap_device.c +15 -0

+
+       for (i = 0; i<  od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_NO);
+
+       return retval;
+}
+
+
+/**
+ * omap_device_smartidle - set the device's slave idlemode to smart idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to smart idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_smartidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "
+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }

arch/arm/plat-omap/omap_device.c +15 -0

+
+       for (i = 0; i<  od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_SMART);
+
+       return retval;
+}
+
+
+/**
+ * omap_device_forceidle - set the device's slave idlemode to force idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to force idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_forceidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "
+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }

arch/arm/plat-omap/omap_device.c +10 -0

+
+       for (i = 0; i<  od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_FORCE);
+
+       return retval;
+}
+
+/**
+ * omap_device_default_idle - set the device's slave idlemode to no idle

or
+ * smart idle based on the hwmod flag
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle or smart idle
+ * depending on status of the flag HWMOD_SWSUP_SIDLE.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +7 -0

+int omap_device_default_idle(struct omap_device *od)
+{
+       int retval = 0, i;
+       u8 idlemode;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "
+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+               od->_state);

Quoted 8 lines

+               return -EINVAL;
+       }
+
+       for (i = 0; i<  od->hwmods_cnt; i++) {
+               idlemode = (od->hwmods[i]->flags&  HWMOD_SWSUP_SIDLE) ?
+                               HWMOD_IDLEMODE_NO : HWMOD_IDLEMODE_SMART;
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                               idlemode);

That one is the worst :-) You should definitively not hack directly hwmod internal attributes from the upper layer.

Quoted 24 lines

+       }

arch/arm/plat-omap/omap_device.c +10 -0

+
+       return retval;
+}
+
+/*
+ * omap_device_enable_autoidle - enable the device's OCP slave autoidle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave autoidle in hardware.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the AUTOIDLE bits.  Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_autoidle().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_enable_autoidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

Quoted 8 lines

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<  od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_autoidle(od->hwmods[i],
+                                       true);

You are using the same API to send either HWMOD_XXX flags or boolean, and that's quite confusing.

As I said, you'd better duplicate these APIs at hwmod level.

Benoit

Quoted 11 lines · Benoit

Hi Kishon,

Sorry for this late reply.

I'm fine with this omap_device API which is well aligned with the discussion we had. I just have few minor comments about the split omap_hwmod / omap_device.

To summarize, you should not hack directly hwmod internal attributes from the upper layer.

Quoted 3 lines

You should simply expose the same number of API at hwmod level instead of relying on a single omap_hwmod_set_slave_idlemode with miscellaneous parameters.

Should it then be like one-one mapping between omap_device APIs and omap_hwmod APIs, or have a single omap_device API, that takes a additional parameter and based on the parameter, call the appropriate omap_hwmod API?

Quoted 215 lines · KISHON VIJAY

Quoted 162 lines

Provide APIs to be used by the driver in order to modify AUTOIDLE and SIDLE bits. These APIs in turn call hwmod APIs to modify the SYSCONFIG register.

Signed-off-by Kishon Vijay Abraham I<[email protected]>

Signed-off-by Benoit Cousson<[email protected]>

Cc Paul Walmsley<[email protected]>

---
  arch/arm/plat-omap/include/plat/omap_device.h |    6 +
  arch/arm/plat-omap/omap_device.c              |  176
+++++++++++++++++++++++++
  2 files changed, 182 insertions(+), 0 deletions(-)

arch/arm/plat-omap/include/plat/omap_device.h +6 -0

index e4c349f..47ad0ab 100644
@@ -110,6 +110,12 @@ struct powerdomain *omap_device_get_pwrdm(struct
 omap_device *od);
  u32 omap_device_get_context_loss_count(struct platform_device *pdev);
 
  /* Other */
+int omap_device_noidle(struct omap_device *od);
+int omap_device_smartidle(struct omap_device *od);
+int omap_device_forceidle(struct omap_device *od);
+int omap_device_default_idle(struct omap_device *od);
+int omap_device_enable_autoidle(struct omap_device *od);
+int omap_device_disable_autoidle(struct omap_device *od);
 
  int omap_device_idle_hwmods(struct omap_device *od);

  int omap_device_enable_hwmods(struct omap_device *od);

arch/arm/plat-omap/omap_device.c +6 -0

index 57adb27..da8609a 100644
@@ -726,6 +726,182 @@ void __iomem *omap_device_get_rt_va(struct
 omap_device *od)
        return omap_hwmod_get_mpu_rt_va(od->hwmods[0]);
  }
 
+/**
+ * omap_device_noidle - set the device's slave idlemode to no idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits. Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_noidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

arch/arm/plat-omap/omap_device.c +19 -0

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<    od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_NO);
+
+       return retval;
+}
+
+
+/**
+ * omap_device_smartidle - set the device's slave idlemode to smart idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to smart idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits. Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_smartidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

arch/arm/plat-omap/omap_device.c +19 -0

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<    od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_SMART);
+
+       return retval;
+}
+
+
+/**
+ * omap_device_forceidle - set the device's slave idlemode to force idle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to force idle.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the SIDLEMODE bits. Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_forceidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

arch/arm/plat-omap/omap_device.c +14 -0

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<    od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                                       HWMOD_IDLEMODE_FORCE);
+
+       return retval;
+}
+
+/**
+ * omap_device_default_idle - set the device's slave idlemode to no idle

or
+ * smart idle based on the hwmod flag
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave idlemode in hardware to no idle or smart idle
+ * depending on status of the flag HWMOD_SWSUP_SIDLE.
+ * Intended to be used by drivers that have some erratum that requires direct
+ * manipulation of the SIDLEMODE bits. Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_idlemode().
+ */

arch/arm/plat-omap/omap_device.c +7 -0

+int omap_device_default_idle(struct omap_device *od)
+{
+       int retval = 0, i;
+       u8 idlemode;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

arch/arm/plat-omap/omap_device.c void __iomem *omap_device_get_rt_va(struct omap_device *od) · line 843

Quoted 10 lines

arch/arm/plat-omap/omap_device.c +10 -0

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+               od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<    od->hwmods_cnt; i++) {
+               idlemode = (od->hwmods[i]->flags&    HWMOD_SWSUP_SIDLE) ?
+                               HWMOD_IDLEMODE_NO : HWMOD_IDLEMODE_SMART;
+               retval |= omap_hwmod_set_slave_idlemode(od->hwmods[i],
+                               idlemode);

That one is the worst :-) You should definitively not hack directly hwmod internal attributes from the upper layer.

Quoted 24 lines

arch/arm/plat-omap/omap_device.c +11 -0

+       }
+
+       return retval;
+}
+
+/*
+ * omap_device_enable_autoidle - enable the device's OCP slave autoidle
+ * @od: struct omap_device *
+ *
+ * Sets the IP block's OCP slave autoidle in hardware.
+ * Intended to be used by drivers that have some erratum that requires

direct
+ * manipulation of the AUTOIDLE bits. Returns -EINVAL if @od is in invalid
+ * state, or passes along the return value from
+ * omap_hwmod_set_slave_autoidle().
+ */

arch/arm/plat-omap/omap_device.c +6 -0

+int omap_device_enable_autoidle(struct omap_device *od)
+{
+       int retval = 0, i;
+
+       if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
+               WARN(1, "omap_device: %s.%d: %s() called from invalid

state "

arch/arm/plat-omap/omap_device.c void __iomem *omap_device_get_rt_va(struct omap_device *od) · line 872

Quoted 8 lines

arch/arm/plat-omap/omap_device.c +8 -0

+                       "%d\n", od->pdev.name, od->pdev.id, __func__,
+                       od->_state);
+               return -EINVAL;
+       }
+
+       for (i = 0; i<    od->hwmods_cnt; i++)
+               retval |= omap_hwmod_set_slave_autoidle(od->hwmods[i],
+                                       true);

You are using the same API to send either HWMOD_XXX flags or boolean, and that's quite confusing.

Quoted 1 line

As I said, you'd better duplicate these APIs at hwmod level.

   OK.

Quoted 4 lines

Benoit

Certain peripherals require autoidle bits to be disabled before performing some operations. This patch series provides APIs in omap_device layer to modify the SYSCONFIG register.

Since current implementation of PM run time framework does not support changing sysconfig settings during middle of the on going operation, these APIs will support the same.

For e.g McBSP 2 and 3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone.

McBSP also requires the SYSCONFIG to be in NOIDLE when ELEMENTSYNCH mode is selected for DMA operation.

Created on top of linux OMAP master (linux-omap-2.6 :master) Tested on OMAP4430, OMAP3430 and OMAP2430 SDP boards. Verified that this patch series does not break the OMAP1 build.

V2:
Mutex is replaced with spinlock.

V1:
* Creates 3 separate API's to change the idle mode to NOIDLE, SMARTIDLE and FORCEIDLE and one more API to change the idlemode to default value based on the hwmod flag. This change is done to align with the discussion on [3]

* Added hwmod mutex in omap hwmod APIs that modifies SYSCONFIG register.

* omap_hwmod_set_slave_idlemode() is not modified to take true/false kind-of argument since 3 states are associated with SIDLE bits (force, no and smart).

These changes were made to align with Benoit's and Paul's comments for a similar patch written by Manjunath [1] for changing MSTANDBY bits.

The discussions that happened for the RFC patch can be found at [2]

[1]: http://www.mail-archive.com/[email protected]/msg39647.html
[2]: https://patchwork.kernel.org/patch/134371/
[3]: http://www.mail-archive.com/[email protected]/msg39615.html

Kishon Vijay Abraham I (2):
 OMAP: hwmod: API to handle autoidle mode
 OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

 arch/arm/mach-omap2/omap_hwmod.c              |   36 +++++ arch/arm/plat-omap/include/plat/omap_device.h |    6 + arch/arm/plat-omap/include/plat/omap_hwmod.h  |    1 + arch/arm/plat-omap/omap_device.c              |  176 +++++++++++++++++++++++++

 4 files changed, 219 insertions(+), 0 deletions(-)

Kevin, Paul, Benoit,

Do you have any comments for this patch series?

-Kishon

Quoted 52 lines · Kishon Vijay Abraham I

Certain peripherals require autoidle bits to be disabled before performing some operations. This patch series provides APIs in omap_device layer to modify the SYSCONFIG register.

Since current implementation of PM run time framework does not support changing sysconfig settings during middle of the on going operation, these APIs will support the same.

For e.g McBSP 2 and 3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone.

McBSP also requires the SYSCONFIG to be in NOIDLE when ELEMENTSYNCH mode is selected for DMA operation.

Created on top of linux OMAP master (linux-omap-2.6 :master) Tested on OMAP4430, OMAP3430 and OMAP2430 SDP boards. Verified that this patch series does not break the OMAP1 build.

V2:
Mutex is replaced with spinlock.

V1:
* Creates 3 separate API's to change the idle mode to NOIDLE, SMARTIDLE and FORCEIDLE and one more API to change the idlemode to default value based on the hwmod flag. This change is done to align with the discussion on [3]

* Added hwmod mutex in omap hwmod APIs that modifies SYSCONFIG register.

* omap_hwmod_set_slave_idlemode() is not modified to take true/false kind-of argument since 3 states are associated with SIDLE bits (force, no and smart).

These changes were made to align with Benoit's and Paul's comments for a similar patch written by Manjunath [1] for changing MSTANDBY bits.

The discussions that happened for the RFC patch can be found at [2]

[1]: http://www.mail-archive.com/[email protected]/msg39647.html
[2]: https://patchwork.kernel.org/patch/134371/
[3]: http://www.mail-archive.com/[email protected]/msg39615.html

Kishon Vijay Abraham I (2):
 OMAP: hwmod: API to handle autoidle mode
 OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

 arch/arm/mach-omap2/omap_hwmod.c              |   36 +++++ arch/arm/plat-omap/include/plat/omap_device.h |    6 + arch/arm/plat-omap/include/plat/omap_hwmod.h  |    1 + arch/arm/plat-omap/omap_device.c              |  176 +++++++++++++++++++++++++

 4 files changed, 219 insertions(+), 0 deletions(-)