Skip to contentSkip to conversation

softirq: Avoid stack switch from ksoftirqd

PATCH In review Thomas Gleixner 4 participants 5 messages Feb 2, 2011 – Feb 8, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softirq: Avoid stack switch from ksoftirqd

ksoftirqd() calls do_softirq() which switches stacks on several architectures. That makes no sense at all. ksoftirqd's stack is sufficient.

Call __do_softirq() directly.

---
 kernel/softirq.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/softirq.c +4 -1
Index: linux-2.6-tip/kernel/softirq.c
===================================================================
@@ -738,7 +738,10 @@ static int run_ksoftirqd(void * __bind_c
 			   don't process */
 			if (cpu_is_offline((long)__bind_cpu))
 				goto wait_to_die;
-			do_softirq();
+			local_irq_disable();
+			if (local_softirq_pending())
+				__do_softirq();
+			local_irq_enable();
 			preempt_enable_no_resched();
 			cond_resched();
 			preempt_disable();
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Thomas Gleixner

ksoftirqd() calls do_softirq() which switches stacks on several architectures. That makes no sense at all. ksoftirqd's stack is sufficient.

Call __do_softirq() directly.

Quoted 20 lines
---
 kernel/softirq.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6-tip/kernel/softirq.c
===================================================================

kernel/softirq.c +4 -1
@@ -738,7 +738,10 @@ static int run_ksoftirqd(void * __bind_c
 			   don't process */
 			if (cpu_is_offline((long)__bind_cpu))
 				goto wait_to_die;
-			do_softirq();
+			local_irq_disable();
+			if (local_softirq_pending())
+				__do_softirq();
+			local_irq_enable();
 			preempt_enable_no_resched();
 			cond_resched();
 			preempt_disable();
Reviewed-by on v1 1/1
#3 lore raw
In reply to Thomas Gleixner
Quoted 7 lines · Thomas Gleixner

ksoftirqd() calls do_softirq() which switches stacks on several architectures. That makes no sense at all. ksoftirqd's stack is sufficient.

Call __do_softirq() directly.

Quoted 26 lines
---
 kernel/softirq.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6-tip/kernel/softirq.c
===================================================================

kernel/softirq.c +4 -2
@@ -738,7 +738,10 @@ static int run_ksoftirqd(void * __bind_c
 			   don't process */
 			if (cpu_is_offline((long)__bind_cpu))
 				goto wait_to_die;
-			do_softirq();
+			local_irq_disable();
+			if (local_softirq_pending())
+				__do_softirq();
+			local_irq_enable();
 			preempt_enable_no_resched();
 			cond_resched();
 			preempt_disable();
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
In reply to Thomas Gleixner
Commit-ID:  c305d524e5dd3c3c7a6035083e30950bea1b52dc
Gitweb:     http://git.kernel.org/tip/c305d524e5dd3c3c7a6035083e30950bea1b52dc
Author:     Thomas Gleixner <[email protected]>
AuthorDate: Wed, 2 Feb 2011 17:10:48 +0100
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Tue, 8 Feb 2011 19:37:12 +0100

softirq: Avoid stack switch from ksoftirqd

ksoftirqd() calls do_softirq() which switches stacks on several architectures. That makes no sense at all. ksoftirqd's stack is sufficient.

Call __do_softirq() directly.

LKML-Reference: <[email protected]>

---
 kernel/softirq.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
kernel/softirq.c +4 -1
index 68eb5ef..c049046 100644
@@ -738,7 +738,10 @@ static int run_ksoftirqd(void * __bind_cpu)
 			   don't process */
 			if (cpu_is_offline((long)__bind_cpu))
 				goto wait_to_die;
-			do_softirq();
+			local_irq_disable();
+			if (local_softirq_pending())
+				__do_softirq();
+			local_irq_enable();
 			preempt_enable_no_resched();
 			cond_resched();
 			preempt_disable();