Skip to contentSkip to conversation

collie: do actually pass locomo_info to locomo driver

PATCH New Dmitry Eremin-Solenikov 2 participants 2 messages Feb 3, 2011 – Feb 16, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 collie: do actually pass locomo_info to locomo driver

locomo_info isn't actually used as a platform_data on collie platform:
arm/mach-sa1100/collie.c:237: warning: ?locomo_info? defined but not used

So locomo driver doesn't setup IRQs correctly. Pass locomo_info to the driver.

Cc stable at kernel.org
---
 arch/arm/mach-sa1100/collie.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-sa1100/collie.c +3 -0
index d43c5ef..bd3e1bf 100644
@@ -241,6 +241,9 @@ static struct locomo_platform_data locomo_info = {
 struct platform_device collie_locomo_device = {
 	.name		= "locomo",
 	.id		= 0,
+	.dev		= {
+		.platform_data	= &locomo_info,
+	},
 	.num_resources	= ARRAY_SIZE(locomo_resources),
 	.resource	= locomo_resources,
 };
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 collie: do actually pass locomo_info to locomo driver

Quoted 30 lines · Dmitry Eremin-Solenikov

locomo_info isn't actually used as a platform_data on collie platform:
?arm/mach-sa1100/collie.c:237: warning: ?locomo_info? defined but not used

So locomo driver doesn't setup IRQs correctly. Pass locomo_info to the driver.

Cc stable at kernel.org

---
?arch/arm/mach-sa1100/collie.c | ? ?3 +++
?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-sa1100/collie.c +3 -1
index d43c5ef..bd3e1bf 100644
@@ -241,6 +241,9 @@ static struct locomo_platform_data locomo_info = {
 ?struct platform_device collie_locomo_device = {
 ? ? ? ?.name ? ? ? ? ? = "locomo",
 ? ? ? ?.id ? ? ? ? ? ? = 0,
+ ? ? ? .dev ? ? ? ? ? ?= {
+ ? ? ? ? ? ? ? .platform_data ?= &locomo_info,
+ ? ? ? },
 ? ? ? ?.num_resources ?= ARRAY_SIZE(locomo_resources),
 ? ? ? ?.resource ? ? ? = locomo_resources,
 ?};
--

1.7.2.3

Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

The issue is confirmed (see log http://pastebin.com/se3BMrmU )

#locomokbd: Can't get irq for keyboard #locomokbd: probe of locomo-keyboard failed with error -22

Please apply this trivial fix, thx.
Tested on real hw by OpenEmbedded developers.

Regards

Andrea