Skip to contentSkip to conversation

video: ffb: fix ffb_probe error path

PATCH In review Axel Lin 2 participants 2 messages Feb 8, 2011 Framebuffer layer

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 video: ffb: fix ffb_probe error path

Current implementation calls of_iounmap for par->fbc twice in error path. In the case of goto out_unmap_dac, we should call of_iounmap for par->dac.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/video/ffb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/ffb.c +1 -1
index 6739b2a..b5d6a46 100644
@@ -1011,7 +1011,7 @@ out_dealloc_cmap:
 	fb_dealloc_cmap(&info->cmap);
 
 out_unmap_dac:
-	of_iounmap(&op->resource[2], par->fbc, sizeof(struct ffb_fbc));
+	of_iounmap(&op->resource[1], par->dac, sizeof(struct ffb_dac));
 
 out_unmap_fbc:
 	of_iounmap(&op->resource[2], par->fbc, sizeof(struct ffb_fbc));
Signature · 1 line
1.7.1