Skip to contentSkip to conversation

fsl: update CRC after system EEPROM identifier

PATCH New Timur Tabi 2 participants 3 messages Feb 9, 2011 – Feb 10, 2011

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 fsl: update CRC after system EEPROM identifier

The "mac id" command is used to initialize the EEPROM data to a specific format, but it was not updating the CRC. This didn't cause any real problems, because writing the data to the EEPROM will always update the CRC anyway, but it did result in a bogus CRC warning.

---
 board/freescale/common/sys_eeprom.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
board/freescale/common/sys_eeprom.c +1 -0
index 11dfd84..3ecfb06 100644
@@ -361,6 +361,7 @@ int do_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #else
 		memcpy(e.id, "CCID", sizeof(e.id));
 #endif
+		update_crc();
 		return 0;
 	}
 
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 fsl: update CRC after system EEPROM identifier

Quoted 7 lines · Timur Tabi

The "mac id" command is used to initialize the EEPROM data to a specific format, but it was not updating the CRC. ?This didn't cause any real problems, because writing the data to the EEPROM will always update the CRC anyway, but it did result in a bogus CRC warning.

---

That should say, "after setting EEPROM identifier"

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#2 lore raw

PATCH 1/1 fsl: update CRC after system EEPROM identifier

Quoted 10 lines · Timur Tabi
Quoted 7 lines · Timur Tabi

The "mac id" command is used to initialize the EEPROM data to a specific format, but it was not updating the CRC. This didn't cause any real problems, because writing the data to the EEPROM will always update the CRC anyway, but it did result in a bogus CRC warning.

---

That should say, "after setting EEPROM identifier"

Fixed, committed to 85xx

- k