Skip to contentSkip to conversation

ARM: mm: don't free memmap entries in the middle of a MAX_ORDER_NR_PAGES block

PATCH New Dima Zavin 1 participant 1 message Feb 9, 2011 Arm (32-bit)

lore
Share & tools
lore

Dima Zavin

author
#0 lore raw

PATCH 1/1 ARM: mm: don't free memmap entries in the middle of a MAX_ORDER_NR_PAGES block

On some machines, nodes do not always start on MAX_ORDER_NR_PAGES boundaries. The rest of the VM assumes that pages within a MAX_ORDER_NR_PAGES range always have valid memmap entries. So, we round down the bank_start in free_unused_memmap to ensure that there are valid page structs for all pages within a MAX_ORDER_NR_PAGES block of pages.

---
 arch/arm/mm/init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mm/init.c +2 -1
index cddd684..1290fbe 100644
@@ -424,7 +424,8 @@ static void __init free_unused_memmap(struct meminfo *mi)
 	for_each_bank(i, mi) {
 		struct membank *bank = &mi->bank[i];
 
-		bank_start = bank_pfn_start(bank);
+		bank_start = round_down(bank_pfn_start(bank),
+					MAX_ORDER_NR_PAGES);
 
 		/*
 		 * If we had a previous bank, and there is a space
Signature · 1 line
1.7.3.1