Skip to contentSkip to conversation

OMAP: IOMMU: add missing function declaration

PATCH New David Cohen 2 participants 3 messages Feb 12, 2011 – Feb 14, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

David Cohen

author
#0 lore raw

PATCH 1/1 OMAP: IOMMU: add missing function declaration

Function declaration 'iopgtable_lookup_entry' is missing from header file.

Signed-off-by David Cohen <[email protected]>
---
 arch/arm/plat-omap/include/plat/iommu.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/plat-omap/include/plat/iommu.h +2 -0
index 9e8c104..5a2475f 100644
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
 extern void flush_iotlb_all(struct iommu *obj);
 
 extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+				   u32 **ppte);
 extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
 
 extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 OMAP: IOMMU: add missing function declaration

Quoted 2 lines · David Cohen

Function declaration 'iopgtable_lookup_entry' is missing from header file.

Is this done because of any error?
You may add a comment on why this is required.

Quoted 22 lines
Signed-off-by David Cohen <[email protected]>

---
?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++ ?1 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/plat-omap/include/plat/iommu.h +2 -1
index 9e8c104..5a2475f 100644
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
 ?extern void flush_iotlb_all(struct iommu *obj);
 
 ?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
 ?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
 
 ?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
--

1.7.1

author
#2 lore raw

PATCH 1/1 OMAP: IOMMU: add missing function declaration

Quoted 6 lines · Charulatha
Quoted 2 lines · David Cohen

Function declaration 'iopgtable_lookup_entry' is missing from header file.

Is this done because of any error?
You may add a comment on why this is required.

The function is exported by iommu module, but no other driver is using it so far. So, it's wrong but currently we have only a sparse warning. I can add this information to the patch description.

Br,

David

Quoted 24 lines
Quoted 23 lines
Signed-off-by David Cohen <[email protected]>

---
?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++ ?1 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/plat-omap/include/plat/iommu.h +2 -1
index 9e8c104..5a2475f 100644
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
 ?extern void flush_iotlb_all(struct iommu *obj);
 
 ?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
 ?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
 
 ?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
--

1.7.1