Skip to contentSkip to conversation

ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata

PATCH In review Axel Lin 2 participants 2 messages Feb 14, 2011 – Feb 18, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata

s3c24xx_ts_set_platdata is annotated __init and not used by any module, thus don't export it.
This patch fixes below warning:

WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section mismatch in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the function .init.text:s3c24xx_ts_set_platdata() The symbol s3c24xx_ts_set_platdata is exported and annotated __init
Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or drop the export.

Signed-off-by Axel Lin <[email protected]>
---
 arch/arm/plat-samsung/dev-ts.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/plat-samsung/dev-ts.c +0 -1
index 236ef84..3e4bd81 100644
@@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *pd)
 
 	s3c_device_ts.dev.platform_data = npd;
 }
-EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
Signature · 1 line
1.7.2
#1 lore raw
Quoted 6 lines · Axel Lin

s3c24xx_ts_set_platdata is annotated __init and not used by any module, thus don't export it.
This patch fixes below warning:

WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section

mismatch

Quoted 4 lines

in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the function .init.text:s3c24xx_ts_set_platdata()
The symbol s3c24xx_ts_set_platdata is exported and annotated __init Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or

drop

Review

Quoted 8 lines

the export.

Signed-off-by Axel Lin <[email protected]>
---
 arch/arm/plat-samsung/dev-ts.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/arm/plat-samsung/dev-ts.c

Quoted 10 lines

index 236ef84..3e4bd81 100644

arch/arm/plat-samsung/dev-ts.c +0 -2
@@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct
 s3c2410_ts_mach_info *pd)
 
 	s3c_device_ts.dev.platform_data = npd;
 }
-EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
--
Quoted 2 lines

1.7.2

Ok, applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.