Skip to contentSkip to conversation

arm: get_sp() should always be compiled

PATCH Superseded Po-Yu Chuang 3 participants 7 messages Feb 16, 2011 – Feb 18, 2011 1 message not in the archive Arm (32-bit)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Po-Yu Chuang

author
#1 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

From: Po-Yu Chuang <[email protected]>

get_sp() was incorrectly excluded if none of
CONFIG_SETUP_MEMORY_TAGS
CONFIG_CMDLINE_TAG
CONFIG_INITRD_TAG
CONFIG_SERIAL_TAG
CONFIG_REVISION_TAG
were defined.

Signed-off-by Po-Yu Chuang <[email protected]>

---
v2:
rebase

 arch/arm/lib/bootm.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/arm/lib/bootm.c +1 -3
index a1649ee..7734953 100644
@@ -327,12 +327,12 @@ void setup_revision_tag(struct tag **in_params)
 }
 #endif  /* CONFIG_REVISION_TAG */
 
-
 static void setup_end_tag (bd_t *bd)
 {
 	params->hdr.tag = ATAG_NONE;
 	params->hdr.size = 0;
 }
+#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */
 
 static ulong get_sp(void)
 {

@@ -341,5 +341,3 @@ static ulong get_sp(void)
 	asm("mov %0, sp" : "=r"(ret) : );
 	return ret;
 }
-
-#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */
Signature · 1 line
1.6.3.3
#2 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

Hi,

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 9 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
CONFIG_SETUP_MEMORY_TAGS
CONFIG_CMDLINE_TAG
CONFIG_INITRD_TAG
CONFIG_SERIAL_TAG
CONFIG_REVISION_TAG
were defined.

Which board exactly requires this patch?

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

Hi,

2011/2/17 Albert ARIBAUD <[email protected]>:

Quoted 14 lines

Hi,

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 9 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
? ?CONFIG_SETUP_MEMORY_TAGS
? ?CONFIG_CMDLINE_TAG
? ?CONFIG_INITRD_TAG
? ?CONFIG_SERIAL_TAG
? ?CONFIG_REVISION_TAG
were defined.

Quoted 2 lines

Which board exactly requires this patch?

I think it is a320evb.

Signature · 2 lines
Best regards,
Macpaul Lin
#4 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

Le 17/02/2011 13:54, Macpaul Lin a ?crit :

Quoted 17 lines

Hi,

2011/2/17 Albert ARIBAUD<[email protected]>:

Quoted 14 lines

Hi,

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 9 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
CONFIG_SETUP_MEMORY_TAGS
CONFIG_CMDLINE_TAG
CONFIG_INITRD_TAG
CONFIG_SERIAL_TAG
CONFIG_REVISION_TAG
were defined.

Quoted 4 lines
Quoted 2 lines

Which board exactly requires this patch?

I think it is a320evb.

Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway.

Amicalement,

Signature · 1 line
Albert.
author
#5 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

Hi Albert,

Quoted 13 lines · Albert ARIBAUD

Le 17/02/2011 13:54, Macpaul Lin a ?crit :

Quoted 12 lines

2011/2/17 Albert ARIBAUD<[email protected]>:

Quoted 11 lines

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 9 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
? ?CONFIG_SETUP_MEMORY_TAGS
? ?CONFIG_CMDLINE_TAG
? ?CONFIG_INITRD_TAG
? ?CONFIG_SERIAL_TAG
? ?CONFIG_REVISION_TAG
were defined.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Which board exactly requires this patch?

I think it is a320evb.

Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway.

The following patches fix all the build errors of a320evb:
(Although it still won't work, its timer still need some fix.)

[PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday [PATCH v2 2/2] arm: a320: use new ftpmu010 API

best regards,
Po-Yu Chuang

#6 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

Le 18/02/2011 06:42, Po-Yu Chuang a ?crit :

Quoted 20 lines

Hi Albert,

Quoted 17 lines · Albert ARIBAUD

Le 17/02/2011 13:54, Macpaul Lin a ?crit :

Quoted 15 lines

2011/2/17 Albert ARIBAUD<[email protected]>:

Quoted 11 lines

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 9 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
CONFIG_SETUP_MEMORY_TAGS
CONFIG_CMDLINE_TAG
CONFIG_INITRD_TAG
CONFIG_SERIAL_TAG
CONFIG_REVISION_TAG
were defined.

Quoted 1 line

Which board exactly requires this patch?

I think it is a320evb.

Quoted 8 lines
Quoted 2 lines

Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway.

The following patches fix all the build errors of a320evb:
(Although it still won't work, its timer still need some fix.)

[PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday [PATCH v2 2/2] arm: a320: use new ftpmu010 API

Thanks. If these receive review soon, I'll include them in my next pull along with the ARM machine type update.

Quoted 2 lines

best regards,
Po-Yu Chuang

Amicalement,

Signature · 1 line
Albert.
#7 lore raw

PATCH v2 1/1 arm: get_sp() should always be compiled

In reply to Po-Yu Chuang

Hi Po-Yu Chang,

Le 16/02/2011 09:54, Po-Yu Chuang a ?crit :

Quoted 10 lines

From: Po-Yu Chuang<[email protected]>

get_sp() was incorrectly excluded if none of
CONFIG_SETUP_MEMORY_TAGS
CONFIG_CMDLINE_TAG
CONFIG_INITRD_TAG
CONFIG_SERIAL_TAG
CONFIG_REVISION_TAG
were defined.

Quoted 4 lines
Signed-off-by Po-Yu Chuang<[email protected]>

---
v2:
rebase

Applied, to u-boot-arm/master as it is actually an old patch submission and a bugfix.

Amicalement,

Signature · 1 line
Albert.