Skip to contentSkip to conversation

USB: ffs-test: fix header path

PATCH In review Davidlohr Bueso 3 participants 6 messages Feb 6, 2011 – Feb 27, 2011

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 USB: ffs-test: fix header path

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tools/usb/ffs-test.c +2 -2
index bbe2e3a..f2c6524 100644
@@ -37,7 +37,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 
-#include <linux/usb/functionfs.h>
+#include "../../include/linux/usb/functionfs.h"
 
 
 /******************** Little Endian Handling ********************************/
@@ -450,7 +450,7 @@ invalid:
 		    len, expected, *p);
 		for (p = buf, len = 0; len < nbytes; ++p, ++len) {
 			if (0 == (len % 32))
-				fprintf(stderr, "%4d:", len);
+				fprintf(stderr, "%4zd", len);
 			fprintf(stderr, " %02x", *p);
 			if (31 == (len % 32))
 				fprintf(stderr, "\n");
Signature · 1 line
1.7.1
#1 lore raw

Hi Greg, just following up on this (ping) with the requested changes.

Thanks.

Quoted 35 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tools/usb/ffs-test.c +2 -2
index bbe2e3a..f2c6524 100644
@@ -37,7 +37,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 
-#include <linux/usb/functionfs.h>
+#include "../../include/linux/usb/functionfs.h"
 
 
 /******************** Little Endian Handling ********************************/
@@ -450,7 +450,7 @@ invalid:
 		    len, expected, *p);
 		for (p = buf, len = 0; len < nbytes; ++p, ++len) {
 			if (0 == (len % 32))
-				fprintf(stderr, "%4d:", len);
+				fprintf(stderr, "%4zd", len);
 			fprintf(stderr, " %02x", *p);
 			if (31 == (len % 32))
 				fprintf(stderr, "\n");
#2 lore raw
In reply to Davidlohr Bueso
Quoted 5 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

Quoted 7 lines

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply properly to the linux-next branch, what did you make it against?

confused,

greg k-h

#3 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

Quoted 8 lines
Quoted 4 lines
---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply properly to the linux-next branch, what did you make it against?

It was against Linus' tree (did a pull right before submitting the patch).

Quoted 4 lines

confused,

greg k-h

#4 lore raw
Quoted 15 lines · Davidlohr Bueso
Quoted 14 lines · Greg KH
Quoted 12 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Quoted 6 lines
Quoted 3 lines

This patch doesn't apply properly to the linux-next branch, what did you make it against?

It was against Linus' tree (did a pull right before submitting the patch).

Ah, so you think this is needed for Linus's tree now? Care to resend it and I'll queue it up to the proper tree, sorry, I missed that.

thanks,

greg k-h

#5 lore raw
Quoted 20 lines · Greg KH
Quoted 19 lines · Davidlohr Bueso
Quoted 17 lines · Greg KH
Quoted 5 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

Quoted 7 lines

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply properly to the linux-next branch, what did you make it against?

Quoted 6 lines
Quoted 2 lines

It was against Linus' tree (did a pull right before submitting the patch).

Ah, so you think this is needed for Linus's tree now? Care to resend it and I'll queue it up to the proper tree, sorry, I missed that.

Sorry about the delay, you wouldn't believe the problems I have with a slow ('90s) internet connection when trying to clone a tree. Here is a version against the latest linux-next. Thanks.

From: Davidlohr Bueso <[email protected]>
Date: Sun, 27 Feb 2011 04:55:59 -0300
Subject: [PATCH] USB: ffs-test: fix header path

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tools/usb/ffs-test.c +2 -2
index bbe2e3a..b9c7986 100644
@@ -37,7 +37,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 
-#include <linux/usb/functionfs.h>
+#include "../../include/linux/usb/functionfs.h"
 
 
 /******************** Little Endian Handling ********************************/
@@ -450,7 +450,7 @@ invalid:
 		    len, expected, *p);
 		for (p = buf, len = 0; len < nbytes; ++p, ++len) {
 			if (0 == (len % 32))
-				fprintf(stderr, "%4d:", len);
+				fprintf(stderr, "%4zd:", len);
 			fprintf(stderr, " %02x", *p);
 			if (31 == (len % 32))
 				fprintf(stderr, "\n");
Signature · 1 line
1.7.1