Skip to contentSkip to conversation

ssb: trivial: fix SPROM extract warning formatting

PATCH New Rafał Miłecki 2 participants 3 messages Feb 16, 2011 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/2 ssb: trivial: fix SPROM extract warning formatting

Signed-off-by Rafał Miłecki <[email protected]>
---
 drivers/ssb/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ssb/pci.c +1 -1
index 158449e..127897c 100644
@@ -641,7 +641,7 @@ static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out,
 		break;
 	default:
 		ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
-			   "  revision %d detected. Will extract"
+			   " revision %d detected. Will extract"
 			   " v1\n", out->revision);
 		out->revision = 1;
 		sprom_extract_r123(out, in);
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 ssb: remove invalid define SSB_TMSLOW_PHYCLK

It was incorrectly introduced in d2730b2a6a019d14455556019d744ab051e6554b. We have already fixed function to use correct define, but forgot remove old one.

Signed-off-by Rafał Miłecki <[email protected]>
Cc Gábor Stefanik <[email protected]>
---
 include/linux/ssb/ssb_regs.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/ssb/ssb_regs.h +0 -1
index 489f7b6..01253c6 100644
@@ -97,7 +97,6 @@
 #define  SSB_TMSLOW_RESET	0x00000001 /* Reset */
 #define  SSB_TMSLOW_REJECT_22	0x00000002 /* Reject (Backplane rev 2.2) */
 #define  SSB_TMSLOW_REJECT_23	0x00000004 /* Reject (Backplane rev 2.3) */
-#define  SSB_TMSLOW_PHYCLK	0x00000010 /* MAC PHY Clock Control Enable */
 #define  SSB_TMSLOW_CLOCK	0x00010000 /* Clock Enable */
 #define  SSB_TMSLOW_FGC		0x00020000 /* Force Gated Clocks On */
 #define  SSB_TMSLOW_PE		0x40000000 /* Power Management Enable */
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/2 ssb: trivial: fix SPROM extract warning formatting

In reply to Rafał Miłecki
Quoted 10 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 drivers/ssb/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ssb/pci.c +0 -0
index 158449e..127897c 100644

drivers/ssb/pci.c static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out, · line 647

Quoted 8 lines
drivers/ssb/pci.c +1 -1
@@ -641,7 +641,7 @@ static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out,
 		break;
 	default:
 		ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
-			   "  revision %d detected. Will extract"
+			   " revision %d detected. Will extract"
 			   " v1\n", out->revision);
 		out->revision = 1;
 		sprom_extract_r123(out, in);

ack for those two patches.

Signature · 1 line
Greetings Michael.