Skip to contentSkip to conversation

memcg: clarify use_hierarchy documentation

PATCH Applied Greg Thelen 3 participants 3 messages Feb 17, 2011 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memcg: clarify use_hierarchy documentation

The memcg code does not allow changing memory.use_hierarchy if the parent cgroup has enabled use_hierarchy. Update documentation to match the code.

---
 Documentation/cgroups/memory.txt |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Documentation/cgroups/memory.txt +3 -2
index 7781857..b6ed61c 100644
@@ -485,8 +485,9 @@ The feature can be disabled by
 
 # echo 0 > memory.use_hierarchy
 
-NOTE1: Enabling/disabling will fail if the cgroup already has other
-       cgroups created below it.
+NOTE1: Enabling/disabling will fail if either the cgroup already has other
+       cgroups created below it, or if the parent cgroup has use_hierarchy
+       enabled.
 
 NOTE2: When panic_on_oom is set to "2", the whole system will panic in
        case of an OOM event in any cgroup.
Signature · 1 line
1.7.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Wed, 16 Feb 2011 17:51:23 -0800 Greg Thelen <[email protected]> wrote:

The memcg code does not allow changing memory.use_hierarchy if the parent cgroup has enabled use_hierarchy. Update documentation to match the code.

Thank you,

Because I tend to read linux-mm list 1st, I'm glad if you CC linux-mm in the next time.

Quoted 24 lines
---
 Documentation/cgroups/memory.txt |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Documentation/cgroups/memory.txt +3 -2
index 7781857..b6ed61c 100644
@@ -485,8 +485,9 @@ The feature can be disabled by
 
 # echo 0 > memory.use_hierarchy
 
-NOTE1: Enabling/disabling will fail if the cgroup already has other
-       cgroups created below it.
+NOTE1: Enabling/disabling will fail if either the cgroup already has other
+       cgroups created below it, or if the parent cgroup has use_hierarchy
+       enabled.
 
 NOTE2: When panic_on_oom is set to "2", the whole system will panic in
        case of an OOM event in any cgroup.
Signature · 1 line
1.7.3.1
Applied
#2 lore raw
Quoted 11 lines · KAMEZAWA Hiroyuki
Quoted 5 lines · On Wed, 16 Feb 2011 17:51:23 -0800 Greg Thelen <[email protected]> wrote:

The memcg code does not allow changing memory.use_hierarchy if the parent cgroup has enabled use_hierarchy. Update documentation to match the code.

Thank you,

Applied, thanks.

Quoted 29 lines

Because I tend to read linux-mm list 1st, I'm glad if you CC linux-mm in the next time.

Quoted 24 lines
---
 Documentation/cgroups/memory.txt |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Documentation/cgroups/memory.txt +3 -2
index 7781857..b6ed61c 100644
@@ -485,8 +485,9 @@ The feature can be disabled by
 
 # echo 0 > memory.use_hierarchy
 
-NOTE1: Enabling/disabling will fail if the cgroup already has other
-       cgroups created below it.
+NOTE1: Enabling/disabling will fail if either the cgroup already has other
+       cgroups created below it, or if the parent cgroup has use_hierarchy
+       enabled.
 
 NOTE2: When panic_on_oom is set to "2", the whole system will panic in
        case of an OOM event in any cgroup.
Signature · 1 line
1.7.3.1
Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.