Skip to contentSkip to conversation

oestats-client: only send report when task has failed

PATCH In review Eric Bénard 3 participants 4 messages Feb 18, 2011

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 oestats-client: only send report when task has failed

actual behaviour is to send a report for *each* task runned by bitbake this is ok for one personnal oestat server but doesn't scale well when dozen of peoples are running test builders which all send reports to the OE's infrastructure.

---
v2: cleaner way to handle the problem as per pb & Jay2 suggestion

 classes/oestats-client.bbclass |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
classes/oestats-client.bbclass +4 -2
index 4233d4a..f9ac88f 100644
@@ -202,8 +202,10 @@ python oestats_eventhandler () {
 		oestats_stop(server, e.data, e.getFailures())
 	elif getName(e) == 'TaskStarted':
 		bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
-	elif getName(e) == 'TaskSucceeded':
-		oestats_task(server, e.data, e.task, 'Succeeded')
+	# Temporary disable sending sucess report as this generates to much trafic
+	# for the oestat server
+	# elif getName(e) == 'TaskSucceeded':
+	#	oestats_task(server, e.data, e.task, 'Succeeded')
 	elif getName(e) == 'TaskFailed':
 		oestats_task(server, e.data, e.task, 'Failed')
 }
Signature · 1 line
1.7.0.4
Acked-by on v2 1/1
#1 lore raw

2011/2/18 Eric Bénard <[email protected]>:

Quoted 6 lines

actual behaviour is to send a report for *each* task runned by bitbake this is ok for one personnal oestat server but doesn't scale well when dozen of peoples are running test builders which all send reports to the OE's infrastructure.

I'm Ack'ing it as temporary solution to keep oestats server running..

Quoted 25 lines

---
v2: cleaner way to handle the problem as per pb & Jay2 suggestion

 classes/oestats-client.bbclass |    6 ++++--

 1 files changed, 4 insertions(+), 2 deletions(-)
classes/oestats-client.bbclass +0 -0
index 4233d4a..f9ac88f 100644
@@ -202,8 +202,10 @@ python oestats_eventhandler () {
                oestats_stop(server, e.data, e.getFailures())

       elif getName(e) == 'TaskStarted':
               bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
-       elif getName(e) == 'TaskSucceeded':
-               oestats_task(server, e.data, e.task, 'Succeeded')
+       # Temporary disable sending sucess report as this generates to much trafic
+       # for the oestat server
+       # elif getName(e) == 'TaskSucceeded':
+       #       oestats_task(server, e.data, e.task, 'Succeeded') elif getName(e) == 'TaskFailed':
               oestats_task(server, e.data, e.task, 'Failed')
 }
--
1.7.0.4

Signature · 1 line
Yury Bushmelev
#2 lore raw
In reply to Eric Bénard
Quoted 21 lines · Eric Bénard

actual behaviour is to send a report for *each* task runned by bitbake this is ok for one personnal oestat server but doesn't scale well when dozen of peoples are running test builders which all send reports to the OE's infrastructure.

---
v2: cleaner way to handle the problem as per pb & Jay2 suggestion

 classes/oestats-client.bbclass |    6 ++++--

 1 files changed, 4 insertions(+), 2 deletions(-)
classes/oestats-client.bbclass +0 -0
index 4233d4a..f9ac88f 100644
@@ -202,8 +202,10 @@ python oestats_eventhandler () {
                oestats_stop(server, e.data, e.getFailures())

       elif getName(e) == 'TaskStarted':
               bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
-       elif getName(e) == 'TaskSucceeded':

Quoted 8 lines

-               oestats_task(server, e.data, e.task, 'Succeeded')
+       # Temporary disable sending sucess report as this generates to much trafic
+       # for the oestat server
+       # elif getName(e) == 'TaskSucceeded':
+       #       oestats_task(server, e.data, e.task, 'Succeeded') elif getName(e) == 'TaskFailed':
               oestats_task(server, e.data, e.task, 'Failed')
 }

will this mean that only failed packages show up on tinderbox ?

Quoted 9 lines

--
1.7.0.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw

Hi Khem,

Quoted 25 lines · Khem Raj
Quoted 24 lines · Eric Bénard

actual behaviour is to send a report for *each* task runned by bitbake this is ok for one personnal oestat server but doesn't scale well when dozen of peoples are running test builders which all send reports to the OE's infrastructure.

---
v2: cleaner way to handle the problem as per pb& Jay2 suggestion

  classes/oestats-client.bbclass |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)
classes/oestats-client.bbclass +2 -2
index 4233d4a..f9ac88f 100644
@@ -202,8 +202,10 @@ python oestats_eventhandler () {
                oestats_stop(server, e.data, e.getFailures())
        elif getName(e) == 'TaskStarted':
                bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
-       elif getName(e) == 'TaskSucceeded':
-               oestats_task(server, e.data, e.task, 'Succeeded')
+       # Temporary disable sending sucess report as this generates to much trafic
+       # for the oestat server
Quoted 8 lines

classes/oestats-client.bbclass python oestats_eventhandler () { · line 211

Quoted 5 lines
classes/oestats-client.bbclass +2 -0
+       # elif getName(e) == 'TaskSucceeded':
+       #       oestats_task(server, e.data, e.task, 'Succeeded')
        elif getName(e) == 'TaskFailed':
                oestats_task(server, e.data, e.task, 'Failed')
  }

will this mean that only failed packages show up on tinderbox ?

exactly. this is a temporary solution and I think this is better than no more having tinderbox running.

Eric