avoid absolute pathnames for general utils in libtool scripts

PATCH Applied Nitin A Kamble 3 participants 4 messages Feb 18, 2011 – Feb 21, 2011

lore

Share & tools

lore

Nitin A Kamble

author

2011-02-18 18:21 UTC #0 lore raw

cover avoid absolute pathnames for general utils in libtool scripts

From: Nitin A Kamble <[email protected]>

The builthost specific absolute pathnames were not working on other hosts with the nativesdk libtool package. This commit fixes that.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: nitin/misc
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Thanks,
Nitin A Kamble <[email protected]>
---

Nitin A Kamble (1):
libtool: avoid absolute pathnames of general utils

 meta/recipes-devtools/libtool/libtool-cross_2.4.bb |    2 +-
 .../recipes-devtools/libtool/libtool-native_2.4.bb |    2 +-
 .../libtool/libtool-nativesdk_2.4.bb               |    2 +-
 meta/recipes-devtools/libtool/libtool.inc          |    3 +-
 .../avoid_absolute_paths_for_general_utils.patch   |   37 ++++++++++++++++++++
 meta/recipes-devtools/libtool/libtool_2.4.bb       |    2 +-
 6 files changed, 43 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-devtools/libtool/libtool/avoid_absolute_paths_for_general_utils.patch

Signature · 1 line

1.7.3.4

Nitin A Kamble

author

2011-02-18 18:21 UTC #1 lore raw

PATCH 1/1 libtool: avoid absolute pathnames of general utils

From: Nitin A Kamble <[email protected]>

addded a new patch:
libtool/avoid_absolute_paths_for_general_utils.patch

This fixes [BUGID #154]
This fixes [BUGID #734]

Signed-off-by Nitin A Kamble <[email protected]>

---
 meta/recipes-devtools/libtool/libtool-cross_2.4.bb |    2 +-
 .../recipes-devtools/libtool/libtool-native_2.4.bb |    2 +-
 .../libtool/libtool-nativesdk_2.4.bb               |    2 +-
 meta/recipes-devtools/libtool/libtool.inc          |    3 +-
 .../avoid_absolute_paths_for_general_utils.patch   |   37 ++++++++++++++++++++
 meta/recipes-devtools/libtool/libtool_2.4.bb       |    2 +-
 6 files changed, 43 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-devtools/libtool/libtool/avoid_absolute_paths_for_general_utils.patch

meta/recipes-devtools/libtool/libtool-cross_2.4.bb +1 -1

index e3b40f2..25ac580 100644
@@ -1,6 +1,6 @@
 require libtool-${PV}.inc
 
-PR = "r1"
+PR = "r2"
 PACKAGES = ""
 SRC_URI += "file://prefix.patch"

meta/recipes-devtools/libtool/libtool-native_2.4.bb +1 -1

index 4163e89..423622f 100644
@@ -2,7 +2,7 @@ require libtool-${PV}.inc
 
 DEPENDS = ""
 
-PR = "r1"
+PR = "r2"
 SRC_URI += "file://prefix.patch"
 
 inherit native

meta/recipes-devtools/libtool/libtool-nativesdk_2.4.bb +1 -1

index 45c9af6..4f67fed 100644
@@ -1,6 +1,6 @@
 require libtool-${PV}.inc
 
-PR = "r1"
+PR = "r2"
 SRC_URI += "file://prefix.patch"
 
 inherit nativesdk

meta/recipes-devtools/libtool/libtool.inc +2 -1

index 8701c82..e066ffa 100644
@@ -14,7 +14,8 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://rename-with-sysroot.patch \
            file://resolve-sysroot.patch \
            file://use-sysroot-in-libpath.patch \
-           file://fix-final-rpath.patch"
+           file://fix-final-rpath.patch \
+           file://avoid_absolute_paths_for_general_utils.patch "
 
 do_compile_prepend () {
 	# Sometimes this file doesn't get rebuilt, force the issue

meta/recipes-devtools/libtool/libtool/avoid_absolute_paths_for_general_utils.patch new file +37 -0

new file mode 100644
index 0000000..519aebf
@@ -0,0 +1,37 @@
+On some distro the path of utils like sed, grep etc are different than the
+buildhost system.
+ This was causing runtime issue while running libtoolize from the 
+libtool-nativesdk package.
+  This patch takes out the absolute paths of these utils, and put 
+responsibility on the end-user to set correct paths for this utlities to be 
+found out.
+
+Nitin A Kamble <[email protected]>
+2011/02/18
+
+
+Index: libtool-2.4/libltdl/config/general.m4sh
+===================================================================
+--- libtool-2.4.orig/libltdl/config/general.m4sh	2010-08-31 23:02:45.000000000 -0700
++++ libtool-2.4/libltdl/config/general.m4sh	2011-02-18 09:59:09.482038240 -0800
+@@ -45,15 +45,15 @@
+ M4SH_VERBATIM([[
+ : ${CP="cp -f"}
+ test "${ECHO+set}" = set || ECHO=${as_echo-'printf %s\n'}
+-: ${EGREP="@EGREP@"}
+-: ${FGREP="@FGREP@"}
+-: ${GREP="@GREP@"}
+-: ${LN_S="@LN_S@"}
++: ${EGREP="egrep"}
++: ${FGREP="fgrep"}
++: ${GREP="grep"}
++: ${LN_S="ln -s"}
+ : ${MAKE="make"}
+ : ${MKDIR="mkdir"}
+ : ${MV="mv -f"}
+ : ${RM="rm -f"}
+-: ${SED="@SED@"}
++: ${SED="sed"}
+ : ${SHELL="${CONFIG_SHELL-/bin/sh}"}
+ : ${Xsed="$SED -e 1s/^X//"}
+

meta/recipes-devtools/libtool/libtool_2.4.bb +1 -1

index a820bed..e1a9a10 100644
@@ -1,6 +1,6 @@
 require libtool-${PV}.inc
 
-PR = "r1"
+PR = "r2"
 
 #
 # We want the results of libtool-cross preserved - don't stage anything ourselves.

Signature · 1 line

1.7.3.4

Scott Garman

Acked-by on the v1 series

2011-02-18 19:07 UTC #2 lore raw

In reply to Nitin A Kamble

Quoted 10 lines · Nitin A Kamble

From: Nitin A Kamble<[email protected]>
The builthost specific absolute pathnames were not working on other hosts with the nativesdk libtool package. This commit fixes that.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: nitin/misc
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Quoted 7 lines

Thanks,
Nitin A Kamble<[email protected]>
---
Nitin A Kamble (1):
libtool: avoid absolute pathnames of general utils

Acked-by Scott Garman <[email protected]>

Thanks Nitin!

Scott

Signature · 3 lines

Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center

Richard Purdie

Applied

2011-02-21 17:56 UTC #3 lore raw

In reply to Nitin A Kamble

Quoted 18 lines · Nitin A Kamble

From: Nitin A Kamble <[email protected]>
The builthost specific absolute pathnames were not working on other hosts with the nativesdk libtool package. This commit fixes that.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: nitin/misc
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Thanks,
Nitin A Kamble <[email protected]>
---
Nitin A Kamble (1):
libtool: avoid absolute pathnames of general utils

Quoted 8 lines

 meta/recipes-devtools/libtool/libtool-cross_2.4.bb |    2 +-
 .../recipes-devtools/libtool/libtool-native_2.4.bb |    2 +-
 .../libtool/libtool-nativesdk_2.4.bb               |    2 +-
 meta/recipes-devtools/libtool/libtool.inc          |    3 +-
 .../avoid_absolute_paths_for_general_utils.patch   |   37 ++++++++++++++++++++
 meta/recipes-devtools/libtool/libtool_2.4.bb       |    2 +-
 6 files changed, 43 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-devtools/libtool/libtool/avoid_absolute_paths_for_general_utils.patch

Merged to master, thanks.

Richard