Skip to contentSkip to conversation

rtc: rtc-mc13xxx: fix unterminated platform_device_id table

PATCH Applied Axel Lin 3 participants 4 messages Feb 23, 2011 – Feb 28, 2011

Subsystems (3)
Networking Network drivers Real time clock (RTC)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 rtc: rtc-mc13xxx: fix unterminated platform_device_id table

The platform_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/rtc/rtc-mc13xxx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/rtc/rtc-mc13xxx.c +1 -0
index 5314b15..6e6de98 100644
@@ -408,6 +408,7 @@ const struct platform_device_id mc13xxx_rtc_idtable[] = {
 	}, {
 		.name = "mc13892-rtc",
 	},
+	{ }
 };
 
 static struct platform_driver mc13xxx_rtc_driver = {
Signature · 1 line
1.7.2
author
#1 lore raw

PATCH 2/2 net/fec: fix unterminated platform_device_id table

The platform_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/net/fec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/net/fec.c +2 -1
index 74798be..f8a81ec 100644
@@ -74,7 +74,8 @@ static struct platform_device_id fec_devtype[] = {
 	}, {
 		.name = "imx28-fec",
 		.driver_data = FEC_QUIRK_ENET_MAC | FEC_QUIRK_SWAP_FRAME,
-	}
+	},
+	{ }
 };
 
 static unsigned char macaddr[ETH_ALEN];
Signature · 1 line
1.7.2
maintainer Applied
#2 lore raw

Re: [PATCH 2/2] net/fec: fix unterminated platform_device_id table

From: Axel Lin <[email protected]>
Date: Wed, 23 Feb 2011 17:28:46 +0800

Quoted 3 lines

The platform_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>

Applied, thanks.

Acked-by on v1 1/2
#3 lore raw
In reply to Axel Lin
Quoted 12 lines · Axel Lin

The platform_device_id table is supposed to be zero-terminated.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/rtc/rtc-mc13xxx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/rtc/rtc-mc13xxx.c +0 -0
index 5314b15..6e6de98 100644

drivers/rtc/rtc-mc13xxx.c const struct platform_device_id mc13xxx_rtc_idtable[] = { · line 412

Quoted 5 lines
drivers/rtc/rtc-mc13xxx.c +1 -0
@@ -408,6 +408,7 @@ const struct platform_device_id mc13xxx_rtc_idtable[] = {
 	}, {
 		.name = "mc13892-rtc",
 	},
+	{ }
 };
Acked-by Uwe Kleine-König <[email protected]>

for both patches. I wonder how that worked before, just luck I assume.

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |