Skip to contentSkip to conversation

x86: use int instead of long to set reset vector back to 0

PATCH New Don Zickus 1 participant 1 message Feb 23, 2011 x86

lore
Share & tools
lore

Don Zickus

author
#0 lore raw

PATCH 1/1 x86: use int instead of long to set reset vector back to 0

A customer of ours, complained that when setting the reset vector back to 0, it trashed other data and hung their box. They noticed when only 4 bytes were set to 0 instead of 8, everything worked correctly.

I don't know where to find this in the spec to know if this is correct, but looking at historical info of the code, x86_64 used to use 'int' here whereas i386 used to use 'long'. When they got merged it seemed like 'long' was used. So the change seems to make sense from that point of view.

I am hoping someone smarter than me can verify this.

---
Reposting this in case it was lost in the noise

---
 arch/x86/include/asm/smpboot_hooks.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/include/asm/smpboot_hooks.h +1 -1
index 6c22bf3..42d0366 100644
@@ -34,7 +34,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
 	 */
 	CMOS_WRITE(0, 0xf);
 
-	*((volatile long *)phys_to_virt(apic->trampoline_phys_low)) = 0;
+	*((volatile int *)phys_to_virt(apic->trampoline_phys_low)) = 0;
 }
 
 static inline void __init smpboot_setup_io_apic(void)
Signature · 1 line
1.7.3.5