Un-used DSS regulator data

Tomi/Sumit,

Today while building Tony's 'omap-for-linus' branch I came across below build warning.
warning: 'sdp3430_vdda_dac_supply' defined but not used

It seems the DSS regulator data is not being used. Are you missing any patch which will use it eventually?

If not I propose to remove that data to kill the warning. Below is the patch for the same. Also attached the same

Regards,
Santosh

From: Santosh Shilimkar <[email protected]>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning:
'sdp3430_vdda_dac_supply' defined but not used

The DSS regulator data not seems to be used. So remove the un-used sdp3430_vdda_dac_supply to avoid build warning

---
 arch/arm/mach-omap2/board-3430sdp.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

b/arch/arm/mach-omap2/board-3430sdp.c
index 8950ecc..19a36a3 100644

@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
 	.default_device	= &sdp3430_lcd_device,
 };
 
-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
-	REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
 static struct omap_board_config_kernel sdp3430_config[] __initdata = {
 };
 

1.6.0.4

From 037f1122d0bfe77883e6cf937009fd955be253a0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <[email protected]>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning: 'sdp3430_vdda_dac_supply' defined but not used

The DSS regulator data not seems to be used. So remove the un-used sdp3430_vdda_dac_supply to avoid build warning

---
 arch/arm/mach-omap2/board-3430sdp.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

index 8950ecc..19a36a3 100644
@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
 	.default_device	= &sdp3430_lcd_device,
 };
 
-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
-	REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
 static struct omap_board_config_kernel sdp3430_config[] __initdata = {
 };
 

1.6.0.4

Hi,

It was an accidental left over from conflict resolving. I have a patch in DSS tree which removes the regulator supply.

Tomi

Ok.