drm/i915: remove unused old i915_write()
Subsystems (2)
PATCH 1/2 drm/i915: remove unused old i915_write()
Signed-off-by Zhenyu Wang <[email protected]>
--- drivers/gpu/drm/i915/i915_drv.h | 21 --------------------- 1 files changed, 0 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +0 -21
@@ -1369,27 +1369,6 @@ static inline u32 i915_safe_read(struct drm_i915_private *dev_priv, u32 reg)return val; } -static inline void -i915_write (struct drm_i915_private *dev_priv,u32 reg,u64 val,int len) -{ -/* Trace down the write operation before the real write */ -trace_i915_reg_rw ('W' , reg, val, len); -switch (len) { -case 8 : -writeq (val, dev_priv->regs + reg); -break ; -case 4 : -writel (val, dev_priv->regs + reg); -break ; -case 2 : -writew (val, dev_priv->regs + reg); -break ; -case 1 : -writeb (val, dev_priv->regs + reg); -break ; - } -} -/** * Reads a dword out of the status page, which is written to from the command * queue by automatic updates, MI_REPORT_HEAD, MI_STORE_DATA_INDEX, or
Signature · 1 line
1.7.1
PATCH 2/2 drm/i915: Don't save/restore hardware status page address register
It's cleaned before saving and re-initialized after restoring. So don't need to save/restore it. And also new chip has new address for hardware status page register, don't write to old address.
Signed-off-by Zhenyu Wang <[email protected]>
--- drivers/gpu/drm/i915/i915_suspend.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_suspend.c +0 -6
@@ -797,9 +797,6 @@ int i915_save_state(struct drm_device *dev)pci_read_config_byte (dev->pdev,LBB , &dev_priv->saveLBB); -/* Hardware status page */ - dev_priv->saveHWS =I915_READ (HWS_PGA ); -i915_save_display (dev);/* Interrupt state */
@@ -846,9 +843,6 @@ int i915_restore_state(struct drm_device *dev)pci_write_config_byte (dev->pdev,LBB , dev_priv->saveLBB); -/* Hardware status page */ -I915_WRITE (HWS_PGA , dev_priv->saveHWS); -i915_restore_display (dev);/* Interrupt state */
Signature · 1 line
1.7.1
Chris Wilson
AppliedRe: [PATCH 2/2] drm/i915: Dont save/restore hardware status page address register
Quoted 3 lines · Zhenyu Wang
It's cleaned before saving and re-initialized after restoring. So don't need to save/restore it. And also new chip has new address for hardware status page register, don't write to old address.
Applied. (I had already completed the removal of the leftover i915_write()) -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre