OMAP3+: PM: introduce SR class 1.5
Subsystems (5)
v2 cover OMAP3+: PM: introduce SR class 1.5
Hi,
This series intends to introduce SmartReflex AVS Class 1.5 support which is now the recommended AVS class for usage in OMAP3630, OMAP4 and potentially in later generation of silicon as well. Smartreflex class 1.5 is a software controlled hardware calibration mechanism designed to improve dvfs latencies and system performance as well as helping bring in additional benefits to the system from h/w perspective. The corresponding patch has details on this class and the implementation as well.
The series eventually results in OMAP343x based platforms using class3 and OMAP3630, OMAP4 platforms using class1.5 automatically without modifications or additions to board files.
This series is Based on:
a) k.org 2.6.38-rc7 (b2.6.38-rc7)
b) The following branches Kevin Hilman's tree: (pm-base-v2) 'pm/for_2.6.38/pm-fixes', 'pm/for_2.6.39/pm-misc' and 'pm/pm-wip/cpufreq'
http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary
Rationale: there are some sr-cleanups done here which makes at least 1 patch create a minor conflict (kasprintf for sr name), but should reasonably apply to k.org as well, and since this series is targeted for 39-rc1, builds on previously accepted patches.
Some good fixes needed are here (optional):
c) sr-fixes: (sr-baseline-v2)
http://marc.info/?l=linux-omap&m=129783708019505&w=2 http://marc.info/?l=linux-omap&m=129679846322563&w=2
Other interesting series:
i) http://marc.info/?t=129825445100003&r=1&w=2 cleanups of voltage.c
- rebase should be minor effort
ii) http://marc.info/?l=linux-omap&m=129783700319445&w=2 fixes for omap4
- might conflict on macro cleanup with (i)
- should not conflict with the current series.
This series is also available at:
git://gitorious.org/linux-omap-nm-sr/linux-omap-sr.git Branch: sr-1.5-v2
Note: There is also a branch dvfs-test-v2 in my tree which contains the test version of code for OMAP3 based on Vishwa's DVFS series which is currently being revamped. if run on OMAP4, it just throws up a bit of warnings, but wont crash.
The series contains a bunch of bugfixes and improvements needed to introduce Smartreflex class 1.5.
Changes in v2 since v1:
* I dropped patch 2/19 for 3630 ES revision, based on the discussion in:
http://marc.info/?t=129811710300003&r=1&w=2
NOTE: 3630 ES revision fixes need to be cleanly done at a later point, and there is not much use doing a temporary hackup job just for SR. Since it ain't broke atm for higher ES revs for SR, I will leave it alone.
* Fixed the bug exposed by bootloaders which setup an OPP which is not enabled in kernel http://marc.info/?t=129811710500010&r=1&w=2
- parameter checks were necessary, impacted patches 5 and 17
* Documentation update following the explanation required for
http://marc.info/?t=129811710300007&r=1&w=2 for patch 5
- example provided in the discussion is useful for reviewer perspective in commit message
Comments not incorporated from v1:
* http://marc.info/?t=129811710500007&r=1&w=2 - there is no reason to allow sr notifiers after class has been deinitialized, so not allowing it.
* http://marc.info/?t=129811710300004&r=1&w=2 - the omap2_init_voltage fix is not the intent of this series. infact handling of mpurate and omap2_init_voltage needs to be merged in at some future point of time.
v1: http://marc.info/?l=linux-omap&m=129811693118173&w=2
Nishanth Menon (18):
omap3: hwmod: add smartreflex irqs
omap3+: voltage: remove initial voltage omap3+: voltage: remove spurious pr_notice for debugfs omap3+: voltage: use IS_ERR_OR_NULL
omap3+: voltage: use volt_data pointer instead values omap3+: voltage: add transdone apis
omap3+: sr: make notify independent of class omap3+: sr: introduce class init,deinit and priv data omap3+: sr: fix cosmetic indentation
omap3+: sr: call handler with interrupt disabled omap3+: sr: disable interrupt by default omap3+: sr: enable/disable SR only on need omap3+: sr: introduce notifiers flags
omap3+: sr: introduce notifier_control omap3+: sr: disable spamming interrupts omap3+: sr: make enable path use volt_data pointer omap3630+: sr: add support for class 1.5
omap3430: sr: class3: restrict cpu to run on
arch/arm/mach-omap2/Makefile | 1 + arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 17 + arch/arm/mach-omap2/pm.c | 3 +- arch/arm/mach-omap2/smartreflex-class1p5.c | 582 +++++++++++++++++++++++++ arch/arm/mach-omap2/smartreflex-class3.c | 21 +- arch/arm/mach-omap2/smartreflex.c | 249 +++++++++-- arch/arm/mach-omap2/voltage.c | 251 ++++++++--- arch/arm/plat-omap/Kconfig | 17 + arch/arm/plat-omap/include/plat/smartreflex.h | 42 ++- arch/arm/plat-omap/include/plat/voltage.h | 36 ++- 10 files changed, 1097 insertions(+), 122 deletions(-) create mode 100644 arch/arm/mach-omap2/smartreflex-class1p5.c
Testing performed:
Testing with dvfs-test-v2 - http://pastebin.mozilla.org/1117872
- transitions from all opps to all other opps,sr enabled, disable
- platforms: SDP3430(OMAP3430), SDP3630(OMAP3630)
(note: dvfs series does'nt support OMAP4 yet)
Testing with sr-1.5-v2 - http://pastebin.mozilla.org/1117880
- enable disable in domain combinations, test the new debugfs entries etc..
- platforms: SDP3430(OMAP3430), SDP3630(OMAP3630), PandaBoard(OMAP4430)
Regards,
Nishanth Menon
PATCH v2 1/18 omap3: hwmod: add smartreflex irqs
OMAP3 smartreflex irqs in hwmod structures with the same naming as present in OMAP4. Without these IRQs being registered, SmartReflex driver will be unable to get the irq numbers to handle notifications
--- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +17 -0
@@ -265,6 +265,15 @@ static struct omap_hwmod_ocp_if omap3_l4_core__i2c3 = { .user = OCP_USER_MPU | OCP_USER_SDMA, }; + +static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { + {.name ="sr1_irq" , .irq =18 }, +}; + +static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { + {.name ="sr2_irq" , .irq =19 }, +}; +/* L4 CORE -> SR1 interface */ static struct omap_hwmod_addr_space omap3_sr1_addr_space[] = { {
@@ -1289,6 +1298,8 @@ static struct omap_hwmod omap34xx_sr1_hwmod = {CHIP_IS_OMAP3430ES3_0 | CHIP_IS_OMAP3430ES3_1), .flags = HWMOD_SET_DEFAULT_CLOCKACT, + .mpu_irqs = omap3_smartreflex_mpu_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(omap3_smartreflex_mpu_irqs), };static struct omap_hwmod omap36xx_sr1_hwmod = {
@@ -1308,6 +1319,8 @@ static struct omap_hwmod omap36xx_sr1_hwmod = { .slaves = omap3_sr1_slaves, .slaves_cnt = ARRAY_SIZE(omap3_sr1_slaves), .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3630ES1), + .mpu_irqs = omap3_smartreflex_mpu_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(omap3_smartreflex_mpu_irqs), };/* SR2 */
@@ -1335,6 +1348,8 @@ static struct omap_hwmod omap34xx_sr2_hwmod = {CHIP_IS_OMAP3430ES3_0 | CHIP_IS_OMAP3430ES3_1), .flags = HWMOD_SET_DEFAULT_CLOCKACT, + .mpu_irqs = omap3_smartreflex_core_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(omap3_smartreflex_core_irqs), };static struct omap_hwmod omap36xx_sr2_hwmod = {
@@ -1354,6 +1369,8 @@ static struct omap_hwmod omap36xx_sr2_hwmod = { .slaves = omap3_sr2_slaves, .slaves_cnt = ARRAY_SIZE(omap3_sr2_slaves), .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3630ES1), + .mpu_irqs = omap3_smartreflex_core_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(omap3_smartreflex_core_irqs), };static __initdata struct omap_hwmod *omap3xxx_hwmods[] = {
Signature · 1 line
1.7.1
PATCH v2 2/18 omap3+: voltage: remove initial voltage
In reply to Nishanth Menonomap2_set_init_voltage should setup the curr_volt based on which OPP the system is functioning at. Blindly setting a 1.2v setting in the initial structure may not even match the default voltages stored in the voltage table which are supported for the domain.
For example, OMAP3430 core domain does not use 1.2v and ends up generating a warning on the first transition.
--- arch/arm/mach-omap2/voltage.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/voltage.c +0 -2
@@ -863,7 +863,6 @@ static int __init omap3_vdd_data_configure(struct omap_vdd_info *vdd) sys_clk_speed /=1000 ;/* Generic voltage parameters */ - vdd->curr_volt =1200000 ; vdd->ocp_mod =OCP_MOD ; vdd->prm_irqst_reg =OMAP3_PRM_IRQSTATUS_MPU_OFFSET ; vdd->read_reg = omap3_voltage_read_reg;
@@ -1054,7 +1053,6 @@ static int __init omap4_vdd_data_configure(struct omap_vdd_info *vdd) sys_clk_speed /=1000 ;/* Generic voltage parameters */ - vdd->curr_volt =1200000 ; vdd->ocp_mod =OMAP4430_PRM_OCP_SOCKET_INST ; vdd->read_reg = omap4_voltage_read_reg; vdd->write_reg = omap4_voltage_write_reg;
Signature · 1 line
1.7.1
PATCH v2 3/18 omap3+: voltage: remove spurious pr_notice for debugfs
In reply to Nishanth Menoncat of debugfs entry for vp_volt provides voltage. The additional pr_notice is just spam on console and provides no additional information.
--- arch/arm/mach-omap2/voltage.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/voltage.c +0 -1
@@ -347,7 +347,6 @@ static int vp_volt_debug_get(void *data, u64 *val) } vsel = vdd->read_reg (vdd->vp_reg.prm_mod, vdd->vp_offs.voltage); -pr_notice ("curr_vsel = %x\n" , vsel);if (!vdd->pmic_info->vsel_to_uv) { pr_warning("PMIC function to convert vsel to voltage"
Signature · 1 line
1.7.1
PATCH v2 4/18 omap3+: voltage: use IS_ERR_OR_NULL
In reply to Nishanth MenonUse IS_ERR_OR_NULL macro instead of just IS_ERR or !xyz || IS_ERR(xyz) style usage.
--- arch/arm/mach-omap2/voltage.c | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-)
arch/arm/mach-omap2/voltage.c +14 -14
@@ -471,7 +471,7 @@ static void __init vdd_debugfs_init(struct omap_vdd_info *vdd) vdd->debug_dir =debugfs_create_dir (name, voltage_dir);kfree (name); -if (IS_ERR (vdd->debug_dir)) { +if (IS_ERR_OR_NULL (vdd->debug_dir)) {pr_warning ("%s: Unable to create debugfs directory for" " vdd_%s\n" , __func__, vdd->voltdm.name); vdd->debug_dir =NULL ;
@@ -851,7 +851,7 @@ static int __init omap3_vdd_data_configure(struct omap_vdd_info *vdd)* smpswaittimemin and smpswaittimemax. */ sys_ck =clk_get (NULL ,"sys_ck" ); -if (IS_ERR (sys_ck)) { +if (IS_ERR_OR_NULL (sys_ck)) {pr_warning ("%s: Could not get the sys clk to calculate" "various vdd_%s params\n" , __func__, vdd->voltdm.name);return -EINVAL ;
@@ -1041,7 +1041,7 @@ static int __init omap4_vdd_data_configure(struct omap_vdd_info *vdd)* smpswaittimemin and smpswaittimemax. */ sys_ck =clk_get (NULL ,"sys_clkin_ck" ); -if (IS_ERR (sys_ck)) { +if (IS_ERR_OR_NULL (sys_ck)) {pr_warning ("%s: Could not get the sys clk to calculate" "various vdd_%s params\n" , __func__, vdd->voltdm.name);return -EINVAL ;
@@ -1125,7 +1125,7 @@ unsigned long omap_voltage_get_nom_volt(struct voltagedomain *voltdm) {struct omap_vdd_info *vdd; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return 0 ; }
@@ -1146,7 +1146,7 @@ unsigned long omap_vp_get_curr_volt(struct voltagedomain *voltdm)struct omap_vdd_info *vdd;u8 curr_vsel; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return 0 ; }
@@ -1183,7 +1183,7 @@ void omap_vp_enable(struct voltagedomain *voltdm)u32 vpconfig;u16 mod; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ; }
@@ -1224,7 +1224,7 @@ void omap_vp_disable(struct voltagedomain *voltdm)u16 mod;int timeout; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ; }
@@ -1308,7 +1308,7 @@ void omap_voltage_reset(struct voltagedomain *voltdm) {unsigned long target_uvdc; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ; }
@@ -1340,7 +1340,7 @@ void omap_voltage_get_volttable(struct voltagedomain *voltdm, {struct omap_vdd_info *vdd; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ; }
@@ -1371,7 +1371,7 @@ struct omap_volt_data *omap_voltage_get_voltdata(struct voltagedomain *voltdm,struct omap_vdd_info *vdd;int i; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ERR_PTR (-EINVAL ); }
@@ -1409,7 +1409,7 @@ int omap_voltage_register_pmic(struct voltagedomain *voltdm, {struct omap_vdd_info *vdd; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return -EINVAL ; }
@@ -1436,7 +1436,7 @@ struct dentry *omap_voltage_get_dbgdir(struct voltagedomain *voltdm) {struct omap_vdd_info *vdd; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return NULL ; }
@@ -1461,7 +1461,7 @@ void omap_change_voltscale_method(struct voltagedomain *voltdm, {struct omap_vdd_info *vdd; -if (!voltdm ||IS_ERR (voltdm)) { +if (IS_ERR_OR_NULL (voltdm)) {pr_warning ("%s: VDD specified does not exist!\n" , __func__);return ; }
@@ -1531,7 +1531,7 @@ int __init omap_voltage_late_init(void) } voltage_dir =debugfs_create_dir ("voltage" ,NULL ); -if (IS_ERR (voltage_dir)) +if (IS_ERR_OR_NULL (voltage_dir))pr_err ("%s: Unable to create voltage debugfs main dir\n" , __func__);for (i =0 ; i < nr_scalable_vdd; i++) {
Signature · 1 line
1.7.1
PATCH v2 5/18 omap3+: voltage: use volt_data pointer instead values
In reply to Nishanth MenonVoltage values can get confusing in meaning with various Smartreflex classes being active. Depending on the class used, the actual voltage selected might be a variant. For example:
with SmartReflex AVS class 3:
a) if we dont have SR enabled, we will go to volt_nominal
b) if have SR enabled, we go to volt_nominal, then enable SR and expect it to adjust voltage. We dont really care about the resultant voltage
Essentially, when we ask voltage layer to scale to voltage x for OPP y, it always means x is the nominal voltage for OPP y.
Now, once we introduce SmartReflex AVS class 1.5:
a) If you are booting for the first time OR if you never enable SR before, we always go to volt_nominal
b) If you enable SR and the OPP is calibrated, we will not enable SR again when that OPP is accessed anymore, but when we set voltage for an OPP, the voltage achieved will be volt_calibrated
c) If recalibration timeout triggers,or SR is disabled after a calibration, the calibrated values are not valid anymore, at this point, setting the voltage will mean volt_dynamic_nominal.
So, depending on which state the system is at, voltage for that OPP we are setting has not 1 single value anymore, but 3 possible valid values.
For upper layers(dvfs/cpufreq OMAP SoC layers) to use voltage values, it will need to know which type of voltage AVS strategy is being used and the corresponding system state from voltage layer perspective. This would replicate the role of voltage layer, SmartReflex AVS in the upper layers and make the corresponding implementations complex.
Since each voltage domain contains a set of volt_data structs representing a voltage point that is supported for that domain, volt_data is a more accurate representation of the voltage point we are interested in going to, and the actual translation of this voltage point to the voltage value is done inside the voltage layer. Doing this allows the users of the voltage layer to be blissfully ignorant of any complexity of the underneath layers and simplify the implementation of dependent layers.
--- arch/arm/mach-omap2/pm.c | 3 +- arch/arm/mach-omap2/smartreflex-class3.c | 3 +- arch/arm/mach-omap2/voltage.c | 77 ++++++++++++++++------------- arch/arm/plat-omap/include/plat/voltage.h | 13 ++++- 4 files changed, 58 insertions(+), 38 deletions(-)
arch/arm/mach-omap2/pm.c +2 -1
@@ -209,7 +209,8 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, goto exit; } -omap_voltage_scale_vdd (voltdm, bootup_volt); +omap_voltage_scale_vdd (voltdm, +omap_voltage_get_voltdata (voltdm, bootup_volt));return 0 ; exit:
arch/arm/mach-omap2/smartreflex-class3.c +2 -1
@@ -15,7 +15,8 @@static int sr_class3_enable (struct voltagedomain *voltdm) { -unsigned long volt =omap_voltage_get_nom_volt (voltdm); +unsigned long volt =omap_get_operation_voltage ( +omap_voltage_get_nom_volt (voltdm));if (!volt) { pr_warning("%s: Curr voltage unknown. Cannot enable sr_%s\n",
arch/arm/mach-omap2/voltage.c +43 -34
178 lines not on this page · raw message
arch/arm/plat-omap/include/plat/voltage.h +11 -2
@@ -117,13 +117,13 @@ unsigned long omap_vp_get_curr_volt(struct voltagedomain *voltdm);void omap_vp_enable (struct voltagedomain *voltdm);void omap_vp_disable (struct voltagedomain *voltdm);int omap_voltage_scale_vdd (struct voltagedomain *voltdm, -unsigned long target_volt); +struct omap_volt_data *target_volt);void omap_voltage_reset (struct voltagedomain *voltdm);void omap_voltage_get_volttable (struct voltagedomain *voltdm,struct omap_volt_data **volt_data);struct omap_volt_data *omap_voltage_get_voltdata (struct voltagedomain *voltdm,unsigned long volt); -unsigned long omap_voltage_get_nom_volt (struct voltagedomain *voltdm); +struct omap_volt_data *omap_voltage_get_nom_volt (struct voltagedomain *voltdm);struct dentry *omap_voltage_get_dbgdir (struct voltagedomain *voltdm);#ifdef CONFIG_PM int omap_voltage_register_pmic(struct voltagedomain *voltdm,
@@ -152,4 +152,13 @@ static inline struct voltagedomain *omap_voltage_domain_lookup(char *name) }#endif +/* convert volt data to the voltage for the voltage data */ +static inline unsigned long omap_get_operation_voltage ( +struct omap_volt_data *vdata) +{ +if (IS_ERR_OR_NULL (vdata)) +return 0 ; +return vdata->volt_nominal; +} +#endif
Signature · 1 line
1.7.1
PATCH v2 6/18 omap3+: voltage: add transdone apis
In reply to Nishanth MenonTransdone event in Voltage processor gives us fine grained status on the current status of the voltage communication with the PMIC. Unfortunately, irq generation by VP is based on the start of the transmission to VC from VP, not at the end (or the completion of the voltage setting). Hence any users of voltage layer who need to know fine grained information such as confirmation if the voltage is actually send to PMIC, needs to depend on this status.
--- arch/arm/mach-omap2/voltage.c | 64 ++++++++++++++++++++++------- arch/arm/plat-omap/include/plat/voltage.h | 2 + 2 files changed, 51 insertions(+), 15 deletions(-)
arch/arm/mach-omap2/voltage.c +49 -15
@@ -644,8 +644,8 @@ static int vp_forceupdate_scale_voltage(struct omap_vdd_info *vdd, struct omap_volt_data *target_volt) {u32 vpconfig; -u16 mod, ocp_mod; -u8 target_vsel, current_vsel, prm_irqst_reg; +u16 mod; +u8 target_vsel, current_vsel;int ret, timeout =0 ; ret =_pre_volt_scale (vdd, target_volt, &target_vsel, ¤t_vsel);
@@ -653,18 +653,13 @@ static int vp_forceupdate_scale_voltage(struct omap_vdd_info *vdd,return ret; mod = vdd->vp_reg.prm_mod; - ocp_mod = vdd->ocp_mod; - prm_irqst_reg = vdd->prm_irqst_reg; -/* * Clear all pending TransactionDone interrupt/status. Typical latency * is <3us */ while (timeout++ <VP_TRANXDONE_TIMEOUT ) { - vdd->write_reg (vdd->vp_reg.tranxdone_status, - ocp_mod, prm_irqst_reg); -if (!(vdd->read_reg (ocp_mod, prm_irqst_reg) & - vdd->vp_reg.tranxdone_status)) +omap_vp_clear_transdone (&vdd->voltdm); +if (!omap_vp_is_transdone (&vdd->voltdm))break ;udelay (1 ); }
@@ -696,7 +691,7 @@ static int vp_forceupdate_scale_voltage(struct omap_vdd_info *vdd,* Depends on SMPSWAITTIMEMIN/MAX and voltage change */ timeout =0 ; -omap_test_timeout ((vdd->read_reg (ocp_mod, prm_irqst_reg) & +omap_test_timeout ((vdd->read_reg (vdd->ocp_mod, vdd->prm_irqst_reg) & vdd->vp_reg.tranxdone_status),VP_TRANXDONE_TIMEOUT , timeout);if (timeout >=VP_TRANXDONE_TIMEOUT )
@@ -712,11 +707,9 @@ static int vp_forceupdate_scale_voltage(struct omap_vdd_info *vdd,*/ timeout =0 ;while (timeout++ <VP_TRANXDONE_TIMEOUT ) { - vdd->write_reg (vdd->vp_reg.tranxdone_status, - ocp_mod, prm_irqst_reg); -if (!(vdd->read_reg (ocp_mod, prm_irqst_reg) & - vdd->vp_reg.tranxdone_status)) -break ; +omap_vp_clear_transdone (&vdd->voltdm); +if (!omap_vp_is_transdone (&vdd->voltdm)) +break ;udelay (1 ); }
@@ -1274,6 +1267,47 @@ void omap_vp_disable(struct voltagedomain *voltdm) }/** +* omap_vp_is_transdone() - is voltage transfer done on vp? +* @voltdm: pointer to the VDD which is to be scaled. +* +* VP's transdone bit is the only way to ensure that the transfer +* of the voltage value has actually been send over to the PMIC +* This is hence useful for all users of voltage domain to precisely +* identify once the PMIC voltage has been set by the voltage processor +*/ +bool omap_vp_is_transdone (struct voltagedomain *voltdm) +{ +struct omap_vdd_info *vdd; + +if (IS_ERR_OR_NULL (voltdm)) { +pr_warning ("%s: Bad Params vdm=%p\n" , __func__, voltdm); +return false; + } + + vdd = container_of(voltdm, struct omap_vdd_info, voltdm); +return (vdd->read_reg (vdd->ocp_mod, vdd->prm_irqst_reg) & + vdd->vp_reg.tranxdone_status) ? true : false; +} + +/** +* omap_vp_clear_transdone() - clear voltage transfer done status on vp +* @voltdm: pointer to the VDD which is to be scaled. +*/ +bool omap_vp_clear_transdone (struct voltagedomain *voltdm) +{ +struct omap_vdd_info *vdd; + +if (IS_ERR_OR_NULL (voltdm)) { +pr_warning ("%s: Bad Params vdm=%p\n" , __func__, voltdm); +return false; + } + + vdd = container_of(voltdm, struct omap_vdd_info, voltdm); + vdd->write_reg (vdd->vp_reg.tranxdone_status, + vdd->ocp_mod, vdd->prm_irqst_reg); +return true; +} +/** * omap_voltage_scale_vdd() - API to scale voltage of a particular * voltage domain. * @voltdm: pointer to the VDD which is to be scaled.
arch/arm/plat-omap/include/plat/voltage.h +2 -0
@@ -124,6 +124,8 @@ void omap_voltage_get_volttable(struct voltagedomain *voltdm,struct omap_volt_data *omap_voltage_get_voltdata (struct voltagedomain *voltdm,unsigned long volt);struct omap_volt_data *omap_voltage_get_nom_volt (struct voltagedomain *voltdm); +bool omap_vp_is_transdone (struct voltagedomain *voltdm); +bool omap_vp_clear_transdone (struct voltagedomain *voltdm);struct dentry *omap_voltage_get_dbgdir (struct voltagedomain *voltdm);#ifdef CONFIG_PM int omap_voltage_register_pmic(struct voltagedomain *voltdm,
Signature · 1 line
1.7.1
PATCH v2 7/18 omap3+: sr: make notify independent of class
In reply to Nishanth MenonInterrupt notification mechanism of SmartReflex can be used by the choice of implementation of the class driver. For example, Class 2 and Class 1.5 of SmartReflex can both use the interrupt notification to identify the transition of voltage or other events.
Hence, the actual class does not matter for notifier. Let the class driver's handling decide how it should be used. smartreflex driver should provide just the primitives.
--- arch/arm/mach-omap2/smartreflex.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/smartreflex.c +2 -4
@@ -142,7 +142,7 @@ static irqreturn_t sr_interrupt(int irq, void *data)sr_write_reg (sr_info,IRQSTATUS , status); } -if (sr_class->class_type ==SR_CLASS2 && sr_class->notify) +if (sr_class->notify) sr_class->notify (sr_info->voltdm, status);return IRQ_HANDLED ;
@@ -257,9 +257,7 @@ static int sr_late_init(struct omap_sr *sr_info)struct resource *mem;int ret =0 ; -if (sr_class->class_type ==SR_CLASS2 && - sr_class->notify_flags && sr_info->irq) { - +if (sr_class->notify && sr_class->notify_flags && sr_info->irq) { name =kasprintf (GFP_KERNEL ,"sr_%s" , sr_info->voltdm->name);if (name ==NULL ) { ret = -ENOMEM ;
Signature · 1 line
1.7.1
PATCH v2 8/18 omap3+: sr: introduce class init, deinit and priv data
In reply to Nishanth MenonCertain class drivers such as class 1.5 drivers, will need specific notification that they have to be started up or stopped independent of smart reflex operation. They also may need private data to be used for operations of their own, provide the same.
--- arch/arm/mach-omap2/smartreflex.c | 14 ++++++++++++++ arch/arm/plat-omap/include/plat/smartreflex.h | 7 +++++++ 2 files changed, 21 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/smartreflex.c +14 -0
@@ -220,6 +220,13 @@ static void sr_start_vddautocomp(struct omap_sr *sr)return ; } +if (sr_class->class_init && + sr_class->class_init (sr->voltdm, sr_class->class_priv_data)) { +dev_err (&sr->pdev->dev, +"%s: SRClass initialization failed\n" , __func__); +return ; + } +if (!sr_class->enable (sr->voltdm)) sr->autocomp_active = true; }
@@ -235,6 +242,13 @@ static void sr_stop_vddautocomp(struct omap_sr *sr)if (sr->autocomp_active) { sr_class->disable (sr->voltdm,1 ); +if (sr_class->class_deinit && + sr_class->class_deinit (sr->voltdm, + sr_class->class_priv_data)) { +dev_err (&sr->pdev->dev, +"%s: SR[%d]Class deinitialization failed\n" , + __func__, sr->srid); + } sr->autocomp_active = false; } }
arch/arm/plat-omap/include/plat/smartreflex.h +7 -0
@@ -167,6 +167,8 @@ struct omap_sr_pmic_data {* * @enable: API to enable a particular class smaartreflex. * @disable: API to disable a particular class smartreflex. +* @class_init: API to do class specific initialization (optional) +* @class_deinit: API to do class specific initialization (optional) * @configure: API to configure a particular class smartreflex. * @notify: API to notify the class driver about an event in SR. * Not needed for class3.
@@ -174,14 +176,19 @@ struct omap_sr_pmic_data {* @class_type: specify which smartreflex class. * Can be used by the SR driver to take any class * based decisions. +* @class_priv_data: Class specific private data (optional) */ struct omap_sr_class_data {int (*enable)(struct voltagedomain *voltdm);int (*disable)(struct voltagedomain *voltdm,int is_volt_reset); +int (*class_init)(struct voltagedomain *voltdm,void *class_priv_data); +int (*class_deinit)(struct voltagedomain *voltdm, +void *class_priv_data);int (*configure)(struct voltagedomain *voltdm);int (*notify)(struct voltagedomain *voltdm,u32 status);u8 notify_flags;u8 class_type; +void *class_priv_data; };/**
Signature · 1 line
1.7.1
PATCH v2 9/18 omap3+: sr: fix cosmetic indentation
In reply to Nishanth MenonError label case seems to have a 2 tab indentation when just 1 is necessary.
--- arch/arm/mach-omap2/smartreflex.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)
arch/arm/mach-omap2/smartreflex.c +9 -9
@@ -289,15 +289,15 @@ static int sr_late_init(struct omap_sr *sr_info)return ret; error: -iounmap (sr_info->base); - mem =platform_get_resource (sr_info->pdev,IORESOURCE_MEM ,0 ); -release_mem_region (mem->start,resource_size (mem)); -list_del (&sr_info->node); -dev_err (&sr_info->pdev->dev,"%s: ERROR in registering" -"interrupt handler. Smartreflex will" -"not function as desired\n" , __func__); -kfree (sr_info); -return ret; +iounmap (sr_info->base); + mem =platform_get_resource (sr_info->pdev,IORESOURCE_MEM ,0 ); +release_mem_region (mem->start,resource_size (mem)); +list_del (&sr_info->node); +dev_err (&sr_info->pdev->dev,"%s: ERROR in registering" +"interrupt handler. Smartreflex will" +"not function as desired\n" , __func__); +kfree (sr_info); +return ret; }static void sr_v1_disable (struct omap_sr *sr)
Signature · 1 line
1.7.1
PATCH v2 10/18 omap3+: sr: call handler with interrupt disabled
In reply to Nishanth MenonRequest the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events.
--- arch/arm/mach-omap2/smartreflex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/smartreflex.c +1 -1
@@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info) goto error; } ret =request_irq (sr_info->irq, sr_interrupt, -0 , name, (void *)sr_info); +IRQF_DISABLED , name, (void *)sr_info);if (ret) goto error; }
Signature · 1 line
1.7.1
PATCH v2 10/18 omap3+: sr: call handler with interrupt disabled
Hello.
Quoted 15 lines · Nishanth Menon
Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events.
Signed-off-by Nishanth Menon<[email protected]>--- arch/arm/mach-omap2/smartreflex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-omap2/smartreflex.c +0
-0
arch/arm/mach-omap2/smartreflex.c static int sr_late_init(struct omap_sr *sr_info) · line 281
Quoted 5 lines
arch/arm/mach-omap2/smartreflex.c +1
-1@@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info) goto error; } ret =request_irq (sr_info->irq, sr_interrupt, -0 , name, (void *)sr_info); +IRQF_DISABLED , name, (void *)sr_info);
Isn't this flag a nop now?
WBR, Sergei
PATCH v2 10/18 omap3+: sr: call handler with interrupt disabled
Sergei Shtylyov wrote, on 03/02/2011 07:08 PM:
Quoted 14 lines
Hello.
Quoted 9 lines · Nishanth Menon
Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events.
Signed-off-by Nishanth Menon<[email protected]>---
arch/arm/mach-omap2/smartreflex.c| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 13 lines
arch/arm/mach-omap2/smartreflex.c static int sr_late_init(struct omap_sr *sr_info) · line 281
Quoted 11 lines
arch/arm/mach-omap2/smartreflex.c +1
-1@@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info) goto error; } ret =request_irq (sr_info->irq, sr_interrupt, -0 , name, (void *)sr_info); +IRQF_DISABLED , name, (void *)sr_info);Isn't this flag a nop now?
thanks. hmm...Documentation/feature-removal-schedule.txt says so as well.. I guess I was just being paranoid (again?).
Signature · 2 lines
Regards, Nishanth Menon
PATCH v2 10/18 omap3+: sr: call handler with interrupt disabled
In reply to Sergei ShtylyovQuoted 10 lines · I wrote:
Quoted 9 lines
Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events.
Signed-off-by Nishanth Menon<[email protected]>--- arch/arm/mach-omap2/smartreflex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 13 lines
arch/arm/mach-omap2/smartreflex.c static int sr_late_init(struct omap_sr *sr_info) · line 281
Quoted 11 lines
arch/arm/mach-omap2/smartreflex.c +1
-1@@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info) goto error; } ret =request_irq (sr_info->irq, sr_interrupt, -0 , name, (void *)sr_info); +IRQF_DISABLED , name, (void *)sr_info);Isn't this flag a nop now?
Indeed, it is, according to the comment in <linux/interrupt.h>. So what does
this patch really achieve?
WBR, Sergei
PATCH v2 10/18 omap3+: sr: call handler with interrupt disabled
Sergei Shtylyov wrote, on 03/02/2011 11:09 PM:
Quoted 26 lines
Quoted 10 lines · I wrote:
Quoted 9 lines
Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events.
Signed-off-by Nishanth Menon<[email protected]>---
arch/arm/mach-omap2/smartreflex.c| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)Quoted 13 lines
arch/arm/mach-omap2/smartreflex.c static int sr_late_init(struct omap_sr *sr_info) · line 281
Quoted 11 lines
arch/arm/mach-omap2/smartreflex.c +1
-1@@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info) goto error; } ret =request_irq (sr_info->irq, sr_interrupt, -0 , name, (void *)sr_info); +IRQF_DISABLED , name, (void *)sr_info);Isn't this flag a nop now?
Quoted 2 lines
Indeed, it is, according to the comment in <
linux/interrupt.h>. So what does this patch really achieve?
Carry over since I had implemented this driver originally on an ancient kernel and other than the showing off the obvious fact that I am not reading lwn.net enough, I dont think it achieved anything much :(
The original intent was as following: since bootloaders may have used the same h/w logic which could generate pending interrupt status, I wanted to explicitly flag that requesting the irq should also ensure the IRQ is in disabled status before I get a chance to clean things up.
Signature · 2 lines
Regards, Nishanth Menon
PATCH v2 11/18 omap3+: sr: disable interrupt by default
In reply to Nishanth MenonWe will enable and disable interrupt on a need basis in the class driver. we need to keep the irq disabled by default else the forceupdate or vcbypass events could trigger events that we dont need/expect to handle.
--- arch/arm/mach-omap2/smartreflex.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/smartreflex.c +1 -0
@@ -281,6 +281,7 @@ static int sr_late_init(struct omap_sr *sr_info) IRQF_DISABLED, name, (void *)sr_info);if (ret) goto error; +disable_irq (sr_info->irq); }if (pdata && pdata->enable_on_init)
Signature · 1 line
1.7.1
PATCH v2 12/18 omap3+: sr: enable/disable SR only on need
In reply to Nishanth MenonSince we already know the state of the autocomp enablement, we can see if the requested state is different from the current state and enable/disable SR only on the need basis.
--- arch/arm/mach-omap2/smartreflex.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/smartreflex.c +7 -4
@@ -819,10 +819,13 @@ static int omap_sr_autocomp_store(void *data, u64 val)return -EINVAL ; } -if (!val) -sr_stop_vddautocomp (sr_info); -else -sr_start_vddautocomp (sr_info); +/* control enable/disable only if there is a delta in value */ +if (sr_info->autocomp_active ^ val) { +if (!val) +sr_stop_vddautocomp (sr_info); +else +sr_start_vddautocomp (sr_info); + }return 0 ; }
Signature · 1 line
1.7.1
PATCH v2 13/18 omap3+: sr: introduce notifiers flags
In reply to Nishanth MenonSmartReflex IP v1 and v2 have different registers and offsets. Currently, we pass the status as is to the class driver. However, since we dont pass the version of the underlying SR hardware to the Class driver, it will not be unable to make consistent sense of the status bits coming over to it.
A class driver should be able to function without dependency on the exact IP version it is actually running on. We hence introduce our own translation in s/w level for a generic notification flag.
As part of this change, we will now call the notifier iff we get a match with the notifier flags that the class driver requested.
--- arch/arm/mach-omap2/smartreflex.c | 73 ++++++++++++++++++++++++- arch/arm/plat-omap/include/plat/smartreflex.h | 6 ++ 2 files changed, 76 insertions(+), 3 deletions(-)
arch/arm/mach-omap2/smartreflex.c +70 -3
@@ -123,27 +123,94 @@ static struct omap_sr *_sr_lookup(struct voltagedomain *voltdm)return ERR_PTR (-ENODATA ); } +static inline u32 notifier_to_irqen_v1 (u8 notify_flags) +{ +u32 val; + val = (notify_flags &SR_NOTIFY_MCUACCUM ) ? +ERRCONFIG_MCUACCUMINTEN :0 ; + val |= (notify_flags &SR_NOTIFY_MCUVALID ) ? +ERRCONFIG_MCUVALIDINTEN :0 ; + val |= (notify_flags &SR_NOTIFY_MCUBOUND ) ? +ERRCONFIG_MCUBOUNDINTEN :0 ; + val |= (notify_flags &SR_NOTIFY_MCUDISACK ) ? +ERRCONFIG_MCUDISACKINTEN :0 ; +return val; +} + +static inline u32 notifier_to_irqen_v2 (u8 notify_flags) +{ +u32 val; + val = (notify_flags &SR_NOTIFY_MCUACCUM ) ? +IRQENABLE_MCUACCUMINT :0 ; + val |= (notify_flags &SR_NOTIFY_MCUVALID ) ? +IRQENABLE_MCUVALIDINT :0 ; + val |= (notify_flags &SR_NOTIFY_MCUBOUND ) ? +IRQENABLE_MCUBOUNDSINT :0 ; + val |= (notify_flags &SR_NOTIFY_MCUDISACK ) ? +IRQENABLE_MCUDISABLEACKINT :0 ; +return val; +} + +static inline u8 irqstat_to_notifier_v1 (u32 status) +{ +u8 val; + val = (status &ERRCONFIG_MCUACCUMINTST ) ? +SR_NOTIFY_MCUACCUM :0 ; + val |= (status &ERRCONFIG_MCUVALIDINTEN ) ? +SR_NOTIFY_MCUVALID :0 ; + val |= (status &ERRCONFIG_MCUBOUNDINTEN ) ? +SR_NOTIFY_MCUBOUND :0 ; + val |= (status &ERRCONFIG_MCUDISACKINTEN ) ? +SR_NOTIFY_MCUDISACK :0 ; +return val; +} + +static inline u8 irqstat_to_notifier_v2 (u32 status) +{ +u8 val; + val = (status &IRQENABLE_MCUACCUMINT ) ? +SR_NOTIFY_MCUACCUM :0 ; + val |= (status &IRQENABLE_MCUVALIDINT ) ? +SR_NOTIFY_MCUVALID :0 ; + val |= (status &IRQENABLE_MCUBOUNDSINT ) ? +SR_NOTIFY_MCUBOUND :0 ; + val |= (status &IRQENABLE_MCUDISABLEACKINT ) ? +SR_NOTIFY_MCUDISACK :0 ; +return val; +} + +static irqreturn_t sr_interrupt (int irq,void *data) {struct omap_sr *sr_info = (struct omap_sr *)data;u32 status =0 ; +u32 value =0 ;if (sr_info->ip_type ==SR_TYPE_V1 ) { +/* Status bits are one bit before enable bits in v1 */ + value =notifier_to_irqen_v1 (sr_class->notify_flags) >>1 ; +/* Read the status bits */ status =sr_read_reg (sr_info,ERRCONFIG_V1 ); + status &= value;/* Clear them by writing back */ -sr_write_reg (sr_info,ERRCONFIG_V1 , status); +sr_modify_reg (sr_info,ERRCONFIG_V1 , value, status); + + value =irqstat_to_notifier_v1 (status); }else if (sr_info->ip_type ==SR_TYPE_V2 ) { + value =notifier_to_irqen_v2 (sr_class->notify_flags);/* Read the status bits */ -sr_read_reg (sr_info,IRQSTATUS ); + status =sr_read_reg (sr_info,IRQSTATUS ); + status &= value;/* Clear them by writing back */ sr_write_reg (sr_info,IRQSTATUS , status); + value =irqstat_to_notifier_v2 (status); }if (sr_class->notify) - sr_class->notify (sr_info->voltdm, status); + sr_class->notify (sr_info->voltdm, value);return IRQ_HANDLED ; }
arch/arm/plat-omap/include/plat/smartreflex.h +6 -0
@@ -141,6 +141,12 @@#define OMAP3430_SR_ERRWEIGHT 0x04#define OMAP3430_SR_ERRMAXLIMIT 0x02 +/* Smart reflex notifiers for class drivers to use */ +#define SR_NOTIFY_MCUACCUM (0x1 << 0) +#define SR_NOTIFY_MCUVALID (0x1 << 1) +#define SR_NOTIFY_MCUBOUND (0x1 << 2) +#define SR_NOTIFY_MCUDISACK (0x1 << 3) +/** * struct omap_sr_pmic_data - Strucutre to be populated by pmic code to pass * pmic specific info to smartreflex driver
Signature · 1 line
1.7.1
PATCH v2 14/18 omap3+: sr: introduce notifier_control
In reply to Nishanth MenonWe need some mechanism from class drivers to control when notifiers should be triggered and when not, currently we have none, which makes Class driver usage of the interrupt events almost impossible. Introduce an smartreflex driver api for doing the same.
--- arch/arm/mach-omap2/smartreflex.c | 57 +++++++++++++++++++++++++ arch/arm/plat-omap/include/plat/smartreflex.h | 8 ++++ 2 files changed, 65 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/smartreflex.c +57 -0
@@ -704,6 +704,63 @@ void sr_disable(struct voltagedomain *voltdm) }/** +* sr_notifier_control() - control the notifier mechanism +* @voltdm: VDD pointer to which the SR module to be configured belongs to. +* @enable: true to enable notifiers and false to disable the same +* +* SR modules allow an MCU interrupt mechanism that vary based on the IP +* revision, we allow the system to generate interrupt if the class driver +* has capability to handle the same. it is upto the class driver to ensure +* the proper sequencing and handling for a clean implementation. returns +* 0 if all goes fine, else returns failure results +*/ +int sr_notifier_control (struct voltagedomain *voltdm,bool enable) +{ +struct omap_sr *sr =_sr_lookup (voltdm); +u32 value =0 ; +if (IS_ERR_OR_NULL (sr)) { +pr_warning ("%s: sr corresponding to domain not found\n" , + __func__); +return -EINVAL ; + } +if (!sr->autocomp_active) +return -EINVAL ; + +/* if I could never register an isr, why bother?? */ +if (!(sr_class && sr_class->notify && sr_class->notify_flags && + sr->irq)) { +dev_warn (&sr->pdev->dev, +"%s: unable to setup irq without handling mechanism\n" , + __func__); +return -EINVAL ; + } + +switch (sr->ip_type) { +case SR_TYPE_V1 : + value =notifier_to_irqen_v1 (sr_class->notify_flags); +sr_modify_reg (sr,ERRCONFIG_V1 , value, + (enable) ? value :0 ); +break ; +case SR_TYPE_V2 : + value =notifier_to_irqen_v2 (sr_class->notify_flags); +sr_write_reg (sr, (enable) ?IRQENABLE_SET :IRQENABLE_CLR , + value); +break ; +default : +dev_warn (&sr->pdev->dev,"%s: unknown type of sr??\n" , + __func__); +return -EINVAL ; + } + +if (enable) +enable_irq (sr->irq); +else +disable_irq_nosync (sr->irq); + +return 0 ; +} + +/** * sr_register_class() - API to register a smartreflex class parameters. * @class_data: The structure containing various sr class specific data. *
arch/arm/plat-omap/include/plat/smartreflex.h +8 -0
@@ -242,6 +242,7 @@ void omap_sr_register_pmic(struct omap_sr_pmic_data *pmic_data);/* Smartreflex driver hooks to be called from Smartreflex class driver */ int sr_enable (struct voltagedomain *voltdm,unsigned long volt);void sr_disable (struct voltagedomain *voltdm); +int sr_notifier_control (struct voltagedomain *voltdm,bool enable);int sr_configure_errgen (struct voltagedomain *voltdm);int sr_configure_minmax (struct voltagedomain *voltdm);
@@ -250,6 +251,13 @@ int sr_register_class(struct omap_sr_class_data *class_data);#else static inline void omap_sr_enable (struct voltagedomain *voltdm) {}static inline void omap_sr_disable (struct voltagedomain *voltdm) {} + +static inline int sr_notifier_control (struct voltagedomain *voltdm, +bool enable) +{ +return -EINVAL ; +} +static inline void omap_sr_disable_reset_volt (struct voltagedomain *voltdm) {} static inline void omap_sr_register_pmic(
Signature · 1 line
1.7.1
PATCH v2 15/18 omap3+: sr: disable spamming interrupts
In reply to Nishanth MenonAt times with bad SR configurations especially during silicon bringups, we could get continuous spurious interrupts which end up hanging the platform in the form of an ISR call for status bits that are automatically enabled by the h/w without any s/w clearing option.
If we detect scenarios where isr was called without the corresponding notification bit being set, instead of hanging up the system, we will disable interrupt after noting the event in the system log to try and keep system sanity and allow developer to debug and fix the condition.
--- arch/arm/mach-omap2/smartreflex.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/smartreflex.c +10 -2
@@ -209,8 +209,16 @@ static irqreturn_t sr_interrupt(int irq, void *data) value =irqstat_to_notifier_v2 (status); } -if (sr_class->notify) - sr_class->notify (sr_info->voltdm, value); +/* Attempt some resemblence of recovery! */ +if (!value) { +dev_err (&sr_info->pdev->dev,"%s: Spurious interrupt!" +"status = 0x%08x. Disabling to prevent spamming!!\n" , + __func__, status); +disable_irq_nosync (sr_info->irq); + }else { +if (sr_class->notify) + sr_class->notify (sr_info->voltdm, value); + }return IRQ_HANDLED ; }
Signature · 1 line
1.7.1
PATCH v2 15/18 omap3+: sr: disable spamming interrupts
Hello.
Quoted 21 lines · Nishanth Menon
At times with bad SR configurations especially during silicon bringups, we could get continuous spurious interrupts which end up hanging the platform in the form of an ISR call for status bits that are automatically enabled by the h/w without any s/w clearing option.
If we detect scenarios where isr was called without the corresponding notification bit being set, instead of hanging up the system, we will disable interrupt after noting the event in the system log to try and keep system sanity and allow developer to debug and fix the condition.
Signed-off-by Nishanth Menon<[email protected]>--- arch/arm/mach-omap2/smartreflex.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-)arch/arm/mach-omap2/smartreflex.c +0
-0
arch/arm/mach-omap2/smartreflex.c static irqreturn_t sr_interrupt(int irq, void *data) · line 212
Quoted 6 lines
arch/arm/mach-omap2/smartreflex.c +1
-2@@ -209,8 +209,16 @@ static irqreturn_t sr_interrupt(int irq, void *data) value =irqstat_to_notifier_v2 (status); } -if (sr_class->notify) - sr_class->notify (sr_info->voltdm, value); +/* Attempt some resemblence of recovery! */
Resemblance?
WBR, Sergei
PATCH v2 15/18 omap3+: sr: disable spamming interrupts
Sergei Shtylyov wrote, on 03/02/2011 07:15 PM:
[...]
Quoted 9 lines
Quoted 9 lines
arch/arm/mach-omap2/smartreflex.c +0
-0@@ -209,8 +209,16 @@ static irqreturn_t sr_interrupt(int irq, void *data) value =irqstat_to_notifier_v2 (status); }
Quoted 5 lines
arch/arm/mach-omap2/smartreflex.c static irqreturn_t sr_interrupt(int irq, void *data) · line 212
Quoted 3 lines
arch/arm/mach-omap2/smartreflex.c +1
-2-if (sr_class->notify) - sr_class->notify (sr_info->voltdm, value); +/* Attempt some resemblence of recovery! */ Resemblance?
arrgh.. thanks for catching :)
Signature · 2 lines
Regards, Nishanth Menon
PATCH v2 16/18 omap3+: sr: make enable path use volt_data pointer
In reply to Nishanth MenonPassing the volt_data pointers accross allows us to save us the effort of looking up the voltage data pointer from the voltage value at multiple layers, we need to look at the voltage data in dvfs layer for further processing, so modify the APIs to pass the voltage data pointer all the way through to lower layers to the smartreflex class drivers.
--- arch/arm/mach-omap2/smartreflex-class3.c | 13 +++---------- arch/arm/mach-omap2/smartreflex.c | 25 ++++++++++++------------- arch/arm/plat-omap/include/plat/smartreflex.h | 8 +++++--- 3 files changed, 20 insertions(+), 26 deletions(-)
arch/arm/mach-omap2/smartreflex-class3.c +3 -10
@@ -13,19 +13,12 @@#include <plat/smartreflex.h> -static int sr_class3_enable (struct voltagedomain *voltdm) +static int sr_class3_enable (struct voltagedomain *voltdm, +struct omap_volt_data *volt_data) { -unsigned long volt =omap_get_operation_voltage ( -omap_voltage_get_nom_volt (voltdm)); - -if (!volt) { -pr_warning ("%s: Curr voltage unknown. Cannot enable sr_%s\n" , - __func__, voltdm->name); -return -ENODATA ; - }omap_vp_enable (voltdm); -return sr_enable (voltdm, volt); +return sr_enable (voltdm, volt_data); }static int sr_class3_disable (struct voltagedomain *voltdm,int is_volt_reset)
arch/arm/mach-omap2/smartreflex.c +12 -13
@@ -302,7 +302,8 @@ static void sr_start_vddautocomp(struct omap_sr *sr)return ; } -if (!sr_class->enable (sr->voltdm)) +if (!sr_class->enable (sr->voltdm, +omap_voltage_get_nom_volt (sr->voltdm))) sr->autocomp_active = true; }
@@ -618,7 +619,7 @@ int sr_configure_minmax(struct voltagedomain *voltdm)/** * sr_enable() - Enables the smartreflex module. * @voltdm: VDD pointer to which the SR module to be configured belongs to. -* @volt: The voltage at which the Voltage domain associated with +* @volt_data: The voltage at which the Voltage domain associated with * the smartreflex module is operating at. * This is required only to program the correct Ntarget value. *
@@ -626,10 +627,9 @@ int sr_configure_minmax(struct voltagedomain *voltdm)* enable a smartreflex module. Returns 0 on success. Returns error * value if the voltage passed is wrong or if ntarget value is wrong. */ -int sr_enable (struct voltagedomain *voltdm,unsigned long volt) +int sr_enable (struct voltagedomain *voltdm,struct omap_volt_data *volt_data) {u32 nvalue_reciprocal; -struct omap_volt_data *volt_data;struct omap_sr *sr =_sr_lookup (voltdm);int ret;
@@ -639,19 +639,16 @@ int sr_enable(struct voltagedomain *voltdm, unsigned long volt)return -EINVAL ; } - volt_data =omap_voltage_get_voltdata (sr->voltdm, volt); - -if (IS_ERR (volt_data)) { -dev_warn (&sr->pdev->dev,"%s: Unable to get voltage table" -"for nominal voltage %ld\n" , __func__, volt); -return -ENODATA ; +if (IS_ERR_OR_NULL (volt_data)) { +dev_warn (&sr->pdev->dev,"%s: bad voltage data\n" , __func__); +return -EINVAL ; } nvalue_reciprocal =sr_retrieve_nvalue (sr, volt_data->sr_efuse_offs);if (!nvalue_reciprocal) {dev_warn (&sr->pdev->dev,"%s: NVALUE = 0 at voltage %ld\n" , - __func__, volt); + __func__,omap_get_operation_voltage (volt_data));return -ENODATA ; }
@@ -808,13 +805,15 @@ int sr_register_class(struct omap_sr_class_data *class_data)* omap_sr_enable() - API to enable SR clocks and to call into the * registered smartreflex class enable API. * @voltdm: VDD pointer to which the SR module to be configured belongs to. +* @volt_data: Voltage data to go to * * This API is to be called from the kernel in order to enable * a particular smartreflex module. This API will do the initial * configurations to turn on the smartreflex module and in turn call * into the registered smartreflex class enable API. */ -void omap_sr_enable (struct voltagedomain *voltdm) +void omap_sr_enable (struct voltagedomain *voltdm, +struct omap_volt_data *volt_data) {struct omap_sr *sr =_sr_lookup (voltdm);
@@ -833,7 +832,7 @@ void omap_sr_enable(struct voltagedomain *voltdm)return ; } - sr_class->enable (voltdm); + sr_class->enable (voltdm, volt_data); }/**
arch/arm/plat-omap/include/plat/smartreflex.h +5 -3
@@ -185,7 +185,8 @@ struct omap_sr_pmic_data {* @class_priv_data: Class specific private data (optional) */ struct omap_sr_class_data { -int (*enable)(struct voltagedomain *voltdm); +int (*enable)(struct voltagedomain *voltdm, +struct omap_volt_data *volt_data);int (*disable)(struct voltagedomain *voltdm,int is_volt_reset);int (*class_init)(struct voltagedomain *voltdm,void *class_priv_data); int (*class_deinit)(struct voltagedomain *voltdm,
@@ -232,7 +233,8 @@ struct omap_sr_data { };/* Smartreflex module enable/disable interface */ -void omap_sr_enable (struct voltagedomain *voltdm); +void omap_sr_enable (struct voltagedomain *voltdm, +struct omap_volt_data *volt_data);void omap_sr_disable (struct voltagedomain *voltdm);void omap_sr_disable_reset_volt (struct voltagedomain *voltdm);
@@ -240,7 +242,7 @@ void omap_sr_disable_reset_volt(struct voltagedomain *voltdm);void omap_sr_register_pmic (struct omap_sr_pmic_data *pmic_data);/* Smartreflex driver hooks to be called from Smartreflex class driver */ -int sr_enable (struct voltagedomain *voltdm,unsigned long volt); +int sr_enable (struct voltagedomain *voltdm,struct omap_volt_data *volt_data);void sr_disable (struct voltagedomain *voltdm);int sr_notifier_control (struct voltagedomain *voltdm,bool enable);int sr_configure_errgen (struct voltagedomain *voltdm);
Signature · 1 line
1.7.1
PATCH v2 17/18 omap3630+: sr: add support for class 1.5
In reply to Nishanth MenonTraditional SmartReflex AVS(Automatic Voltage Scaling) classes are:
* Class 0 - Product test calibration
Silicon is calibration at production floor and fused with voltages for each OPP
* Class 1 - Boot time calibration
Silicon is calibrated once at boot time and voltages are stored for the lifetime of operation.
* Class 2 - continuous s/w calibration
SR module notifies s/w for any change in the system which is desired and the s/w makes runtime decisions in terms of setting the voltage, this mechanism could be used in the system which does not have PMIC capable of SR without using the voltage controller and voltage processor blocks.
* Class 3 - continuous h/w calibration
SR module is switch on after reaching a voltage level and SR continuously monitors the system and makes runtime adjustments without s/w involvement.
OMAP3430 has used SmartReflex AVS and with a a PMIC which understands the SR protocol, Class 3 has been used. With OMAP3630 onwards, a new SmartReflex AVS class of operation Class 1.5 was introduced.
* Class 1.5 - periodic s/w calibration
This uses the h/w calibration loop and at the end of calibration stores the voltages to be used run time, periodic recalibration is performed as well.
The operational mode is describes as the following:
* SmartReflex AVS h/w calibration loop is essential to identify the optimal voltage for a given OPP.
* Once this optimal voltage is detected, SmartReflex AVS loop is disabled in class 1.5 mode of operation.
* Until there is a need for a recalibration, any further transition to an OPP voltage which is calibrated can use the calibrated voltage and does not require enabling the SR AVS h/w loop.
* On a periodic basis (recommendation being once approximately every 24 hours), software is expected to perform a recalibration to find a new optimal voltage which is compensated for device aging.
- For performing this recalibration, the start voltage does not need to be the nominal voltage anymore. instead, the system can start with a voltage which is 50mV higher than the previously calibrated voltage to identify the new optimal voltage as the aging factor within a period of 1 day is not going to be anywhere close to 50mV.
- This "new starting point" for recalibration is called a dynamic nominal voltage for that voltage point.
In short, with the introduction of SmartReflex class 1.5, there are three new voltages possible in a system's dvfs transition:
* Nominal Voltage - The maximum voltage needed for a worst possible device in the worst possible conditions. This is the voltage we choose as the starting point for the h/w loop to optimize for the first time calibration on system bootup.
* Dynamic Nominal Voltage - Worst case voltage for a specific device in considering the system aging on the worst process device.
* Calibrated Voltage - Best voltage for the current device at a given point of time.
In terms of the implementation, doing calibration involves waiting for the smartreflex h/w loop to settle down, and doing this as part of the dvfs flow itself is to increase the latency of dvfs transition when there is a need to calibrate that opp. instead, the calibration is performed "out of path" using a workqueue statemachine. The workqueue waits for the system stabilization, then enables VP interrupts to monitor for system instability interms of voltage oscillations that are reported back to the system as interrupts, in case of prolonged system oscillations, nominal voltage is chosen as a safe voltage and this event is logged in the system log for developer debug and fixing.
For the recalibration, a common workqueue for all domains is started at the start of the class initialization and it resets the calibrated voltages on a periodic basis. For distros that may choose not to do the recommended periodic recalibration, instead choose to perform boot time calibration, kconfig configuration option is provided to do so.
TODO:
a) Cpuidle and suspend paths are not integrated with SmartReflex driver at this point.
b) Since the SR registers are accessed and controlled in parallel to DVFS some sort of mechanism is necessary to be introduced along with OMAP dvfs layer to ensure mutual exclusivity
c) Additional debug interfaces for vmin analysis for platform characterization and addition of system margin needs to be introduced from smartreflex perspective.
This implementation also includes the following contributors:
Tony Lindgren for suggestion on using interrupt based mechanism instead of polling to detect voltage oscillations.
Peter 'p2' De Schrijver for debating alternatives on recalibration mechanisms Paul Walmsey, Eduardo Valentin, Ambresh K, Igor Dmitriev and quiet a few others for patient review, testing and reporting of issues of a previous incarnation of this implemenation. Last, but not the least, the TI H/w team in introducing this new SR AVS class and patiently debating it's various facets.
--- arch/arm/mach-omap2/Makefile | 1 + arch/arm/mach-omap2/smartreflex-class1p5.c | 582 +++++++++++++++++++++++++ arch/arm/mach-omap2/smartreflex-class3.c | 4 +- arch/arm/mach-omap2/smartreflex.c | 34 ++- arch/arm/mach-omap2/voltage.c | 79 ++++ arch/arm/plat-omap/Kconfig | 17 + arch/arm/plat-omap/include/plat/smartreflex.h | 13 +- arch/arm/plat-omap/include/plat/voltage.h | 23 +- 8 files changed, 745 insertions(+), 8 deletions(-) create mode 100644 arch/arm/mach-omap2/smartreflex-class1p5.c
arch/arm/mach-omap2/Makefile +1 -0
@@ -66,6 +66,7 @@ obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o voltage.o pm_bus.o obj-$(CONFIG_PM_DEBUG) += pm-debug.o obj-$(CONFIG_OMAP_SMARTREFLEX) += sr_device.o smartreflex.o obj-$(CONFIG_OMAP_SMARTREFLEX_CLASS3) += smartreflex-class3.o +obj-$(CONFIG_OMAP_SMARTREFLEX_CLASS1P5) += smartreflex-class1p5.o AFLAGS_sleep24xx.o :=-Wa,-march=armv6 AFLAGS_sleep34xx.o :=-Wa,-march=armv7-a
arch/arm/mach-omap2/smartreflex-class1p5.c new file +582 -0
582 lines not on this page · raw message
arch/arm/mach-omap2/smartreflex-class3.c +3 -1
@@ -21,7 +21,9 @@ static int sr_class3_enable(struct voltagedomain *voltdm,return sr_enable (voltdm, volt_data); } -static int sr_class3_disable (struct voltagedomain *voltdm,int is_volt_reset) +static int sr_class3_disable (struct voltagedomain *voltdm, +struct omap_volt_data *vdata, +int is_volt_reset) {omap_vp_disable (voltdm);sr_disable (voltdm);
arch/arm/mach-omap2/smartreflex.c +30 -4
@@ -317,7 +317,9 @@ static void sr_stop_vddautocomp(struct omap_sr *sr) }if (sr->autocomp_active) { - sr_class->disable (sr->voltdm,1 ); + sr_class->disable (sr->voltdm, +omap_voltage_get_nom_volt (sr->voltdm), +1 );if (sr_class->class_deinit && sr_class->class_deinit (sr->voltdm, sr_class->class_priv_data)) {
@@ -471,6 +473,28 @@ static u32 sr_retrieve_nvalue(struct omap_sr *sr, u32 efuse_offs)/* Public Functions */ /** +* is_sr_enabled() - is Smart reflex enabled for this domain? +* @voltdm: voltage domain to check +* +* Returns 0 if SR is enabled for this domain, else returns err +*/ +bool is_sr_enabled (struct voltagedomain *voltdm) +{ +struct omap_sr *sr; +if (IS_ERR_OR_NULL (voltdm)) { +pr_warning ("%s: invalid param voltdm\n" , __func__); +return false; + } + sr =_sr_lookup (voltdm); +if (IS_ERR (sr)) { +pr_warning ("%s: omap_sr struct for sr_%s not found\n" , + __func__, voltdm->name); +return false; + } +return sr->autocomp_active; +} + +/** * sr_configure_errgen() - Configures the smrtreflex to perform AVS using the * error generator module. * @voltdm: VDD pointer to which the SR module to be configured belongs to.
@@ -839,6 +863,7 @@ void omap_sr_enable(struct voltagedomain *voltdm,* omap_sr_disable() - API to disable SR without resetting the voltage * processor voltage * @voltdm: VDD pointer to which the SR module to be configured belongs to. +* @volt_data: Voltage data to go to * * This API is to be called from the kernel in order to disable * a particular smartreflex module. This API will in turn call
@@ -846,7 +871,8 @@ void omap_sr_enable(struct voltagedomain *voltdm,* the smartreflex class disable not to reset the VP voltage after * disabling smartreflex. */ -void omap_sr_disable (struct voltagedomain *voltdm) +void omap_sr_disable (struct voltagedomain *voltdm, +struct omap_volt_data *vdata) {struct omap_sr *sr =_sr_lookup (voltdm);
@@ -865,7 +891,7 @@ void omap_sr_disable(struct voltagedomain *voltdm)return ; } - sr_class->disable (voltdm,0 ); + sr_class->disable (voltdm, vdata,0 ); }/**
@@ -898,7 +924,7 @@ void omap_sr_disable_reset_volt(struct voltagedomain *voltdm)return ; } - sr_class->disable (voltdm,1 ); + sr_class->disable (voltdm,omap_voltage_get_nom_volt (voltdm),1 ); }/**
arch/arm/mach-omap2/voltage.c +79 -0
100 lines not on this page · raw message
arch/arm/plat-omap/Kconfig +17 -0
@@ -67,6 +67,23 @@ config OMAP_SMARTREFLEX_CLASS3 Class 3 implementation of Smartreflex employs continuous hardware voltage calibration. +config OMAP_SMARTREFLEX_CLASS1P5 + bool "Class 1.5 mode of Smartreflex Implementation" + depends on OMAP_SMARTREFLEX && TWL4030_CORE + help + Say Y to enable Class 1.5 implementation of Smartreflex + Class 1.5 implementation of Smartreflex employs software controlled + hardware voltage calibration. + +config OMAP_SR_CLASS1P5_RECALIBRATION_DELAY + int "Class 1.5 mode recalibration recalibration delay(ms)" + depends on OMAP_SMARTREFLEX_CLASS1P5 + default 86400000 + help + Setup the recalibration delay in milliseconds. Use 0 for never doing + a recalibration. Defaults to recommended recalibration every 24hrs. + If you do not understand this, use the default. + config OMAP_RESET_CLOCKS bool "Reset unused clocks during boot" depends on ARCH_OMAP
arch/arm/plat-omap/include/plat/smartreflex.h +11 -2
@@ -167,6 +167,7 @@ struct omap_sr_pmic_data {#define SR_CLASS1 0x1#define SR_CLASS2 0x2#define SR_CLASS3 0x3 +#define SR_CLASS1P5 0x4/** * struct omap_sr_class_data - Smartreflex class driver info
@@ -187,7 +188,9 @@ struct omap_sr_pmic_data {struct omap_sr_class_data {int (*enable)(struct voltagedomain *voltdm,struct omap_volt_data *volt_data); -int (*disable)(struct voltagedomain *voltdm,int is_volt_reset); +int (*disable)(struct voltagedomain *voltdm, +struct omap_volt_data *volt_data, +int is_volt_reset);int (*class_init)(struct voltagedomain *voltdm,void *class_priv_data);int (*class_deinit)(struct voltagedomain *voltdm,void *class_priv_data);
@@ -235,7 +238,8 @@ struct omap_sr_data {/* Smartreflex module enable/disable interface */ void omap_sr_enable (struct voltagedomain *voltdm,struct omap_volt_data *volt_data); -void omap_sr_disable (struct voltagedomain *voltdm); +void omap_sr_disable (struct voltagedomain *voltdm, +struct omap_volt_data *volt_data);void omap_sr_disable_reset_volt (struct voltagedomain *voltdm);/* API to register the pmic specific data with the smartreflex driver. */
@@ -250,6 +254,7 @@ int sr_configure_minmax(struct voltagedomain *voltdm);/* API to register the smartreflex class driver with the smartreflex driver */ int sr_register_class (struct omap_sr_class_data *class_data); +bool is_sr_enabled (struct voltagedomain *voltdm);#else static inline void omap_sr_enable (struct voltagedomain *voltdm) {}static inline void omap_sr_disable (struct voltagedomain *voltdm) {}
@@ -264,5 +269,9 @@ static inline void omap_sr_disable_reset_volt( struct voltagedomain *voltdm) {}static inline void omap_sr_register_pmic (struct omap_sr_pmic_data *pmic_data) {} +static inline bool is_sr_enabled (struct voltagedomain *voltdm) +{ +return false; +}#endif #endif
arch/arm/plat-omap/include/plat/voltage.h +22 -1
@@ -58,6 +58,8 @@#define OMAP4430_VDD_CORE_OPP50_UV 930000#define OMAP4430_VDD_CORE_OPP100_UV 1100000 +#define OMAP3PLUS_DYNAMIC_NOMINAL_MARGIN_UV 50000 +/** * struct voltagedomain - omap voltage domain global structure. * @name: Name of the voltage domain which can be used as a unique
@@ -81,6 +83,8 @@ struct voltagedomain {*/ struct omap_volt_data {u32 volt_nominal; +u32 volt_calibrated; +u32 volt_dynamic_nominal;u32 sr_efuse_offs;u8 sr_errminlimit;u8 vp_errgain;
@@ -127,6 +131,7 @@ struct omap_volt_data *omap_voltage_get_nom_volt(struct voltagedomain *voltdm);bool omap_vp_is_transdone (struct voltagedomain *voltdm);bool omap_vp_clear_transdone (struct voltagedomain *voltdm);struct dentry *omap_voltage_get_dbgdir (struct voltagedomain *voltdm); +int omap_voltage_calib_reset (struct voltagedomain *voltdm);#ifdef CONFIG_PM int omap_voltage_register_pmic (struct voltagedomain *voltdm,struct omap_volt_pmic_info *pmic_info);
@@ -160,7 +165,23 @@ static inline unsigned long omap_get_operation_voltage( {if (IS_ERR_OR_NULL (vdata))return 0 ; -return vdata->volt_nominal; +return (vdata->volt_calibrated) ? vdata->volt_calibrated : + (vdata->volt_dynamic_nominal) ? vdata->volt_dynamic_nominal : + vdata->volt_nominal; } +/* what is my dynamic nominal? */ +static inline unsigned long omap_get_dyn_nominal (struct omap_volt_data *vdata) +{ +if (IS_ERR_OR_NULL (vdata)) +return 0 ; +if (vdata->volt_calibrated) { +unsigned long v = vdata->volt_calibrated + +OMAP3PLUS_DYNAMIC_NOMINAL_MARGIN_UV ; +if (v > vdata->volt_nominal) +return vdata->volt_nominal; +return v; + } +return vdata->volt_nominal; +}#endif
Signature · 1 line
1.7.1
PATCH v2 18/18 omap3430: sr: class3: restrict cpu to run on
In reply to Nishanth MenonUse SmartReflex AVS Class3 initialization only for OMAP343x family of processors.
--- arch/arm/mach-omap2/smartreflex-class3.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/smartreflex-class3.c +5 -0
@@ -11,6 +11,7 @@* published by the Free Software Foundation. */ +#include <plat/cpu.h> #include <plat/smartreflex.h> static int sr_class3_enable(struct voltagedomain *voltdm,
@@ -49,6 +50,10 @@ static struct omap_sr_class_data class3_data = {/* Smartreflex Class3 init API to be called from board file */ static int __init sr_class3_init (void ) { +/* Enable this class only for OMAP343x */ +if (!cpu_is_omap343x ()) +return -EINVAL ; +pr_info ("SmartReflex Class3 initialized\n" );return sr_register_class (&class3_data); }
Signature · 1 line
1.7.1