Move tar package location to 'system-tools'
PATCH 1/1 Move tar package location to 'system-tools'
A non-text attachment was scrubbed...
Name: 0001-Move-tar-package-location-to-system-tools.patch
Type: text/x-patch
Size: 1126 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150901/e4e1b829/attachment.bin>
PATCH 1/1 Move tar package location to 'system-tools'
Dear Francesco Nwokeka,
could you please send the patch in-line using "git send-email" instead of attaching the patch to the email?
Also, one comment regarding your patch:
Review endif · line 1513
Quoted 9 lines
(quoted diff) +3
-0@@ -1509,6 +1506,9 @@ endif if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/sysvinit/Config.in" endif +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + source "package/tar/Config.in" +endif source "package/util-linux/Config.in" endmenu
Since there are two packages in a row which are inside an "if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", it would be better if you put them together into the same if clause. Something like this:
Quoted 7 lines
(quoted diff) +1
-0@@ -1509,6 +1506,9 @@ endif if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/sysvinit/Config.in" + source "package/tar/Config.in" endif source "package/util-linux/Config.in"endmenu
Please label your next patch as v2 ([PATCHv2]) when you send it :-)
Regards,
Vincent.
Quoted 7 lines · Francesco Nwokeka
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 Move tar package location to 'system-tools'
Hello,
Quoted 1 line · Vicente Olivert Riera
Please label your next patch as v2 ([PATCHv2]) when you send it :-)
And also use the usual convention for the commit title:
<package>: <description>
so, something like:
tar: move to the "System tools" menu
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 tar: Move tar package to 'system-tools' menu
In reply to Francesco Nwokeka--- package/Config.in | 2 -- 1 file changed, 2 deletions(-)
package/Config.in +0 -2
@@ -1505,8 +1505,6 @@ endif source "package/systemd/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/sysvinit/Config.in" -endif -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/tar/Config.in" endif source "package/util-linux/Config.in"
Signature · 1 line
2.5.0