Skip to contentSkip to conversation

powerpc/pseries: Disable VPNH feature

PATCH In review Benjamin Herrenschmidt 1 participant 2 messages Mar 9, 2011 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/pseries: Disable VPNH feature

This feature triggers nasty races in the scheduler between the rebuilding of the topology and the load balancing code, causing the machine to hang.

Disable it for now until the races are fixed.

---

Jesse: I'm sending that to Linus now. We'll sort things out for the next release.

arch/powerpc/mm/numa.c +2 -0
index fd48123..74f1baa 100644
@@ -1516,6 +1516,7 @@ int start_topology_update(void)
 {
 	int rc = 0;
 
+#if 0 /* Disabled until races with load balancing are fixed */
 	if (firmware_has_feature(FW_FEATURE_VPHN) &&
 	    get_lppaca()->shared_proc) {
 		vphn_enabled = 1;
@@ -1524,6 +1525,7 @@ int start_topology_update(void)
 		set_topology_timer();
 		rc = 1;
 	}
+#endif
 
 	return rc;
 }
#1 lore raw
Quoted 25 lines · Benjamin Herrenschmidt

This feature triggers nasty races in the scheduler between the rebuilding of the topology and the load balancing code, causing the machine to hang.

Disable it for now until the races are fixed.

---

Jesse: I'm sending that to Linus now. We'll sort things out for the next release.

arch/powerpc/mm/numa.c +1 -0
index fd48123..74f1baa 100644
@@ -1516,6 +1516,7 @@ int start_topology_update(void)
 {
 	int rc = 0;
 
+#if 0 /* Disabled until races with load balancing are fixed */
 	if (firmware_has_feature(FW_FEATURE_VPHN) &&
 	    get_lppaca()->shared_proc) {
 		vphn_enabled = 1;

arch/powerpc/mm/numa.c int start_topology_update(void) · line 1528

Quoted 4 lines
arch/powerpc/mm/numa.c +1 -0
@@ -1524,6 +1525,7 @@ int start_topology_update(void)
 		set_topology_timer();
 		rc = 1;
 	}
+#endif

Turning that into if (0 && instead to avoid compiler warnings and thus build failures

Cheers,
Ben.