drivers/misc: atmel_tclib: fix a memory leak

PATCH New Axel Lin 1 participant 1 message Mar 10, 2011

Subsystems (2)

Char and misc drivers Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

Axel Lin

author

2011-03-10 08:19 UTC #0 lore raw

PATCH 1/1 drivers/misc: atmel_tclib: fix a memory leak

request_mem_region() will call kzalloc to allocate memory for struct resource. release_resource() unregisters the resource but does not free the allocated memory, thus use release_mem_region() instead to fix the memory leak.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/misc/atmel_tclib.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/misc/atmel_tclib.c +2 -2

index 3891124..a844810 100644
@@ -75,7 +75,7 @@ out:
 	return tc;
 
 fail_ioremap:
-	release_resource(r);
+	release_mem_region(r->start, ATMEL_TC_IOMEM_SIZE);
 fail:
 	tc = NULL;
 	goto out;

@@ -95,7 +95,7 @@ void atmel_tc_free(struct atmel_tc *tc)
 	spin_lock(&tc_list_lock);
 	if (tc->regs) {
 		iounmap(tc->regs);
-		release_resource(tc->iomem);
+		release_mem_region(tc->iomem->start, ATMEL_TC_IOMEM_SIZE);
 		tc->regs = NULL;
 		tc->iomem = NULL;
 	}

Signature · 1 line

1.7.2