Skip to contentSkip to conversation

MAINTAINERS: add entry for Rockchip drm drivers

PATCH In review Heiko Stübner 2 participants 3 messages Apr 19, 2015 – Apr 20, 2015

Subsystems (4)
DRM drivers DRM misc Arm Rockchip DRM drivers for Rockchip
lore
Share & tools
lore

Heiko Stübner

author maintainer
#0 lore raw

PATCH v2 1/2 MAINTAINERS: add entry for Rockchip drm drivers

Mark Yao looks after the Rockchip drm drivers and should thus also get patches touching these.

Signed-off-by Heiko Stuebner <[email protected]>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
index 7687fc6..7e4d386 100644
@@ -3410,6 +3410,13 @@ F:	drivers/gpu/drm/rcar-du/
 F:	drivers/gpu/drm/shmobile/
 F:	include/linux/platform_data/shmob_drm.h
 
+DRM DRIVERS FOR ROCKCHIP
+M:	Mark Yao <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/gpu/drm/rockchip/
+F:	Documentation/devicetree/bindings/video/rockchip*
+
 DSBR100 USB FM RADIO DRIVER
 M:	Alexey Klimov <[email protected]>
 L:	[email protected]
Signature · 7 lines
2.1.4


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#1 lore raw

PATCH v2 2/2 drm/rockchip: fix error check when getting irq

platform_get_irq() can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose possible error values.

Reported-by David Binderman <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>
Reviewed-by Daniel Kurtz <[email protected]>

---
changed since v1:
- instead of making irq in struct vop signed use a separate local irq int in vop_bind as suggested by Daniel Kurtz

 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +5 -4
index ccb0ce0..0e539d8 100644
@@ -1409,7 +1409,7 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
 	struct vop *vop;
 	struct resource *res;
 	size_t alloc_size;
-	int ret;
+	int ret, irq;
 
 	of_id = of_match_device(vop_driver_dt_match, dev);
 	vop_data = of_id->data;

@@ -1445,11 +1445,12 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	vop->irq = platform_get_irq(pdev, 0);
-	if (vop->irq < 0) {
+ 	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
 		dev_err(dev, "cannot find irq for vop\n");
-		return vop->irq;
+		return irq;
 	}
+	vop->irq = (unsigned int)irq;
 
 	spin_lock_init(&vop->reg_lock);
 	spin_lock_init(&vop->irq_lock);
Signature · 7 lines
2.1.4


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

Re: [PATCH v2 2/2] drm/rockchip: fix error check when getting irq

Quoted 34 lines · Heiko Stübner

platform_get_irq() can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose possible error values.

Reported-by David Binderman <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>
Reviewed-by Daniel Kurtz <[email protected]>

---
changed since v1:
- instead of making irq in struct vop signed use a separate local irq int in vop_bind as suggested by Daniel Kurtz

  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 9 +++++----
  1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1 -3
index ccb0ce0..0e539d8 100644
@@ -1409,7 +1409,7 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
  	struct vop *vop;
  	struct resource *res;
  	size_t alloc_size;
-	int ret;
+	int ret, irq;
 
  	of_id = of_match_device(vop_driver_dt_match, dev);
  	vop_data = of_id->data;

@@ -1445,11 +1445,12 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
  		return ret;
  	}
 
-	vop->irq = platform_get_irq(pdev, 0);
-	if (vop->irq < 0) {

drivers/gpu/drm/rockchip/rockchip_drm_vop.c static int vop_bind(struct device *dev, struct device *master, void *data) · line 1456

Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +4 -1
+ 	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
  		dev_err(dev, "cannot find irq for vop\n");
-		return vop->irq;
+		return irq;
  	}
+	vop->irq = (unsigned int)irq;
 
  	spin_lock_init(&vop->reg_lock);
  	spin_lock_init(&vop->irq_lock);

Thanks for fix, I have sent the Pull request.:-)

Signature · 6 lines
Ｍark

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel