parse-events: Add support for printing short fields.

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

Signed-off-by David Sharp <[email protected]>

Cc Darren Hart <[email protected]>

Cc Steven Rostedt <[email protected]>

---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Makefile +2 -2

index 169fcbc..fa37df5 100644
@@ -13,8 +13,8 @@ FILE_VERSION = 6
 
 MAKEFLAGS += --no-print-directory
 
-CC ?= $(CROSS_COMPILE)gcc
-AR ?= $(CROSS_COMPILE)ar
+CC = $(CROSS_COMPILE)gcc
+AR = $(CROSS_COMPILE)ar
 EXT = -std=gnu99
 INSTALL = install
 

Quoted 6 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

Darren, can you verify this, as you were the one to make the original change. I never had to cross compile it, I always did it natively.

Quoted 10 lines · Steven Rostedt

Quoted 6 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

Darren, can you verify this, as you were the one to make the original change. I never had to cross compile it, I always did it natively.

OK, I just proved that David is correct, with the following make file:

---
CC ?= foo
AR ?= bar
all:

	echo what is $(CC) $(AR)

---

$ make
what is cc ar

Darren, can you just give an Acked-by anyway. I hate to apply a revert of your patch without you doing so.

Thanks,

-- Steve

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

Signed-off-by David Sharp<[email protected]>

Cc Darren Hart<[email protected]>

Cc Steven Rostedt<[email protected]>

---
  Makefile |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Makefile +2 -2

index 169fcbc..fa37df5 100644
@@ -13,8 +13,8 @@ FILE_VERSION = 6
 
  MAKEFLAGS += --no-print-directory
 
-CC ?= $(CROSS_COMPILE)gcc
-AR ?= $(CROSS_COMPILE)ar
+CC = $(CROSS_COMPILE)gcc
+AR = $(CROSS_COMPILE)ar
  EXT = -std=gnu99
  INSTALL = install
 

Quoted 6 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Quoted 14 lines · Darren Hart

Quoted 6 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

Quoted 4 lines

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Hmm, but the thing is, the change did not work,

for some reason does not supply a 'cc'. Or that 'cc' defaulted to the compiler that you wanted, where 'gcc' would not.

Thus, would you be fine with something like:

	BUILD_CC ?=	$(CROSS_COMPILE)gcc
	CC	 =	$(BUILD_CC)

Then you could just update BUILD_CC and that will update CC for you.

-- Steve

Quoted 19 lines · Steven Rostedt

Quoted 18 lines · Darren Hart

Quoted 10 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means
that "CC ?= anything" will never have effect, because CC is always already set.
Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or
environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

Quoted 6 lines

Quoted 4 lines

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Hmm, but the thing is, the change did not work,

It did work for me as I was setting CC= on the command line.

unless your environment

Quoted 8 lines

for some reason does not supply a 'cc'. Or that 'cc' defaulted to the compiler that you wanted, where 'gcc' would not.

Thus, would you be fine with something like:

       BUILD_CC ?=     $(CROSS_COMPILE)gcc
       CC       =      $(BUILD_CC)

This would also work, but what is wrong with:

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:
       echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.

Thanks,

--
Darren

Quoted 6 lines

Then you could just update BUILD_CC and that will update CC for you.

-- Steve

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Quoted 15 lines · Darren Hart

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:

       echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

Quoted 6 lines

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.

It's a little odd that the default CC is "cc" unless you supply CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I would think it's weird.

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

I'll play with some other make tricks and see if I can come up with a better solution.

Quoted 2 lines · Steven Rostedt

I'll play with some other make tricks and see if I can come up with a better solution.

OK, it didn't take me long to come up with "Makefiles suck" ;)

But I did come up with a solution:

ifneq ("$(origin CC)", "environment")
CC = gcc
endif

CC = $(CROSS_COMPILE)$(CC)

This wont let make CC=xx work unless I also add a:

ifneq ("$(origin CC)", "command line")

around the above if, but do we care?

-- Steve

Quoted 6 lines · Steven Rostedt

Quoted 2 lines · Steven Rostedt

I'll play with some other make tricks and see if I can come up with a better solution.

OK, it didn't take me long to come up with "Makefiles suck" ;)

Yes, except for very basic things.

Quoted 9 lines

But I did come up with a solution:

ifneq ("$(origin CC)", "environment")
CC = gcc
endif

CC = $(CROSS_COMPILE)$(CC)

Quoted 7 lines

This wont let make CC=xx work unless I also add a:

ifneq ("$(origin CC)", "command line")

around the above if, but do we care?

-- Steve

This seems to do it all:

define allow-override
$(if $(or $(findstring environment,$(origin $(1))),

             $(findstring command line,$(origin $(1)))),,\
     $(eval $(1) = $(2)))

endef

$(call allow-override,CC,$(CROSS_COMPILE)gcc)
$(call allow-override,AR,$(CROSS_COMPILE)ar)

Quoted 8 lines

This seems to do it all:

define allow-override
$(if $(or $(findstring environment,$(origin $(1))),

             $(findstring command line,$(origin $(1)))),,\
     $(eval $(1) = $(2)))

endef

Quoted 2 lines

$(call allow-override,CC,$(CROSS_COMPILE)gcc)
$(call allow-override,AR,$(CROSS_COMPILE)ar)

Egads .... that's hideous :-) This level of complexity makes it very difficult for people to readily understand it. What does this offer over:

ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

besides being 3 lines longer with much more complex Makefile syntax and conditional statements?

Quoted 2 lines · Steven Rostedt

I'll play with some other make tricks and see if I can come up with a better solution.

OK, it didn't take me long to come up with "Makefiles suck" ;)

But I did come up with a solution:

ifneq ("$(origin CC)", "environment")
CC = gcc
endif

CC = $(CROSS_COMPILE)$(CC)

This wont let make CC=xx work unless I also add a:

ifneq ("$(origin CC)", "command line")

around the above if, but do we care?

Quoted 6 lines · Steven Rostedt

Quoted 2 lines · Steven Rostedt

I'll play with some other make tricks and see if I can come up with a better solution.

OK, it didn't take me long to come up with "Makefiles suck" ;)

Yeah, that little tidbit I sent took longer to come up with than it should have :/

Quoted 7 lines

But I did come up with a solution:

ifneq ("$(origin CC)", "environment")
CC = gcc
endif

Quoted 1 line

CC = $(CROSS_COMPILE)$(CC)

Why do we want to force CC=gcc? Isn't the right thing to make your OS setup cc to point to your preferred compiler since it is known to be the default for make?

On Ubuntu, cc -> gcc
On Fedora 13, cc -> ccache

seems strange to force it to be gcc when users/distros have gone through the trouble to set it up on their system.

Quoted 4 lines

This wont let make CC=xx work unless I also add a:

Quoted 4 lines

ifneq ("$(origin CC)", "command line")

around the above if, but do we care?

This starts to get to the point where others looking at it will choke on the expert Makefile usage.

Quoted 28 lines · David Sharp

Quoted 15 lines · Darren Hart

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:

        echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

Quoted 6 lines

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.

It's a little odd that the default CC is "cc" unless you supply CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I would think it's weird.

Quoted 3 lines

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

I really don't care much for this either. But I'm trying to make it work for everyone. Honestly, I think the BUILD_CC version is the cleanest, but I understand that this will add a burden onto Darren to fix his tools to handle it, whereas, I would like to avoid that.

Quoted 60 lines · Darren Hart

Quoted 19 lines · Steven Rostedt

Quoted 18 lines · Darren Hart

Quoted 10 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means
that "CC ?= anything" will never have effect, because CC is always already set.
Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or
environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

Quoted 6 lines

Quoted 4 lines

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Hmm, but the thing is, the change did not work,

It did work for me as I was setting CC= on the command line.

unless your environment

Quoted 8 lines

for some reason does not supply a 'cc'. Or that 'cc' defaulted to the compiler that you wanted, where 'gcc' would not.

Thus, would you be fine with something like:

        BUILD_CC ?=     $(CROSS_COMPILE)gcc
        CC       =      $(BUILD_CC)

This would also work, but what is wrong with:

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:

        echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Quoted 2 lines

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.

It's a little odd that the default CC is "cc" unless you supply CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I would think it's weird.

Quoted 56 lines · Darren Hart

Quoted 19 lines · Steven Rostedt

Quoted 18 lines · Darren Hart

Quoted 10 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means
that "CC ?= anything" will never have effect, because CC is always already set.
Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or
environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

Quoted 6 lines

Quoted 4 lines

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Hmm, but the thing is, the change did not work,

It did work for me as I was setting CC= on the command line.

unless your environment

Quoted 8 lines

for some reason does not supply a 'cc'. Or that 'cc' defaulted to the compiler that you wanted, where 'gcc' would not.

Thus, would you be fine with something like:

        BUILD_CC ?=     $(CROSS_COMPILE)gcc
        CC       =      $(BUILD_CC)

This would also work, but what is wrong with:

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:

        echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

Quoted 6 lines

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.

It's a little odd that the default CC is "cc" unless you supply CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I would think it's weird.

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

Quoted 2 lines

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

The kernel is a bit special I believe as it is pretty tied to gcc. Is trace-cmd tied to gcc to such a degree that we want to make it difficult for people to try different compilers?

Quoted 6 lines · Darren Hart

Quoted 2 lines

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

The kernel is a bit special I believe as it is pretty tied to gcc. Is trace-cmd tied to gcc to such a degree that we want to make it difficult for people to try different compilers?

True, trace-cmd is tied more to glibc (special features) than gcc.

I just looked at the Makefile for evolution, and it has:

CC = gcc

So it is not limited to just the kernel.

Quoted 11 lines · Steven Rostedt

Quoted 6 lines · Darren Hart

Quoted 2 lines

I don't know the answers, but if we take the kernel Makefile as a template, then setting CC doesn't work.

The kernel is a bit special I believe as it is pretty tied to gcc. Is trace-cmd tied to gcc to such a degree that we want to make it difficult for people to try different compilers?

True, trace-cmd is tied more to glibc (special features) than gcc.

Quoted 5 lines

I just looked at the Makefile for evolution, and it has:

CC = gcc

So it is not limited to just the kernel.

I think we're down to a subjective argument over "correctness".

Any of
the resent proposals will work for me.

Makefiles suck: Use some makefile magic to get the best of all worlds for CC and AR: Sane defaults and the ability to override CC, and AR, or use CROSS_COMPILE to set a prefix.

Signed-off-by David Sharp <[email protected]>

Cc Steven Rostedt <[email protected]>

Cc Darren Hart <[email protected]>

---

Quoted 15 lines · Steven Rostedt

Quoted 14 lines · Darren Hart

Quoted 6 lines · David Sharp

This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49.

Make has default values CC and AR of 'cc' and 'ar' respectively. This means that "CC ?= anything" will never have effect, because CC is always already set. Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or environment useless.

The problem with this approach is it prevents the user from setting CC explicitly with the environment which is a very common way of using a specific version of gcc (for example). It also places restrictions on the filename of the compiler (it must end in gcc - so gcc-4.5.1 cannot work), this isn't acceptable.

Quoted 6 lines

Quoted 4 lines

You could use CC=your-cross-compiler, and if that doesn't work for you, you could prepare a patch that conditionally sets CC only if CROSS_COMPILE is set, but please do not simply revert this patch which solved a real problem with the Makefile.

Hmm, but the thing is, the change did not work,

It did work for me as I was setting CC= on the command line.

unless your environment

Quoted 7 lines

for some reason does not supply a 'cc'. Or that 'cc' defaulted to the compiler that you wanted, where 'gcc' would not.

Thus, would you be fine with something like:

	BUILD_CC ?=	$(CROSS_COMPILE)gcc
	CC	 =	$(BUILD_CC)

This would also work, but what is wrong with:

dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif

all:

	echo "CC: $(CC)"

dvhart@doubt:templates$ make -s
CC: cc

dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1

dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc

Seems to meet everyone's needs without changing any tools/scripts/etc that have used trace-cmd before or after the CC ?= wreckage.