matroxfb_base.c - a little fix
Quoted 7 lines · Denis Zaitsev
It was two identical if-else branches in
matroxfb_decode_var- one forvar->bits_per_pixel == 4 and the other for var->bits_per_pixel <= 8. So, I've removed 4's one. It should be ok, if this branch was ok - i.e. was intentionally made the same as the 8bpp's. So, Petr, please, apply this fix, if all ok.
Somebody changed == 8 to <= 8 when I was not looking... But as bits_per_pixel is already validated, it looks correct. Applied, will go to Linus next round.
Best regards,
Petr Vandrovec [email protected]
BTW, a little question: you use the (green.length == 5) test to distinct bpp15 from bpp16 (matroxfb_base.c:509). Why? Is the "real" 15 not used as the bits_per_pixel's value? Thanks in advance.