Skip to contentSkip to conversation

b43legacy: Remove unneeded variable

PATCH In review [email protected] 2 participants 3 messages Jun 14, 2023 1 message not in the archive B43LEGACY wireless driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 b43legacy: Remove unneeded variable

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded variable: "count".

---
 drivers/net/wireless/broadcom/b43legacy/debugfs.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/net/wireless/broadcom/b43legacy/debugfs.c +0 -0
index 6b0e8d117061..184b0b4bdd94 100644
@@ -65,7 +65,6 @@ struct b43legacy_dfs_file * fops_to_dfs_file(struct b43legacy_wldev *dev,
 /* wl->irq_lock is locked */
 static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, 

size_t bufsize)
{

-    ssize_t count = 0;
     u64 tsf;

     b43legacy_tsf_read(dev, &tsf);
@@ -73,7 +72,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufs
         (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
         (unsigned int)(tsf & 0xFFFFFFFFULL));

- return count;
+ return 0;
}

/* wl->irq_lock is locked */
@@ -91,7 +90,6 @@ static int tsf_write_file(struct b43legacy_wldev *dev, const char *buf, size_t c
/* wl->irq_lock is locked */
static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char
*buf, size_t bufsize)
{

-    ssize_t count = 0;
     int i;

     for (i = 0; i < 64; i++) {
@@ -99,7 +97,7 @@ static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size
             b43legacy_shm_read16(dev, B43legacy_SHM_WIRELESS, i));
     }

- return count;
+ return 0;
}

/* wl->irq_lock is locked */
@@ -125,7 +123,6 @@ static ssize_t shm_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufs
static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf,
size_t bufsize)

 {
     struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog;
-    ssize_t count = 0;
     unsigned long flags;
     int i, idx;
     struct b43legacy_txstatus *stat;
@@ -166,7 +163,7 @@ static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t b
 out_unlock:
     spin_unlock_irqrestore(&log->lock, flags);

- return count;
+ return 0;
}

/* wl->irq_lock is locked */

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev

#2 lore raw
Quoted 4 lines · On Wed, 2023-06-14 at 15:55 +0800, [email protected] wrote:

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded
variable: "count".

Hey, no. Please stop it already. This won't even _compile_. Just don't. There's really not much value in cleaning up those coccicheck warnings in the first place. You're just wasting everyone's time (including your own).

johannes

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev

#3 lore raw
Quoted 10 lines · Johannes Berg
Quoted 4 lines · On Wed, 2023-06-14 at 15:55 +0800, [email protected] wrote:

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded
variable: "count".

Hey, no. Please stop it already. This won't even _compile_. Just don't. There's really not much value in cleaning up those coccicheck warnings in the first place. You're just wasting everyone's time (including your own).

And BTW, I've just looked at all your other contributions to other areas of the kernel, and heard from others as well - not doing any better!

I can only suggest that you stop all of your patch submissions and re- evaluate what you're even trying to do. And not just you personally, but all of the @208suo.com folks who popped up recently.

johannes

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev