dmaengine: dmatest: use strscpy to replace strlcpy
PATCH 1/1 dmaengine: dmatest: use strscpy to replace strlcpy
The strlcpy should not be used because it doesn't limit the source length. Preferred is strscpy.
Signed-off-by XueBing Chen <[email protected]>
--- drivers/dma/dmatest.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/dma/dmatest.c +6 -6
@@ -1095,8 +1095,8 @@ static void add_threaded_test(struct dmatest_info *info)/* Copy test parameters */ params->buf_size = test_buf_size; -strlcpy (params->channel,strim (test_channel),sizeof (params->channel)); -strlcpy (params->device,strim (test_device),sizeof (params->device)); +strscpy (params->channel,strim (test_channel),sizeof (params->channel)); +strscpy (params->device,strim (test_device),sizeof (params->device)); params->threads_per_chan = threads_per_chan; params->max_channels = max_channels; params->iterations = iterations;
@@ -1240,7 +1240,7 @@ static int dmatest_chan_set(const char *val, const struct kernel_param *kp) dtc =list_last_entry (&info->channels, struct dmatest_chan, node); -strlcpy (chan_reset_val, +strscpy (chan_reset_val,dma_chan_name (dtc->chan),sizeof (chan_reset_val)); ret = -EBUSY ;
@@ -1263,14 +1263,14 @@ static int dmatest_chan_set(const char *val, const struct kernel_param *kp)if ((strcmp (dma_chan_name (dtc->chan),strim (test_channel)) !=0 ) && (strcmp ("" ,strim (test_channel)) !=0 )) { ret = -EINVAL ; -strlcpy (chan_reset_val,dma_chan_name (dtc->chan), +strscpy (chan_reset_val,dma_chan_name (dtc->chan),sizeof (chan_reset_val)); goto add_chan_err; } }else {/* Clear test_channel if no channels were added successfully */ -strlcpy (chan_reset_val,"" ,sizeof (chan_reset_val)); +strscpy (chan_reset_val,"" ,sizeof (chan_reset_val)); ret = -EBUSY ; goto add_chan_err; }
@@ -1295,7 +1295,7 @@ static int dmatest_chan_get(char *val, const struct kernel_param *kp)mutex_lock (&info->lock);if (!is_threaded_test_run (info) && !is_threaded_test_pending (info)) {stop_threaded_test (info); -strlcpy (test_channel,"" ,sizeof (test_channel)); +strscpy (test_channel,"" ,sizeof (test_channel)); }mutex_unlock (&info->lock);
Signature · 1 line
2.36.1
Quoted 3 lines · XueBing Chen
The strlcpy should not be used because it doesn't limit the source length. Preferred is strscpy.
Applied, thanks
Signature · 1 line
~Vinod