nfsrahead: fix linking while static linking
Subsystems (2)
PATCH 1/1 nfsrahead: fix linking while static linking
-lmount must preceed -lblkid and to obtain this let's add:pkg-conf --libs mount
in place of:-lmount
This ways the library order will always be correct.
--- tools/nfsrahead/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/nfsrahead/Makefile.am +1 -1
@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= `pkg-conf --libs mount` nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man
Signature · 1 line
2.34.1
Pardon, s/pkg-conf/pkg-config
I'm going to send V2
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 23 lines · Giulio Benetti
-lmount must preceed -lblkid and to obtain this let's add:
pkg-conf --libs mount
in place of:-lmount
This ways the library order will always be correct.Signed-off-by Giulio Benetti <[email protected]>--- tools/nfsrahead/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/nfsrahead/Makefile.am +1
-1@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= `pkg-conf --libs mount` nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man
PATCH v2 1/1 nfsrahead: fix linking while static linking
In reply to Giulio Benetti-lmount must preceed -lblkid and to obtain this let's add:pkg-config --libs mount
in place of:-lmount
This ways the library order will always be correct.
---V1->V2:
* modify pkg-conf to pkg-config
--- tools/nfsrahead/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/nfsrahead/Makefile.am +1 -1
@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= `pkg-config --libs mount` nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man
Signature · 1 line
2.34.1
Hi All,
please drop this patch in favor of upcoming V3. This is not a good way to use pkg-config with Autotools.
Sorry for the noise
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 26 lines · Giulio Benetti
-lmount must preceed -lblkid and to obtain this let's add:
pkg-config --libs mount
in place of:-lmount
This ways the library order will always be correct.Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* modify pkg-conf to pkg-config--- tools/nfsrahead/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/nfsrahead/Makefile.am +1
-1@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= `pkg-config --libs mount` nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man
PATCH v3 1/1 nfsrahead: fix linking while static linking
In reply to Giulio Benetti-lmount must preceed -lblkid and to obtain this let's add in configure.ac:PKG_CHECK_MODULES([LIBMOUNT], [mount])
and in tools/nfsrahead/Makefile.am let's substitute explicit -lmount with:
$(LIBMOUNT_LIBS)
This way all the required libraries will be present and in the right order when static linking.
---V1->V2:
* modify pkg-conf to pkg-configV2->V3:
* use the correct way for using pkg-config with Autotools
--- configure.ac | 3 +++ tools/nfsrahead/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)
configure.ac +3 -0
@@ -273,6 +273,9 @@ AC_LIBCAP dnl Check for -lxml2 AC_LIBXML2 +dnl Check for -lmount +PKG_CHECK_MODULES([LIBMOUNT], [mount]) + # Check whether user wants TCP wrappers support AC_TCP_WRAPPERS
tools/nfsrahead/Makefile.am +1 -1
@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= $(LIBMOUNT_LIBS) nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man
Signature · 1 line
2.34.1
Hi,
nit (not worth of reposting): I'm not a native speaker, but IMHO subject should be without while, e.g. "fix order on static linking"
Kind regards,
Petr
Hi Petr,
Quoted 8 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <[email protected]> ha scritto:
Hi,
Reviewed-by Petr Vorel <[email protected]>nit (not worth of reposting): I'm not a native speaker, but IMHO subject should be without while, e.g. "fix order on static linking"
Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.
Thank you all.
Best regards
Giulio
Quoted 3 lines
Kind regards,
Petr
Quoted 6 lines · Giulio Benetti
Hi Petr,
Quoted 4 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <[email protected]> ha scritto:
Hi,
Quoted 8 lines
Quoted 4 lines
Reviewed-by Petr Vorel <[email protected]>nit (not worth of reposting): I'm not a native speaker, but IMHO subject should be without while, e.g. "fix order on static linking"
Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.
Will do!
steved.
Quoted 10 lines
Thank you all.
Best regards
GiulioQuoted 3 lines
Kind regards,
Petr
Hi Steve, Petr,
Quoted 11 lines · Steve Dickson
Quoted 8 lines · Giulio Benetti
Hi Petr,
Quoted 6 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <[email protected]> ha scritto:
Hi,
Reviewed-by Petr Vorel <[email protected]>
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
nit (not worth of reposting): I'm not a native speaker, but IMHO subject should be without while, e.g. "fix order on static linking"
Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.Will do!
Thank you!
I will try to improve the pkg-config autotools because as it is now it works but it’s not a good solution.
I should use what it’s been suggested to me here:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
And I’ve given another solution:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
but it’s still not ok:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
So for the moment it’s a decent solution indeed it’s been committed to Buildroot but I’ll try to improve it once I’ll have time.
Kind regards
—
Giulio Benetti
CEO/CTO@Benetti Engineering sas
Quoted 12 lines
steved.
Quoted 10 lines
Thank you all.
Best regards
GiulioQuoted 3 lines
Kind regards,
Petr
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 24 lines · Giulio Benetti
Hi Steve, Petr,
Quoted 11 lines · Steve Dickson
Quoted 8 lines · Giulio Benetti
Hi Petr,
Quoted 6 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <[email protected]> ha scritto:
Hi,
Reviewed-by Petr Vorel <[email protected]>Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
nit (not worth of reposting): I'm not a native speaker, but IMHO subject should be without while, e.g. "fix order on static linking"
Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.Will do!
Thank you!
Quoted 8 lines
I will try to improve the pkg-config autotools because as it is now it works but it’s not a good solution.
I should use what it’s been suggested to me here:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
And I’ve given another solution:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
but it’s still not ok:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
I don't have access to those list...
Quoted 3 lines
So for the moment it’s a decent solution indeed it’s been committed to Buildroot but I’ll try to improve it once I’ll have time.
Sounds like a plan...
steved.
Quoted 19 lines
Kind regards
—
Giulio Benetti
CEO/CTO@Benetti Engineering sasQuoted 12 lines
steved.
Quoted 10 lines
Thank you all.
Best regards
GiulioQuoted 3 lines
Kind regards,
Petr
Quoted 32 lines · Giulio Benetti
Quoted 28 lines
Hi Steve, Petr,
Quoted 10 lines · Steve Dickson
Quoted 8 lines · Giulio Benetti
Hi Petr,
Quoted 6 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel
<[email protected]> ha scritto:Hi,
Reviewed-by Petr Vorel <[email protected]>Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
be without while, e.g. "fix order on static linking"Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.Will do!
Thank you!
I will try to improve the pkg-config autotools because as it is now it works but it’s not a good solution.
Quoted 7 lines
Quoted 6 lines
I should use what it’s been suggested to me here:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
And I’ve given another solution:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
but it’s still not ok:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.htmlI don't have access to those list...
Yep, these are forbidden 403.
Giulio, please post a link on lore
https://lore.kernel.org/buildroot/
(or on patchwork)
Kind regards,
Petr
Quoted 23 lines
Quoted 3 lines
So for the moment it’s a decent solution indeed it’s been committed to Buildroot
but I’ll try to improve it once I’ll have time.Sounds like a plan...
steved.
Quoted 15 lines
Kind regards
—
Giulio Benetti
CEO/CTO@Benetti Engineering sasQuoted 10 lines
steved.
Quoted 8 lines
Thank you all.
Best regards
GiulioQuoted 2 lines
Kind regards,
Petr
Hi Petr, Steve, All,
Quoted 38 lines · Petr Vorel
Quoted 38 lines · Giulio Benetti
Quoted 35 lines
Hi Steve, Petr,
Quoted 10 lines · Steve Dickson
Quoted 8 lines · Giulio Benetti
Hi Petr,
Quoted 6 lines
Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel
<[email protected]> ha scritto:Hi,
Reviewed-by Petr Vorel <[email protected]>Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
be without while, e.g. "fix order on static linking"Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr pointed.Will do!
Thank you!
I will try to improve the pkg-config autotools because as it is now it works but it’s not a good solution.
I should use what it’s been suggested to me here:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
And I’ve given another solution:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
but it’s still not ok:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
Quoted 6 lines
Quoted 1 line
I don't have access to those list...
Yep, these are forbidden 403.
Giulio, please post a link on lore
https://lore.kernel.org/buildroot/
(or on patchwork)
Oops, you're both right, thank you Petr.
Follows lore links:
I should use what it’s been suggested to me here:
https://lore.kernel.org/buildroot/20220810231839.1b6164f7@windsurf/
And I’ve given another solution:
https://lore.kernel.org/buildroot/[email protected]/
but it’s still not ok:
https://lore.kernel.org/buildroot/20220811224752.1a1e53b7@windsurf/
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 9 lines · Giulio Benetti
-lmount must preceed -lblkid and to obtain this let's add in configure.ac:
PKG_CHECK_MODULES([LIBMOUNT], [mount])
and intools/nfsrahead/Makefile.amlet's substitute explicit-lmountwith:
$(LIBMOUNT_LIBS)
This way all the required libraries will be present and in the right order when static linking.Signed-off-by Giulio Benetti <[email protected]>
Committed... (tag: nfs-utils-2-6-3-rc1)
steved
Quoted 36 lines
---
V1->V2:
* modify pkg-conf to pkg-configV2->V3:
* use the correct way for using pkg-config with Autotools--- configure.ac | 3 +++ tools/nfsrahead/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)configure.ac +3
-0@@ -273,6 +273,9 @@ AC_LIBCAP dnl Check for -lxml2 AC_LIBXML2 +dnl Check for -lmount +PKG_CHECK_MODULES([LIBMOUNT], [mount]) + # Check whether user wants TCP wrappers support AC_TCP_WRAPPERStools/nfsrahead/Makefile.am +1
-1@@ -1,6 +1,6 @@ libexec_PROGRAMS = nfsrahead nfsrahead_SOURCES = main.c -nfsrahead_LDFLAGS= -lmount +nfsrahead_LDFLAGS= $(LIBMOUNT_LIBS) nfsrahead_LDADD = ../../support/nfs/libnfsconf.la man5_MANS = nfsrahead.man