Skip to contentSkip to conversation

tests/kms_psr2_su: add biplanar selective update tests

PATCH Superseded Jouni Högander 3 participants 5 messages Oct 27, 2021

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/kms_psr2_su: add biplanar selective update tests

Add biplanar formats (NV12, p010) into selective update test. Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.

v2: Add back skipping of frontbuffer rendering tests

---
 tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++---------------
 1 file changed, 58 insertions(+), 33 deletions(-)
tests/i915/kms_psr2_su.c +58 -33
index 91de9bad..ff3e114b 100644
@@ -33,7 +33,8 @@
 
 IGT_TEST_DESCRIPTION("Test PSR2 selective update");
 
-#define SQUARE_SIZE 100
+#define SQUARE_SIZE   100
+#define SQUARE_OFFSET 100
 /* each selective update block is 4 lines tall */
 #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE % 4 ? 1 : 0))
 
@@ -50,6 +51,23 @@ enum operations {
 	LAST
 };
 
+static const uint32_t formats_page_flip[] = {
+	DRM_FORMAT_XRGB8888,
+	DRM_FORMAT_NV12,
+	DRM_FORMAT_P010,
+	DRM_FORMAT_INVALID,
+};
+
+static const uint32_t formats_frontbuffer[] = {
+	DRM_FORMAT_XRGB8888,
+	DRM_FORMAT_INVALID,
+};
+
+static const uint32_t *formats[] = {
+				    [PAGE_FLIP] = formats_page_flip,
+				    [FRONTBUFFER] = formats_frontbuffer,
+};
+
 static const char *op_str(enum operations op)
 {
 	static const char * const name[] = {
@@ -68,6 +86,7 @@ typedef struct {
 	igt_output_t *output;
 	struct igt_fb fb[2];
 	enum operations op;
+	uint32_t format;
 	cairo_t *cr;
 	int change_screen_timerfd;
 	uint32_t screen_changes;
@@ -111,7 +130,7 @@ static void prepare(data_t *data)
 	/* all green frame */
 	igt_create_color_fb(data->drm_fd,
 			    data->mode->hdisplay, data->mode->vdisplay,
-			    DRM_FORMAT_XRGB8888,
+			    data->format,
 			    DRM_FORMAT_MOD_LINEAR,
 			    0.0, 1.0, 0.0,
 			    &data->fb[0]);
@@ -121,14 +140,14 @@ static void prepare(data_t *data)
 
 		igt_create_color_fb(data->drm_fd,
 				    data->mode->hdisplay, data->mode->vdisplay,
-				    DRM_FORMAT_XRGB8888,
+				    data->format,
 				    DRM_FORMAT_MOD_LINEAR,
 				    0.0, 1.0, 0.0,
 				    &data->fb[1]);
 
 		cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[1]);
 		/* paint a white square */
-		igt_paint_color_alpha(cr, 0, 0, SQUARE_SIZE, SQUARE_SIZE,
+		igt_paint_color_alpha(cr, SQUARE_OFFSET, SQUARE_OFFSET, SQUARE_SIZE, SQUARE_SIZE,
 				      1.0, 1.0, 1.0, 1.0);
 		igt_put_cairo_ctx(cr);
 	} else if (data->op == FRONTBUFFER) {
@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)
 		struct drm_mode_rect clip;
 		igt_plane_t *primary;
 
-		clip.x1 = clip.y1 = 0;
-		clip.x2 = clip.y2 = SQUARE_SIZE;
+		clip.x1 = clip.y1 = SQUARE_OFFSET;
+		clip.x2 = clip.y2 = SQUARE_OFFSET + SQUARE_SIZE;
 
 		primary = igt_output_get_plane_type(data->output,
 						    DRM_PLANE_TYPE_PRIMARY);
@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)
 	case FRONTBUFFER: {
 		drmModeClip clip;
 
-		clip.x1 = clip.y1 = 0;
-		clip.x2 = clip.y2 = SQUARE_SIZE;
+		clip.x1 = clip.y1 = SQUARE_OFFSET;
+		clip.x2 = clip.y2 = SQUARE_OFFSET + SQUARE_SIZE;
 
 		if (data->screen_changes & 1) {
 			/* go back to all green frame with a square */
-			igt_paint_color_alpha(data->cr, 0, 0, SQUARE_SIZE,
+			igt_paint_color_alpha(data->cr, SQUARE_OFFSET,
+					      SQUARE_OFFSET, SQUARE_SIZE,
 					      SQUARE_SIZE, 1.0, 1.0, 1.0, 1.0);
 		} else {
 			/* go back to all green frame */
-			igt_paint_color_alpha(data->cr, 0, 0, SQUARE_SIZE,
+			igt_paint_color_alpha(data->cr, SQUARE_OFFSET,
+					      SQUARE_OFFSET, SQUARE_SIZE,
 					      SQUARE_SIZE, 0, 1.0, 0, 1.0);
 		}
 
@@ -261,6 +282,7 @@ igt_main
 					 data.debugfs_fd, PSR_MODE_2),
 			      "Error enabling PSR2\n");
 		data.op = FRONTBUFFER;
+		data.format = DRM_FORMAT_XRGB8888;
 		prepare(&data);
 		r = psr_wait_entry(data.debugfs_fd, PSR_MODE_2);
 		cleanup(&data);
@@ -281,31 +303,34 @@ igt_main
 	}
 
 	for (data.op = PAGE_FLIP; data.op < LAST; data.op++) {
-		igt_describe("Test that selective update works when screen changes");
-		igt_subtest_f("%s", op_str(data.op)) {
-
-			if (data.op == FRONTBUFFER &&
-			    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
-				/*
-				 * FIXME: Display 12+ platforms now have PSR2
-				 * selective fetch enabled by default but we
-				 * still can't properly handle frontbuffer
-				 * rendering, so right it does full frame
-				 * fetches at every frontbuffer rendering.
-				 * So it is expected that this test will fail
-				 * in display 12+ platform fow now.
-				 */
-				igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+		const uint32_t *format = formats[data.op];
+
+		while (*format != DRM_FORMAT_INVALID) {
+			data.format = *format++;
+			igt_describe("Test that selective update works when screen changes");
+			igt_subtest_f("%s_%s", op_str(data.op), igt_format_str(data.format)) {
+				if (data.op == FRONTBUFFER &&
+				    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
+					/*
+					 * FIXME: Display 12+ platforms now have PSR2
+					 * selective fetch enabled by default but we
+					 * still can't properly handle frontbuffer
+					 * rendering, so right it does full frame
+					 * fetches at every frontbuffer rendering.
+					 * So it is expected that this test will fail
+					 * in display 12+ platform for now.
+					 */
+					igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+				}
+				prepare(&data);
+				run(&data);
+				cleanup(&data);
 			}
-
-			prepare(&data);
-			run(&data);
-			cleanup(&data);
 		}
-	}
 
-	igt_fixture {
-		close(data.debugfs_fd);
-		display_fini(&data);
+		igt_fixture {
+			close(data.debugfs_fd);
+			display_fini(&data);
+		}
 	}
 }
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_psr2_su: add biplanar selective update tests (rev2)

== Series Details ==

== Series Details ==

Series: tests/kms_psr2_su: add biplanar selective update tests (rev2)
URL : https://patchwork.freedesktop.org/series/96110/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10794 -> IGTPW_6354
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/index.html

Participating hosts (38 -> 34)
------------------------------

Additional (1): fi-pnv-d510
Missing (5): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-ctg-p8600

Known issues
------------

Here are the changes found in IGTPW_6354 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][1] ([fdo#109271]) +53 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/fi-pnv-d510/igt@[email protected]

#### Possible fixes ####

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][2] ([i915#295]) -> [PASS][3] +12 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/fi-cfl-8109u/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/fi-cfl-8109u/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6262 -> IGTPW_6354

CI-20190529: 20190529
CI_DRM_10794: 05e96bb109d5fa529f77bc1ff1299f44d657f8f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6354: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/index.html
IGT_6262: d1c793b26e31cc6ae3f9fa3239805a9bbcc749fb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_psr2_su@frontbuffer_xrgb8888
+igt@kms_psr2_su@page_flip_nv12
+igt@kms_psr2_su@page_flip_p010
+igt@kms_psr2_su@page_flip_xrgb8888
-igt@kms_psr2_su@frontbuffer
-igt@kms_psr2_su@page_flip

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/index.html

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_psr2_su: add biplanar selective update tests (rev2)

In reply to Jouni Högander
== Series Details ==

== Series Details ==

Series: tests/kms_psr2_su: add biplanar selective update tests (rev2)
URL : https://patchwork.freedesktop.org/series/96110/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10794_full -> IGTPW_6354_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/index.html

Participating hosts (10 -> 7)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6354_full:

### IGT changes ###

#### Possible regressions ####

* {igt@kms_psr2_su@frontbuffer_xrgb8888} (NEW):
- shard-tglb: NOTRUN -> [SKIP][1] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@kms_psr2_su@frontbuffer_xrgb8888.html

* {igt@kms_psr2_su@page_flip_p010} (NEW):
- shard-iclb: NOTRUN -> [SKIP][2] +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb5/igt@kms_psr2_su@page_flip_p010.html

New tests
---------

New tests have been introduced between CI_DRM_10794_full and IGTPW_6354_full:

### New IGT tests (4) ###

* igt@kms_psr2_su@frontbuffer_xrgb8888:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@page_flip_nv12:
- Statuses :
- Exec time: [None] s

* igt@kms_psr2_su@page_flip_p010:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@page_flip_xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in IGTPW_6354_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb1/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-snb6/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@[email protected]
- shard-glk: NOTRUN -> [DMESG-WARN][6] ([i915#3002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk6/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl8/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][8] -> [TIMEOUT][9] ([i915#2369] / [i915#2481] / [i915#3070])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb8/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][12] -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-apl4/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-tglb6/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk5/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk8/igt@gem_exec_fair@[email protected]
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2849])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb8/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109313])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb2/igt@[email protected]

* igt@gem_exec_params@rsvd2-dirt:
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109283])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109283])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb8/igt@[email protected]

* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#118]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk6/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk2/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +20 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-snb2/igt@[email protected]

* igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#4270]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#4270]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb2/igt@[email protected]

* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#768]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109312])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#3297])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][32] -> [DMESG-WARN][33] ([i915#180]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-apl1/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl1/igt@[email protected]

* igt@gen7_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109289]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][35] -> [DMESG-WARN][36] ([i915#1436] / [i915#716])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk3/igt@[email protected]

* igt@gen9_exec_parse@batch-zero-length:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#2856]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb8/igt@[email protected]

* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#2856])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#658])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb5/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][40] -> [FAIL][41] ([i915#454])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: NOTRUN -> [WARN][42] ([i915#1804] / [i915#2684])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][43] -> [INCOMPLETE][44] ([i915#3921])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-snb5/igt@i915_selftest@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-snb4/igt@i915_selftest@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#404])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#1769])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb4/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#110725] / [fdo#111614])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb5/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3777])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl3/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3777]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3777])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111615])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271]) +193 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#110723]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb3/igt@[email protected]

* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][54] ([i915#2705])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#3689]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs.html

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl2/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#3886]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk5/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3689] / [i915#3886])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +8 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278] / [i915#3886]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@dp-crc-fast:
- shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-snb5/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109284] / [fdo#111827]) +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb8/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk8/igt@[email protected]

* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +15 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109284] / [fdo#111827]) +6 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]

* igt@kms_color@pipe-d-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278] / [i915#1149])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb4/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][69] ([i915#1319])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl8/igt@[email protected]

* igt@kms_content_protection@content_type_change:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#111828])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb2/igt@kms_content_protection@content_type_change.html

* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][71] ([i915#1319])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#3359]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278] / [fdo#109279]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-sliding:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109279] / [i915#3359])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109274] / [fdo#109278])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb4/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#426])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb3/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][77] -> [FAIL][78] ([i915#1888] / [i915#3451])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk6/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [PASS][79] -> [INCOMPLETE][80] ([i915#2411] / [i915#456])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-tglb2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb7/igt@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109274]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb3/igt@kms_flip@2x-flip-vs-wf_vblank.html

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][82] -> [DMESG-WARN][83] ([i915#180]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-kbl7/igt@kms_flip@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][84] ([i915#180]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][85] ([i915#180]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][86] -> [SKIP][87] ([i915#3701])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb3/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271]) +59 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109280]) +15 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#111825]) +18 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][91] -> [SKIP][92] ([i915#433])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-tglb6/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb2/igt@[email protected]

* igt@kms_hdr@static-swap:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#1187])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#533])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk2/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#533])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][97] ([fdo#108145] / [i915#265]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl4/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-viewport-size-256:
- shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271]) +41 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk2/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#3536])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#112054])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl7/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#2920])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb8/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#658])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl1/igt@[email protected]

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109441]) +3 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][105] -> [SKIP][106] ([fdo#109441]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_psr@psr2_primary_render:
- shard-tglb: NOTRUN -> [FAIL][107] ([i915#132] / [i915#3467])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb1/igt@kms_psr@psr2_primary_render.html

* igt@kms_rotation_crc@multiplane-rotation:
- shard-glk: [PASS][108] -> [DMESG-FAIL][109] ([i915#118] / [i915#1888] / [i915#65])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk5/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk6/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109278]) +21 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@kms_vrr@flip-suspend:
- shard-tglb: NOTRUN -> [SKIP][111] ([fdo#109502])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb5/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl4/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2437])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl4/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#2437]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb7/igt@[email protected]

* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-tglb: NOTRUN -> [SKIP][115] ([fdo#109291])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb8/igt@prime_nv_test@i915_import_gtt_mmap.html

* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109291]) +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb6/igt@prime_udl.html

* igt@prime_vgem@fence-flip-hang:
- shard-tglb: NOTRUN -> [SKIP][117] ([fdo#109295])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb2/igt@[email protected]

* igt@sysfs_clients@fair-0:
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#2994])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb8/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl3/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-apl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-apl3/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-glk: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@smoketest:
- shard-iclb: [FAIL][122] ([i915#2896]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-iclb4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-iclb8/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [FAIL][124] -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-snb2/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-snb7/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [TIMEOUT][126] ([i915#3063]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-tglb7/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-tglb6/igt@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][128] ([i915#2842]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-kbl7/igt@gem_exec_fair@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-sync@rcs0:
- shard-kbl: [SKIP][130] ([fdo#109271]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-kbl4/igt@gem_exec_fair@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [DMESG-WARN][132] ([i915#118]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10794/shard-glk8/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/shard-glk7/igt@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [DMESG-WARN][13

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6354/index.html

#3 lore raw
In reply to Jouni Högander
Quoted 140 lines · Jouni Högander

Add biplanar formats (NV12, p010) into selective update test. Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.

v2: Add back skipping of frontbuffer rendering tests

---
 tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++---------------
 1 file changed, 58 insertions(+), 33 deletions(-)
tests/i915/kms_psr2_su.c +32 -21
index 91de9bad..ff3e114b 100644
@@ -33,7 +33,8 @@
 
 IGT_TEST_DESCRIPTION("Test PSR2 selective update");
 
-#define SQUARE_SIZE 100
+#define SQUARE_SIZE   100
+#define SQUARE_OFFSET 100
 /* each selective update block is 4 lines tall */
 #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE % 4 ? 1 : 0))
 
@@ -50,6 +51,23 @@ enum operations {
 	LAST
 };
 
+static const uint32_t formats_page_flip[] = {
+	DRM_FORMAT_XRGB8888,
+	DRM_FORMAT_NV12,
+	DRM_FORMAT_P010,
+	DRM_FORMAT_INVALID,
+};
+
+static const uint32_t formats_frontbuffer[] = {
+	DRM_FORMAT_XRGB8888,
+	DRM_FORMAT_INVALID,
+};
+
+static const uint32_t *formats[] = {
+				    [PAGE_FLIP] = formats_page_flip,
+				    [FRONTBUFFER] = formats_frontbuffer,
+};
+
 static const char *op_str(enum operations op)
 {
 	static const char * const name[] = {
@@ -68,6 +86,7 @@ typedef struct {
 	igt_output_t *output;
 	struct igt_fb fb[2];
 	enum operations op;
+	uint32_t format;
 	cairo_t *cr;
 	int change_screen_timerfd;
 	uint32_t screen_changes;
@@ -111,7 +130,7 @@ static void prepare(data_t *data)
 	/* all green frame */
 	igt_create_color_fb(data->drm_fd,
 			    data->mode->hdisplay, data->mode->vdisplay,
-			    DRM_FORMAT_XRGB8888,
+			    data->format,
 			    DRM_FORMAT_MOD_LINEAR,
 			    0.0, 1.0, 0.0,
 			    &data->fb[0]);
@@ -121,14 +140,14 @@ static void prepare(data_t *data)
 
 		igt_create_color_fb(data->drm_fd,
 				    data->mode->hdisplay, data->mode->vdisplay,
-				    DRM_FORMAT_XRGB8888,
+				    data->format,
 				    DRM_FORMAT_MOD_LINEAR,
 				    0.0, 1.0, 0.0,
 				    &data->fb[1]);
 
 		cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[1]);
 		/* paint a white square */
-		igt_paint_color_alpha(cr, 0, 0, SQUARE_SIZE, SQUARE_SIZE,
+		igt_paint_color_alpha(cr, SQUARE_OFFSET, SQUARE_OFFSET, SQUARE_SIZE, SQUARE_SIZE,
 				      1.0, 1.0, 1.0, 1.0);
 		igt_put_cairo_ctx(cr);
 	} else if (data->op == FRONTBUFFER) {
@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)
 		struct drm_mode_rect clip;
 		igt_plane_t *primary;
 
-		clip.x1 = clip.y1 = 0;
-		clip.x2 = clip.y2 = SQUARE_SIZE;
+		clip.x1 = clip.y1 = SQUARE_OFFSET;
+		clip.x2 = clip.y2 = SQUARE_OFFSET + SQUARE_SIZE;
 
 		primary = igt_output_get_plane_type(data->output,
 						    DRM_PLANE_TYPE_PRIMARY);
@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)
 	case FRONTBUFFER: {
 		drmModeClip clip;
 
-		clip.x1 = clip.y1 = 0;
-		clip.x2 = clip.y2 = SQUARE_SIZE;
+		clip.x1 = clip.y1 = SQUARE_OFFSET;
+		clip.x2 = clip.y2 = SQUARE_OFFSET + SQUARE_SIZE;
 
 		if (data->screen_changes & 1) {
 			/* go back to all green frame with a square */
-			igt_paint_color_alpha(data->cr, 0, 0, SQUARE_SIZE,
+			igt_paint_color_alpha(data->cr, SQUARE_OFFSET,
+					      SQUARE_OFFSET, SQUARE_SIZE,
 					      SQUARE_SIZE, 1.0, 1.0, 1.0, 1.0);
 		} else {
 			/* go back to all green frame */
-			igt_paint_color_alpha(data->cr, 0, 0, SQUARE_SIZE,
+			igt_paint_color_alpha(data->cr, SQUARE_OFFSET,
+					      SQUARE_OFFSET, SQUARE_SIZE,
 					      SQUARE_SIZE, 0, 1.0, 0, 1.0);
 		}
 
@@ -261,6 +282,7 @@ igt_main
 					 data.debugfs_fd, PSR_MODE_2),
 			      "Error enabling PSR2\n");
 		data.op = FRONTBUFFER;
+		data.format = DRM_FORMAT_XRGB8888;
 		prepare(&data);
 		r = psr_wait_entry(data.debugfs_fd, PSR_MODE_2);
 		cleanup(&data);
@@ -281,31 +303,34 @@ igt_main
 	}
 
 	for (data.op = PAGE_FLIP; data.op < LAST; data.op++) {
-		igt_describe("Test that selective update works when screen changes");
-		igt_subtest_f("%s", op_str(data.op)) {
-
-			if (data.op == FRONTBUFFER &&
-			    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
-				/*
-				 * FIXME: Display 12+ platforms now have PSR2
-				 * selective fetch enabled by default but we
-				 * still can't properly handle frontbuffer
-				 * rendering, so right it does full frame
-				 * fetches at every frontbuffer rendering.

tests/i915/kms_psr2_su.c igt_main · line 311

Quoted 10 lines
tests/i915/kms_psr2_su.c +6 -4
-				 * So it is expected that this test will fail
-				 * in display 12+ platform fow now.
-				 */
-				igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+		const uint32_t *format = formats[data.op];
+
+		while (*format != DRM_FORMAT_INVALID) {
+			data.format = *format++;
+			igt_describe("Test that selective update works when screen changes");
+			igt_subtest_f("%s_%s", op_str(data.op), igt_format_str(data.format)) {

Use %s-%s as the name instead.

--
Petri Latvala

Quoted 36 lines
tests/i915/kms_psr2_su.c +20 -8
+				if (data.op == FRONTBUFFER &&
+				    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
+					/*
+					 * FIXME: Display 12+ platforms now have PSR2
+					 * selective fetch enabled by default but we
+					 * still can't properly handle frontbuffer
+					 * rendering, so right it does full frame
+					 * fetches at every frontbuffer rendering.
+					 * So it is expected that this test will fail
+					 * in display 12+ platform for now.
+					 */
+					igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+				}
+				prepare(&data);
+				run(&data);
+				cleanup(&data);
 			}
-
-			prepare(&data);
-			run(&data);
-			cleanup(&data);
 		}
-	}
 
-	igt_fixture {
-		close(data.debugfs_fd);
-		display_fini(&data);
+		igt_fixture {
+			close(data.debugfs_fd);
+			display_fini(&data);
+		}
 	}
 }
Signature · 1 line
2.25.1
#4 lore raw
Quoted 9 lines · Petri Latvala
Quoted 7 lines
tests/i915/kms_psr2_su.c +3 -0
+		while (*format != DRM_FORMAT_INVALID) {
+			data.format = *format++;
+			igt_describe("Test that selective update works

when screen changes");

(quoted diff) +1 -0
+			igt_subtest_f("%s_%s", op_str(data.op),

igt_format_str(data.format)) {

Use %s-%s as the name instead.

Fixed and new version sent. Thank you for your review.

Quoted 3 lines

--
Petri Latvala

BR,

Jouni Högander