Skip to contentSkip to conversation

common: fix buffer length in phone_number_to_string

PATCH In review Frédéric Danis 2 participants 2 messages Mar 23, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common: fix buffer length in phone_number_to_string

update buffer length related to OFONO_MAX_PHONE_NUMBER_LENGTH change 78c1e96bf9601b5e5d31d04413baa1265a1c284f

---
 src/common.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
src/common.c +5 -5
index 520360c..e65a677 100644
@@ -422,16 +422,16 @@ int mmi_service_code_to_bearer_class(int code)
 
 const char *phone_number_to_string(const struct ofono_phone_number *ph)
 {
-	static char buffer[64];
+	static char buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 2];
 
 	if (ph->type == 145 && (strlen(ph->number) > 0) &&
 			ph->number[0] != '+') {
 		buffer[0] = '+';
-		strncpy(buffer + 1, ph->number, 62);
-		buffer[63] = '\0';
+		strncpy(buffer + 1, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH);
+		buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0';
 	} else {
-		strncpy(buffer, ph->number, 63);
-		buffer[63] = '\0';
+		strncpy(buffer, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH + 1);
+		buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0';
 	}
 
 	return buffer;
Signature · 1 line
1.7.1
#1 lore raw

Hi Frédéric,

Quoted 6 lines · Frédéric Danis

update buffer length related to OFONO_MAX_PHONE_NUMBER_LENGTH change 78c1e96bf9601b5e5d31d04413baa1265a1c284f

---
 src/common.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

Nice catch. Patch has been applied, thanks.

Regards,
-Denis