Skip to contentSkip to conversation

hostcc/hostcxx: fix noccache variant setting

PATCH New Mike Frysinger 2 participants 2 messages Mar 28, 2011 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hostcc/hostcxx: fix noccache variant setting

The current code accidentally sets up HOSTCC_NOCCACHE and HOSTCXX_NOCCACHE only when the respective HOSTCC or HOSTCXX values are not set. So if you do something like:
make HOSTCC=gcc menuconfig
The build fails because HOSTCC_NOCCACHE is not set anywhere.

---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 7ae3787..9aa7399 100644
@@ -126,13 +126,13 @@ endif
 ifndef HOSTCC
 HOSTCC:=gcc
 HOSTCC:=$(shell which $(HOSTCC) || type -p $(HOSTCC) || echo gcc)
-HOSTCC_NOCCACHE:=$(HOSTCC)
 endif
+HOSTCC_NOCCACHE:=$(HOSTCC)
 ifndef HOSTCXX
 HOSTCXX:=g++
 HOSTCXX:=$(shell which $(HOSTCXX) || type -p $(HOSTCXX) || echo g++)
-HOSTCXX_NOCCACHE:=$(HOSTCXX)
 endif
+HOSTCXX_NOCCACHE:=$(HOSTCXX)
 ifndef HOSTFC
 HOSTFC:=gfortran
 endif
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 hostcc/hostcxx: fix noccache variant setting

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Mike> The current code accidentally sets up HOSTCC_NOCCACHE and HOSTCXX_NOCCACHE Mike> only when the respective HOSTCC or HOSTCXX values are not set. So if you Mike> do something like:
Mike> make HOSTCC=gcc menuconfig
Mike> The build fails because HOSTCC_NOCCACHE is not set anywhere.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard