Remove default_preference game as everybody wants to use the latest version, but the default_prefernce is -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version or default_preference bump
PATCH 1/1 Remove default_preference game as everybody wants to use the latest version, but the default_prefernce is -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version or default_preference bump
--- recipes/poppler/poppler_0.12.3.bb | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
recipes/poppler/poppler_0.12.3.bb +0 -5
@@ -2,11 +2,6 @@ require poppler.inc DEPENDS += "lcms" -DEFAULT_PREFERENCE = "-1" -DEFAULT_PREFERENCE_angstrom = "1" -DEFAULT_PREFERENCE_minimal = "1" -DEFAULT_PREFERENCE_minimal-uclibc = "1" - EXTRA_OECONF_append = " --disable-abiword-output " RDEPENDS_${PN} = "poppler-data"
Signature · 1 line
1.7.2.5
Re: [PATCH] poppler 0.12.3: remove "default_preference = -1"
Dear Philippe,
please read the commit policy [1] and example [2] on how to format the commit message. You do not have to resend this patch as I will edit the commit message before pushing your patch.
Am Montag, den 28.03.2011, 21:33 +0300 schrieb phdeswer:
Quoted 4 lines
remove
default_preferencegame as everybody wants to use the latest version, but thedefault_prefernceis -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version ordefault_preferencebump
Please note that you can always set your preferred version in conf/local.conf.
Quoted 12 lines
Signed-off-by phdeswer <[email protected]>--- recipes/poppler/poppler_0.12.3.bb | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)recipes/poppler/poppler_0.12.3.bb +0
-0@@ -2,11 +2,6 @@ require poppler.inc
recipes/poppler/poppler_0.12.3.bb require poppler.inc · line 7
Quoted 10 lines
recipes/poppler/poppler_0.12.3.bb +0
-5DEPENDS += "lcms" -DEFAULT_PREFERENCE = "-1" -DEFAULT_PREFERENCE_angstrom = "1" -DEFAULT_PREFERENCE_minimal = "1" -DEFAULT_PREFERENCE_minimal-uclibc = "1" - EXTRA_OECONF_append = " --disable-abiword-output " RDEPENDS_${PN} = "poppler-data"
Do all distribution maintainers agree with this patch? I do not see a problem since it has been used in tested in Ȧngström and minimal{,-uclibc} for over six months.
Thanks,
Paul
[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/Commit_log_example
Martin Jansa
Acked-byRe: [PATCH] poppler 0.12.3: remove "default_preference = -1"
Quoted 38 lines · Paul Menzel
Dear Philippe,
please read the commit policy [1] and example [2] on how to format the commit message. You do not have to resend this patch as I will edit the commit message before pushing your patch.
Am Montag, den 28.03.2011, 21:33 +0300 schrieb phdeswer:
Quoted 4 lines
remove
default_preferencegame as everybody wants to use the latest version, but thedefault_prefernceis -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version ordefault_preferencebumpPlease note that you can always set your preferred version in
conf/local.conf.Quoted 21 lines
Signed-off-by phdeswer <[email protected]>--- recipes/poppler/poppler_0.12.3.bb | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)recipes/poppler/poppler_0.12.3.bb +0
-5@@ -2,11 +2,6 @@ require poppler.inc DEPENDS += "lcms" -DEFAULT_PREFERENCE = "-1" -DEFAULT_PREFERENCE_angstrom = "1" -DEFAULT_PREFERENCE_minimal = "1" -DEFAULT_PREFERENCE_minimal-uclibc = "1" - EXTRA_OECONF_append = " --disable-abiword-output "
Quoted 5 lines
recipes/poppler/poppler_0.12.3.bb require poppler.inc · line 7
Quoted 1 line
recipes/poppler/poppler_0.12.3.bb +0
-0RDEPENDS_${PN} = "poppler-data"Do all distribution maintainers agree with this patch? I do not see a problem since it has been used in tested in Ȧngström and minimal{,-uclibc} for over six months.
and in SHR too (pinned in preferred-shr-versions.inc), feel free to remove it there too.
Quoted 17 lines
Acked-by Paul Menzel <[email protected]>Thanks,
Paul
[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/Commit_log_example_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Re: [PATCH] poppler 0.12.3: remove "default_preference = -1"
Dear Philippe,
Am Dienstag, den 29.03.2011, 10:56 +0200 schrieb Martin Jansa:
Quoted 43 lines · Paul Menzel
Quoted 36 lines
please read the commit policy [1] and example [2] on how to format the commit message. You do not have to resend this patch as I will edit the commit message before pushing your patch.
Am Montag, den 28.03.2011, 21:33 +0300 schrieb phdeswer:
Quoted 4 lines
remove
default_preferencegame as everybody wants to use the latest version, but thedefault_prefernceis -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version ordefault_preferencebumpPlease note that you can always set your preferred version in
conf/local.conf.Quoted 21 lines
Signed-off-by phdeswer <[email protected]>--- recipes/poppler/poppler_0.12.3.bb | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)recipes/poppler/poppler_0.12.3.bb +0
-5@@ -2,11 +2,6 @@ require poppler.inc DEPENDS += "lcms" -DEFAULT_PREFERENCE = "-1" -DEFAULT_PREFERENCE_angstrom = "1" -DEFAULT_PREFERENCE_minimal = "1" -DEFAULT_PREFERENCE_minimal-uclibc = "1" - EXTRA_OECONF_append = " --disable-abiword-output "Quoted 5 lines
recipes/poppler/poppler_0.12.3.bb require poppler.inc · line 7
Quoted 1 line
recipes/poppler/poppler_0.12.3.bb +0
-0RDEPENDS_${PN} = "poppler-data"Do all distribution maintainers agree with this patch? I do not see a problem since it has been used in tested in Ȧngström and minimal{,-uclibc} for over six months.
Quoted 6 lines
and in SHR too (pinned in preferred-shr-versions.inc), feel free to remove it there too.
Acked-by Martin Jansa <[email protected]>Quoted 1 line
Acked-by Paul Menzel <[email protected]>
I pushed the edited patch in bb63320b [3]. Philippe, please update the state of your patch in the patch queue [4], since I do not have the permissions to do so.
bin/pwclient update -s Accepted -c bb63320bc4c955c51619d73cfc622001d602911a 1837
Thanks,
Paul
Quoted 2 lines
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=bb63320bc4c955c51619d73cfc622001d602911a
[4] http://openembedded.org/index.php/Patchwork
Re: [PATCH] poppler 0.12.3: remove "default_preference = -1"
In reply to Paul MenzelHi Paul,
Quoted 3 lines · Paul Menzel
please read the commit policy [1] and example [2] on how to format the commit message. You do not have to resend this patch as I will edit the commit message before pushing your patch.
Thanks. Seem they are still pretty the same as way back when I had commit rights on the monotone OE tree... Things got a bit complicated due to my inexperience with git. So some stuff went wrong... My second patch looks already better ;)
Quoted 9 lines
Am Montag, den 28.03.2011, 21:33 +0300 schrieb phdeswer:
Quoted 4 lines
remove
default_preferencegame as everybody wants to use the latest version, but thedefault_prefernceis -1 so this fails building packages that depend on poppler if not used with a distro that has a preferred version ordefault_preferencebumpPlease note that you can always set your preferred version in
conf/local.conf.
I know. Or in a distro/include/<distro-name>.inc with preferred_versions...
Quoted 22 lines
Quoted 22 lines
Signed-off-by phdeswer <[email protected]>--- recipes/poppler/poppler_0.12.3.bb | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)recipes/poppler/poppler_0.12.3.bb +0
-5@@ -2,11 +2,6 @@ require poppler.inc DEPENDS += "lcms" -DEFAULT_PREFERENCE = "-1" -DEFAULT_PREFERENCE_angstrom = "1" -DEFAULT_PREFERENCE_minimal = "1" -DEFAULT_PREFERENCE_minimal-uclibc = "1" - EXTRA_OECONF_append = " --disable-abiword-output "
Quoted 5 lines
recipes/poppler/poppler_0.12.3.bb require poppler.inc · line 7
Quoted 1 line
recipes/poppler/poppler_0.12.3.bb +0
-0RDEPENDS_${PN} = "poppler-data"Do all distribution maintainers agree with this patch? I do not see a problem since it has been used in tested in Ȧngström and minimal{,-uclibc} for over six months.
No idea. It is just that if you do a default build without Angstrom or other distro it will pick the wrong version (unless you set a preferred version). Removing the distro specific workarounds and the default_preference= -1 makes it pick that version. Even Debian stable is ahead of us there as they use poppler 0.12.4... I also hoped this patch would bring up why there are all the workarounds in that file.
Thanks a lot! And hopefully I'll do a bit better on the next patch.
Philippe