Skip to contentSkip to conversation

xfsprogs: avoid dot-directories when configuring

PATCH Alex Elder 2 participants 2 messages Mar 30, 2011

lore
Share & tools
lore

Alex Elder

author
#0 lore raw

The "find" command used in the configure script to find localized files searches through directories (including .git and .pc) that really should be ignored. Change it so it skips over these directories.

I think it's reasonable to assume any such "dot directory" should be ignored, so this change skips any directory at the top level whose name begins with ".".

Note that I found an odd anomaly in "find". If you do not supply the "-print" argument, the pruned directory names show up in the output. Supplying "-print" does not include them (and that's what we want).

---
 configure.in |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
configure.in +5 -2
Index: b/configure.in
===================================================================
@@ -76,9 +76,12 @@ esac
 AC_SUBST([root_sbindir])
 AC_SUBST([root_libdir])
 
-# Find localized files
+# Find localized files.  Don't descend into any "dot directories"
+# (like .git or .pc from quilt).  Strangely, the "-print" argument
+# to "find" is required, to avoid including such directories in the
+# list.
 LOCALIZED_FILES=""
-for lfile in `find ${srcdir} -name '*.c' -type f || exit 1`; do
+for lfile in `find ${srcdir} -path './.??*' -prune -o -name '*.c' -type f -print || exit 1`; do
     LOCALIZED_FILES="$LOCALIZED_FILES \$(TOPDIR)/$lfile"
 done
 AC_SUBST(LOCALIZED_FILES)

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs